"Nokia submits this code under the terms of a commercial contribution agreement with RealNetworks, and I am authorized to contribute this code under said agreement."
 
Modified by:  ext-debashis.2.panigrahi at nokia.com
 
Reviewed by:  Ashish.As.Gupta at nokia.com
 
RC Id: ou1cimx1#503969
 
Date: 08/04/2010
	 
Project: SymbianMmf_wm
 
Synopsis: Security: MMFControllerProxyServer-25a KERN-EXEC 3" is detected when running RTSP test cases 1336 and 1350.
 
Overview:
The crash is due to null pointer access as URL info is not present in the response string. This causes lURL to be NULL and afterwards a crash is being observed as we call ReadRTPInfoEntry() inside SetRTPInfoEntry(.).

Fix:
Now going for further processing of the url only if it is valid /exists. Additionally also checking for pSeq and pRTPTime, as we might get another crash if both of the values are NULL.

Files modified & changes:
protocol/rtsp/rtsppars.cpp

Image Size and Heap Use impact: No major impact
 
Module Release testing (STIF) : Passed
 
Test case(s) Added  : No

Memory leak check performed : Passed, No additional leaks introduced.
 
Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp
 
Platforms and Profiles Functionality verified: armv5, winscw
 
Branch: 210CayS, 420Bizo and HEAD

CVS Diff on 210CayS:
Index: rtsppars.cpp
===================================================================
RCS file: /cvsroot/protocol/rtsp/rtsppars.cpp,v
retrieving revision 1.14.2.1
diff -u -w -r1.14.2.1 rtsppars.cpp
--- rtsppars.cpp        12 Jul 2010 05:15:05 -0000      1.14.2.1
+++ rtsppars.cpp        26 Jul 2010 12:22:59 -0000
@@ -385,6 +385,8 @@
     lURL = in.Find("url=");
     HX_ASSERT(lURL == 0);

+   if (lURL && (pSeq || pRTPTime))
+         {
     if (pSeq)
     {
         lSeq = pSeq - pIn;
@@ -448,6 +450,7 @@

     pHeader->addHeaderValue(pHeaderValue);

+   }
     return 0;
 }