Great work Tom.  Please check it in.


On Wed, 13 Oct 2004, Damon Lanphear wrote:

> Go,
> 
> I'm OK with this change, so the final OK is up to you.
> 
> On Oct 13, 2004, at 4:52 PM, Tom Marshall wrote:
> 
> >>> Also, as you are aware, write buffer was written initially to 
> >>> support MDP
> >>> Instant on initiative with TCP as a transport.  There have been a 
> >>> plenty
> >>> of tests conducted on this use case.  Please speak to your testing 
> >>> on this
> >>> area to make sure this change does not negatively impact such an 
> >>> effort.
> >
> > There was an issue with MDP -- the code in rdttran.cpp is incorrect.  
> > It
> > looks for HXR_OK from WriteV() instead of using the SUCCEEDED macro.  
> > Damon
> > verified this and the fix is attached.  With this change in place, 
> > RDTv3
> > behaves properly.
> >
> > I've also renamed sendqueue to writequeue for consistency and done 
> > some work
> > to reduce spurious SelectEvent calls.  New diff to sockimp is also 
> > attached.
> >
> > Is this okay for checkin?
> >
> > -- 
> > I stayed up all night playing poker with tarot cards.  I got a full
> > house and four people died.
> >         -- Steven Wright
> > <rdttran.diff><sockimp.diff>
> 
> 
> 

-- 
Go Hori
ghori at real.com