Modified by: acolwell at real.com

Reviewed by: ehyche at real.com

Date: 10:13:2004

Project: HEAD

On Wed, Oct 13, 2004 at 08:46:31AM -0400, Eric Hyche wrote:
> 
> This looks good to me.
> 
> Eric
> 
> At 07:08 PM 10/12/2004 -0700, Aaron Colwell wrote:
> 
> >Synopsis: Helix-Adaptation spec compliance fixes
> >
> >Overview: Vijay setup a server for me to test the client Helix-Adaptation
> >          header functionality. The client sent the Helix-Adaptation header
> >          to the server, but the server did not respond to it. This caused 
> >          me
> >          to think that my code was doing something wrong. After looking at
> >          the spec a little closer, I noticed that it specifies that some
> >          parameters are required to be present, and it also specifies a
> >          specific order for the parameters. These changes make the code
> >          spec compliant by making sure the required parameters are present
> >          and it sends them in the specified order. Here is a list of the
> >          changes.
> >
> >          - Added the requiredParams() virtual function to 
> >CHXAdaptationHeader
> >            and made the default implementation only require the url 
> >parameter.
> >
> >          - Added the paramOrder() virtual function to 
> >CHXAdaptationHeader and
> >            made the default implementation only require the url parameter 
> >            to
> >            be first.
> >
> >          - Added CHXAdaptationHeader::HasRequiredParams() which checks 
> >to see
> >            if the require parameters are present. A call to this 
> >function was
> >            added to CHXAdaptationHeader::AreValuesValid().
> >
> >          - Changed the code in CHXAdaptationHeader::GetString() so that it
> >            outputs the parameters specified by paramOrder() first and then
> >            appends any remaining parameters after that.
> >
> >          - Overloaded requireParams() and paramOrder() in
> >            CHelixAdaptationHeader so that they specify the required 
> >parameters
> >            and parameter order mandated by the spec.
> >
> >
> >          Eventhough these changes make the client code spec compliant, I 
> >          am
> >          still not able to get the server to respond to the header I send.
> >          I'm sure Vijay and I will figure that out tomorrow.
> >
> >Files Modified:
> >protocol/rtsp/adapthdr.cpp
> >protocol/rtsp/helixadapthdr.cpp
> >protocol/rtsp/pub/adapthdr.h
> >protocol/rtsp/pub/helixadapthdr.h
> >
> >
> >Files Added: none
> >
> >Image Size and Heap Use impact:
> >
> >Platforms and Profiles affected: all
> >
> >Distribution Libraries affected: none
> >
> >Distribution library impact and planned action: none
> >
> >Platforms and Profiles Build Verified: win32
> >
> >Platforms and Profiles Functionality verified: win32
> >
> >Branch: HEAD
> >
> >QA Instructions: none
> >