Modified by: acolwell at real.com

Reviewed by: ehyche at real.com

Date: 10:12:2004

Project: HEAD


On Tue, Oct 12, 2004 at 05:50:27PM -0400, Eric Hyche wrote:
> 
> These changes look good to me.
> 
> I'm going to start lobbying Rob Lanphier to have the
> $Id:$ removed from the license headers, but that's
> neither here nor there for this diff.
> 
> Eric
> 
> At 05:38 PM 10/11/2004 -0700, Aaron Colwell wrote:
> >Synopsis: Add Helix-Adaptation header support
> >
> >Overview: Here are the changes needed to support the Helix-Adaptation 
> >header.
> >
> >          - Updated SDP parser so that it handles the 
> >Helix-Adaptation-Support
> >            header.
> >
> >          - Moved code in C3gpAdaptationHeader to CHXAdaptationHeader. This
> >            was done to allow sharing of common code between the 3gp 
> >adaptation
> >            header code and the Helix adaptation header code.
> >
> >          - Made C3gpAdaptationHeader derive from CHXAdaptationHeader and
> >            supply the 2 virtual functions that tell the base class what
> >            are the valid integer and string parameters for this header
> >
> >          - Created CHelixAdaptationHeader. This class derives from
> >            CHXAdaptationHeader and provides an expanded set of valid
> >            parameters.
> >
> >          - Removed the Copy() function from the C3gpAdaptationHeader code
> >            since it wasn't used and would cause diffuculties now that this
> >            code would have been part of a base class. The test cases for 
> >            the
> >            copy function were also removed from the unit test.
> >
> >          - Fixed a bug in RTSPClientProtocol where the rate adaptation 
> >headers
> >            would not be generated for SDP initiated playback. This was 
> >caused
> >            by the rate adaptation handling objects not being instantiated
> >            early enough InitExt(). The creation of these objects were 
> >            moved
> >            closer to the top of the function.
> >
> >          - CHXRateAdaptationInfo was modified to look for the Helix header
> >            as well as the 3GPP header.
> >
> >          - The License headers were updated to match other files in this
> >            directory.
> >
> >Files Modified:
> >protocol/sdp/sdpmdparse.cpp
> >protocol/rtsp/3gpadapthdr.cpp
> >protocol/rtsp/Umakefil
> >protocol/rtsp/rateadaptinfo.cpp
> >protocol/rtsp/rateadaptinfo.h
> >protocol/rtsp/rtspclnt.cpp
> >protocol/rtsp/pub/3gpadapthdr.h
> >protocol/rtsp/test/3gpadapthdr_test.cpp
> >protocol/rtsp/test/3gpadapthdr_test.h
> >protocol/rtsp/test/t3gpadapthdr.in
> >
> >
> >Files Added:
> >protocol/rtsp/adapthdr.cpp
> >protocol/rtsp/helixadapthdr.cpp
> >protocol/rtsp/pub/adapthdr.h
> >protocol/rtsp/pub/helixadapthdr.h
> >
> >Image Size and Heap Use impact:
> >
> >Platforms and Profiles affected: all
> >
> >Distribution Libraries affected: none
> >
> >Distribution library impact and planned action: none
> >
> >Platforms and Profiles Build Verified: win32
> >
> >Platforms and Profiles Functionality verified: win32
> >
> >Branch: HEAD
> >
> >QA Instructions: none