[hxprotocol] CR: parsing for RTCP HELX APP packets

[hxprotocol] CR: parsing for RTCP HELX APP packets

Go Hori ghori at real.com
Tue Jul 15 13:03:49 PDT 2003


looks good.
Go

On 15 Jul 2003, Damon Lanphear wrote:

> The RTCP packet parser would not unpack RTCP APP packets with an
> application name other than RNWK.  This prevented the unpacking of RTCP
> APP packets with an application name of HELX.  This fix is as follows: 
> 
> Index: protocol/transport/rtp/pub/rtpwrap.h
> ===================================================================
> RCS file: /cvs/protocol/transport/rtp/pub/rtpwrap.h,v
> retrieving revision 1.4
> diff -u -r1.4 rtpwrap.h
> --- protocol/transport/rtp/pub/rtpwrap.h	8 Apr 2003 20:53:39 -0000	1.4
> +++ protocol/transport/rtp/pub/rtpwrap.h	15 Jul 2003 18:51:03 -0000
> @@ -279,7 +279,8 @@
>  	memcpy(pOff, app_data, (length - 2) * 4); /* Flawfinder: ignore */
>  	app_data = pOff;
>  
> -	if (0 == strcmp((const char*)pc, "RNWK"))
> +	if ((0 == strncmp((const char*)pc, "RNWK", 4)) || 
> +	    (0 == strncmp((const char*)pc, "HELX", 4)))
>  	{
>  	    // it's ours
>  	    m_pAPPItems = new APPItem[count];
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe at protocol.helixcommunity.org
> For additional commands, e-mail: dev-help at protocol.helixcommunity.org
> 
> 

-- 
Go Hori
ghori at real.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at protocol.helixcommunity.org
For additional commands, e-mail: dev-help at protocol.helixcommunity.org




More information about the Protocol-dev mailing list
 

Site Map   |   Terms of Use   |   Privacy Policy   |   Contact Us

Copyright © 1995-2007 RealNetworks, Inc. All rights reserved. RealNetworks and Helix are trademarks of RealNetworks.
All other trademarks or registered trademarks are the property of their respective holders.