I would think RR value should be passed into the sdpmgen with header prop
value so you can actually change the value per stream (maybe based on clip
rate or delivery method).

Other than that:
Why is m_ulRTCPBandwidth a member variable?  
Shouldn't config name be "RTCPRRBandwidth" to signify b=RR in case you 
want to add one for b=RS later?
Go

On 2 Jul 2003, Damon Lanphear wrote:

> Please review the following change to add support for setting the b=RR
> field in generated SDP descriptions.  The purpose of the change is to
> allow an end user to provide a rate at which RTCP ReceiverReports will
> be transmitted by the receiver of the described session.  
> 
> 
> Index: sdpmdgen.cpp
> ===================================================================
> RCS file: /cvs/protocol/sdp/sdpmdgen.cpp,v
> retrieving revision 1.8
> diff -u -r1.8 sdpmdgen.cpp
> --- sdpmdgen.cpp	25 Jun 2003 21:06:03 -0000	1.8
> +++ sdpmdgen.cpp	2 Jul 2003 22:44:31 -0000
> @@ -52,7 +52,8 @@
>      m_ulVersion(ulVersion),
>      m_bUseOldEOL(FALSE),
>      m_bUseSessionGUID(FALSE),
> -    m_bUseAbsoluteURL(FALSE)
> +    m_bUseAbsoluteURL(FALSE),
> +    m_ulRTCPBandwidth(0)
>  {}
>  
>  SDPMediaDescGenerator::~SDPMediaDescGenerator()
> @@ -71,7 +72,16 @@
>  
>      if (pContext)
>      {
> -        pContext->QueryInterface(IID_IHXRegistry,
> (void**)&m_pRegistry);
> +	if (SUCCEEDED(pContext->QueryInterface(IID_IHXRegistry,
> (void**)&m_pRegistry)))
> +	{
> +	    INT32 lTemp = 0;
> +	    if
> (SUCCEEDED(m_pRegistry->GetIntByName("config.MediaDelivery.Transport.RTCPBandwidth",
> +						    lTemp)))
> +	    {
> +		m_ulRTCPBandwidth = (UINT32)lTemp;
> +	    }
> +						    
> +	}
>  
>          res = pContext->QueryInterface(IID_IHXCommonClassFactory,
>                                         (void**)&m_pCCF);
> @@ -687,6 +697,12 @@
>          SafeSprintf(psz256, 256, "b=AS:%u%s", avgBitRate, pszEOL); 
>          mDesc += psz256;
>          bFoundAvgBitRate = FALSE;
> +    }
> +
> +    if (m_ulRTCPBandwidth)
> +    {
> +        SafeSprintf(psz256, 256, "b=RR:%u%s", m_ulRTCPBandwidth,
> pszEOL); 
> +        mDesc += psz256;
>      }
>  
>      mDesc += "t=0 0";
> Index: pub/sdpmdgen.h
> ===================================================================
> RCS file: /cvs/protocol/sdp/pub/sdpmdgen.h,v
> retrieving revision 1.2
> diff -u -r1.2 sdpmdgen.h
> --- pub/sdpmdgen.h	2 Jan 2003 22:02:02 -0000	1.2
> +++ pub/sdpmdgen.h	2 Jul 2003 22:44:31 -0000
> @@ -71,6 +71,7 @@
>      BOOL m_bUseOldEOL;
>      BOOL m_bUseSessionGUID;
>      BOOL m_bUseAbsoluteURL;
> +    UINT32 m_ulRTCPBandwidth;
>  };
>  
>  #endif /* SDPMDESCPACK_H */
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe at protocol.helixcommunity.org
> For additional commands, e-mail: dev-help at protocol.helixcommunity.org
> 
> 

-- 
Go Hori
ghori at real.com




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at protocol.helixcommunity.org
For additional commands, e-mail: dev-help at protocol.helixcommunity.org