Looks good.

Aaron

On Mon, 15 Dec 2003, Jonathan H.H. Bloedow wrote:

> This fixes a bug introduced on October 3, 2003, Revision 1.44 ("code 
> cleanup for size reduction"). The result is that the dlls do not get 
> unloaded when we do rtsp playback, adding ~700 kb to the memory usage. Of 
> course one could argue that the beauty of COM and ref counting is that it's 
> far from obvious that calling GetPlugin will have an implicit AddRef 
> somewhere in there, but that's another story.
> 
> -- Jonathan
> 
> 
> Index: rtspclnt.cpp
> ===================================================================
> RCS file: /cvs/protocol/rtsp/rtspclnt.cpp,v
> retrieving revision 1.62
> diff -b -u -5 -r1.62 rtspclnt.cpp
> --- rtspclnt.cpp	15 Dec 2003 21:17:06 -0000	1.62
> +++ rtspclnt.cpp	15 Dec 2003 23:08:44 -0000
> @@ -1040,10 +1040,11 @@
>   	for(ULONG32 i=0;i<ulNumPlugins;++i)
>   	{
>   	    if (SUCCEEDED(pPluginGroupEnum->GetPlugin(i, pUnknown)))
>   	    {
>                   GetStreamDescriptionInfo(pUnknown, mimeTypes);
> +                HX_RELEASE(pUnknown);
>   	    }
>   	}
>       }
>       else
>       {
> @@ -1063,10 +1064,11 @@
>   	    for(ULONG32 i=0;i<ulNumPlugins;++i)
>   	    {
>   		if(SUCCEEDED(pPluginEnumerator->GetPlugin(i, pUnknown)))
>   		{
>                       GetStreamDescriptionInfo(pUnknown, mimeTypes);
> +                    HX_RELEASE(pUnknown);
>                   }
>   	    }
>   	    pPluginEnumerator->Release();
>   	}
>       }
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe at protocol.helixcommunity.org
> For additional commands, e-mail: dev-help at protocol.helixcommunity.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe at protocol.helixcommunity.org
For additional commands, e-mail: dev-help at protocol.helixcommunity.org