Thanks Eric,

Changes have been checked in to Atlas_310, Atlas_341 & Head.

Thanks & Regards,
Vipin Kumar Tyagi


Eric Hyche wrote:
> Looks good.
>
> =======================================
> Eric Hyche (ehyche at real.com)
> Principal Engineer
> RealNetworks, Inc.
>
>   
>> -----Original Message-----
>> From: Vipin Kumar Tyagi [mailto:vtyagi at real.com]
>> Sent: Tuesday, September 09, 2008 2:35 AM
>> To: player-dev at helixcommunity.org
>> Cc: Eric Hyche; Nicole Hamilton; Leina Tani; Vipin Kumar Tyagi
>> Subject: CR: For Bug 8564 GetVideoFrame dbus method for generating video thumbnails locks the file.
>>
>> Synopsis:
>> GetVideoFrame dbus method for generating video thumbnails should not locks the file.
>>
>> Overview:
>>
>> In file CHXClientThumbnailUnix.cpp in function CreateThumbnail we are intializing thumbnail engine but
>> not releasing thumbnail engine for the case in which g_thumbnailEngineUnix.Drive returns a non zero
>> value.
>>
>> For non supported data types g_thumbnailEngineUnix.Drive returns error code 80004005 ( HXR_FAIL).
>>
>> Now releasing it for fail case also. now able to umount the USB safely.
>>
>> Files Added:
>>
>>
>> Files Modified:
>> player/hxclientkit/src/platform/unix/CHXClientThumbnailUnix.cpp
>>
>> Image Size and Heap Use impact (Client -Only):
>> None.
>>
>> Platforms and Profiles Affected:
>> None
>>
>> Distribution Libraries Affected:
>> None
>>
>> Distribution library impact and planned action:
>> None
>>
>> Platforms and Profiles Build Verified:
>> BIF branch    ->hxclient_3_4_1_atlas_restricted
>> Target(s)      -> player_mid_all_installers
>> Profile          ->helix-client-moblin
>> SYSTEM_ID ->linux-2.2-libc6-gcc32-i586
>>
>> Branch:
>> hxclient_3_1_0_atlas, hxclient_3_4_1_atlas, HEAD
>>
>> Files Attached:
>> diff.txt
>>
>>
>> Thanks & Regards,
>> Vipin Kumar Tyagi
>>     
>
>
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/player-dev/attachments/20080910/d879b893/attachment.html