My comments:

1) We should not call the variable g_pThumbnailEngineUnix
   if it is no longer a pointer.

2) I think a good longer-term change would be to avoid
   using globals for this at all. When the user calls
   InitThumbnailEngine(), it could return an opaque pointer
   as an out parameter, which the user would then need to pass
   back into CreateThumbnail() and ReleaseThumbnailEngine().

   I'm OK with not making this change now, but I think this
   is something we should think about doing in the future.
   The lifetime of module-level globals such as these is
   managed by when the shared library is unloaded, and 
   in my experience, this creates many more headaches (and
   strange bugs) down the road.

Eric

=============================================
Eric Hyche (ehyche at real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounces at helixcommunity.org 
> [mailto:player-dev-bounces at helixcommunity.org] On Behalf Of 
> Chen, Weian
> Sent: Wednesday, March 26, 2008 3:07 AM
> To: helix-client-dev at helixcommunity.org
> Cc: Shen, Cathy; player-dev at helixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev] CR: refine the 
> source code forthumbnail feature
> 
> Synopsis: 
> 
>  Refine the source code for thumbnail 
> 
>  
> 
> Overview: 
> 
>   We refine the source code for thumbnail feature, such as 
> the initialization, function call etc.  
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   helix-dbus-server.cpp (player\kit\dbus-server\src\)
> 
>   CHXClientThumbnailUnix.cpp (player\hxclientkit\src\platform\unix)
> 
>   CHXClientThumbnailUnix.h (player\hxclientkit\src\platform\unix)
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)     -> dbus_server_with_video
> 
>   Set Profile       -> helix-client-all-defines
> 
>   System ID       -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   hxclient-thumbnail.diff
> 
>   dbus-server-thumbnail.diff
> 
>  
> 
> Weian
> 
>  
> 
>