[Player-dev] CR: Dynamically set MID player about dialog version
Rusty Lynch rusty.lynch at intel.comDescription
----------------------------------
Dynamically set the version string inside the about dialog.
This changeset will attempt to use a variable named "VERSION" in
version.py, where version.py is created at package creation time. If a
the version.py file does not exist, like in the case where a developer
is doing a manual source install, then the about version displayed in
the about box will be "UNRELEASED".
Files Modified
----------------------------------
player/mid/glade/dialogs.glade
player/mid/src/top_menu.py
Branches
---------------------------------
HEAD only (for now)
Index: glade/dialogs.glade
===================================================================
RCS file: /cvsroot/player/mid/glade/dialogs.glade,v
retrieving revision 1.2
diff -u -w -r1.2 dialogs.glade
--- glade/dialogs.glade 19 Mar 2008 19:46:26 -0000 1.2
+++ glade/dialogs.glade 25 Mar 2008 03:11:28 -0000
@@ -181,9 +181,9 @@
</child>
<child>
- <widget class="GtkLabel" id="label3">
+ <widget class="GtkLabel" id="version_label">
<property name="visible">True</property>
- <property name="label" translatable="yes"><span
size="14000">version 0.38</span></property>
+ <property name="label" translatable="yes"></property>
<property name="use_underline">False</property>
<property name="use_markup">True</property>
<property name="justify">GTK_JUSTIFY_CENTER</property>
Index: installer/make_tempdir
===================================================================
RCS file: /cvsroot/player/mid/installer/make_tempdir,v
retrieving revision 1.6
diff -u -w -r1.6 make_tempdir
--- installer/make_tempdir 24 Mar 2008 20:26:54 -0000 1.6
+++ installer/make_tempdir 25 Mar 2008 03:11:28 -0000
@@ -254,6 +254,12 @@
"realplayer.glade",
"settings_dialog.glade",
"dialogs.glade")
+# Create a special python file that contains the VERSION variable
+f = open("version.py", "w")
+f.write("VERSION='%s'\n" % (verstr))
+f.close()
+inst.CopyFile("./version.py",
+ "usr/share/realplayer/version.py")
# Copy realplayer executable script file
inst.CopyFile("../realplayer",
"usr/bin/realplayer")
@@ -263,6 +269,8 @@
"realplayer-video.desktop",
"realplayer-music.desktop",
"realplayer-photo.desktop")
+
+
# XXXMEH - TEMP
# Older versions of the moblin launcher looked
# in /usr/share/mobile-basic-flash/applications instead
Index: src/top_menu.py
===================================================================
RCS file: /cvsroot/player/mid/src/top_menu.py,v
retrieving revision 1.3
diff -u -w -r1.3 top_menu.py
--- src/top_menu.py 19 Mar 2008 19:46:28 -0000 1.3
+++ src/top_menu.py 25 Mar 2008 03:11:28 -0000
@@ -342,6 +342,17 @@
pb =
gtk.gdk.pixbuf_new_from_file(os.path.join(constant.MediaSpecImagePath,
'powered_by_helix.png'))
about_image.set_from_pixbuf(pb)
+ # set the version string
+ version_label = self.about_xml.get_widget('version_label')
+ try:
+ import version
+ version_string = version.VERSION
+ except:
+ # The version.py file is created at package creation time,
so
+ # source or manual installations by developers will get a
version
+ # string of "UNRELEASED"
+ version_string = "UNRELEASED"
+ version_label.set_markup("<span size='14000'>%s: %s</span>" %
(_("Version"), version_string))
self.about_dialog.set_modal(True)
self.about_dialog.run();
self.about_dialog.destroy()