[Player-dev] CR: player/app/gtk/Umakefil
Nicholas Hart nhart at real.comI wasn't planning on adding an "en" dir. I'd be fine with that, as long as the default (no locale set) can find it. On Wed, 2004-08-18 at 16:56, Enryo Hayashi wrote: > Would you be adding 'en' to the locale directory? and/or leave a default > English readme under the installed path? > In the gold branch, I wrote the code to fall back to the readme under the > installed path if a readme under locale directory was not found. > > > -----Original Message----- > > From: Nicholas Hart [mailto:nhart at real.com] > > Sent: Wednesday, August 18, 2004 4:36 PM > > To: ehayashi at real.com > > Cc: dev at player.helixcommunity.org > > Subject: RE: [Player-dev] CR: player/app/gtk/Umakefil > > > > I've fixed the naming of the readme template for helix, > > cleaned up the code a bit and checked this in to the head. > > Below is the new diff. > > Also, we might consider using some similar code where we need > > to deal with multiple locales in a Umakefil. Of course, if > > we want to restrict the locales used it would be better to > > use a pre-selected list... > > > > > > Index: Umakefil > > =================================================================== > > RCS file: /cvsroot/player/app/gtk/Umakefil,v > > retrieving revision 1.78 > > diff -u -w -r1.78 Umakefil > > --- Umakefil 17 Aug 2004 22:41:19 -0000 1.78 > > +++ Umakefil 18 Aug 2004 23:31:56 -0000 > > @@ -224,7 +224,8 @@ > > ProgramTarget("realplay.bin") > > project.AddCopyTargets("realplay") > > verfile = "realplayer.ver" > > - > > + readme_src = "README.realplay.in" > > + readme_dest = "README.realplay" > > else: > > project.AddDefines('APP_NAME_SHORT="hxplay"') > > project.AddDefines('APP_NAME_LONG="Helix Player"') @@ > > -236,10 +237,16 @@ > > ProgramTarget("hxplay.bin") > > project.AddCopyTargets("hxplay") > > verfile = "hxplayer.ver" > > + readme_src = "README.hxplay.in" > > + readme_dest = "README.hxplay" > > > > > > DependTarget() > > > > -UpdateReleaseNotes("README.hxplay.in", "README.hxplay", > > verfile) -UpdateReleaseNotes("README.realplay.in", > > "README.realplay", verfile) > > - > > +for entry in os.listdir("locale"): > > + path = os.path.join("locale", entry) > > + if os.path.isdir(path): > > + src_path = os.path.join(path, readme_src) > > + if os.path.isfile(src_path): > > + dest_path = os.path.join(path, readme_dest) > > + UpdateReleaseNotes(src_path, dest_path, verfile) > > > > > > On Wed, 2004-08-18 at 16:27, Nicholas Hart wrote: > > > oops, bad cut & paste error. > > > > > > I noticed you checked in something similar to this on the > > gold branch. > > > I only whipped this up because there didn't seem to be > > something like > > > it on the head. > > > > > > So maybe we should keep your solution on the gold branch > > and mine on > > > the head. The one nice thing about it is that it will > > automatically > > > pick up future locales. > > > > > > > > > On Wed, 2004-08-18 at 16:20, Enryo Hayashi wrote: > > > > hxplay instead of realplay? > > > > > > > > @@ -236,10 +237,14 @@ > > > > ProgramTarget("hxplay.bin") > > > > project.AddCopyTargets("hxplay") > > > > verfile = "hxplayer.ver" > > > > + readme_src = "README.realplay.in" > > > > + readme_dest = "README.realplay" > > > > > > > > > > > > > -----Original Message----- > > > > > From: player-dev-bounces at lists.helixcommunity.org > > > > > [mailto:player-dev-bounces at lists.helixcommunity.org] On > > Behalf Of > > > > > Nicholas Hart > > > > > Sent: Wednesday, August 18, 2004 3:48 PM > > > > > To: dev at player.helixcommunity.org > > > > > Subject: [Player-dev] CR: player/app/gtk/Umakefil > > > > > > > > > > This ensures that we generate the correct README file for all > > > > > locales. > > > > > For head and gold branch. > > > > > > > > > > Index: Umakefil > > > > > > > ================================================================== > > > > > = RCS file: /cvsroot/player/app/gtk/Umakefil,v > > > > > retrieving revision 1.78 > > > > > diff -u -w -r1.78 Umakefil > > > > > --- Umakefil 17 Aug 2004 22:41:19 -0000 1.78 > > > > > +++ Umakefil 18 Aug 2004 22:47:15 -0000 > > > > > @@ -224,7 +224,8 @@ > > > > > ProgramTarget("realplay.bin") > > > > > project.AddCopyTargets("realplay") > > > > > verfile = "realplayer.ver" > > > > > - > > > > > + readme_src = "README.realplay.in" > > > > > + readme_dest = "README.realplay" > > > > > else: > > > > > project.AddDefines('APP_NAME_SHORT="hxplay"') > > > > > project.AddDefines('APP_NAME_LONG="Helix Player"') > > @@ -236,10 > > > > > +237,14 @@ > > > > > ProgramTarget("hxplay.bin") > > > > > project.AddCopyTargets("hxplay") > > > > > verfile = "hxplayer.ver" > > > > > + readme_src = "README.realplay.in" > > > > > + readme_dest = "README.realplay" > > > > > > > > > > > > > > > DependTarget() > > > > > > > > > > -UpdateReleaseNotes("README.hxplay.in", "README.hxplay", > > > > > verfile) -UpdateReleaseNotes("README.realplay.in", > > > > > "README.realplay", verfile) > > > > > - > > > > > +for entry in os.listdir("locale"): > > > > > + path = os.path.join("locale", entry) > > > > > + src_path = os.path.join(path, readme_src) > > > > > + if os.path.isdir(path) and os.path.isfile(src_path): > > > > > + UpdateReleaseNotes(src_path, os.path.join(path, > > > > > +readme_dest), > > > > > verfile) > > > > > > > > > > > > > > > -- > > > > > Nicholas Hart > > > > > nhart at real.com > > > > > Technical Lead, Helix Player > > > > > https://player.helixcommunity.org > > > > > http://www.real.com > > > > > > > > > > > > > > > _______________________________________________ > > > > > Player-dev mailing list > > > > > Player-dev at lists.helixcommunity.org > > > > > http://lists.helixcommunity.org/mailman/listinfo/player-dev > > -- > > Nicholas Hart > > nhart at real.com > > Technical Lead, Helix Player > > https://player.helixcommunity.org > > http://www.real.com > > -- Nicholas Hart nhart at real.com Technical Lead, Helix Player https://player.helixcommunity.org http://www.real.com