We will submit a CR for these changes.

Darrin

>-----Original Message-----
>From: ext Milko Boic [mailto:milko at real.com] 
>Sent: Tuesday, May 09, 2006 6:37 PM
>To: Aaron Colwell; Mann Darrin (Nokia-TP-MSW/Dallas)
>Cc: Jamie Gordon; protocol-dev at helixcommunity.org; 
>helix-server-dev at helixcommunity.org; 
>helix-producer-dev at helixcommunity.org
>Subject: Re: [Protocol-dev] Question about SDP parsing
>
>
>Thanks for comments Aaron.
>
>We need to match a=<attribute_name>:string to trigger the "" 
>matching logic for cayenne and cayennes.
>
>The SDP generator version revision on updating the treatment 
>of string properties goes beyond required fix for 
>cayenne/cayennes branches.
>This will need to be addressed for Atlas and Server v12.
>
>Darrin, can you handle implementing fix for cayenne/cayennes branches?
>
>Thanks,
>Milko
>
>
>At 10:01 AM 5/9/2006, Aaron Colwell wrote:
>>I don't think tying this to only ASMRuleBook is a good idea. To my 
>>knowledge there hasn't been any code that prevents \n or \r 
>characters 
>>from being in IHXValues::CString values. I'm sure there is plenty of 
>>content out there with TAC that may have \r or \n in it. I 
>think tying 
>>the quote handling to the a=<attribute_name>:string form is a 
>best option for avoiding future breakages.
>>
>>Before making this change you should add this failure case to the 
>>extensive unit test for this code. You can then use the unit test to 
>>make sure that your changes don't break any other behavior.
>>
>>Code should also be added to the SDP generator to make sure 
>that \n and 
>>\r characters do not make their way from IHXValue string properties 
>>onto the SDP unescaped. Like Jamie said, letting \n or \r 
>characters in 
>>an SDP line is not valid SDP independent of whether it surrounded by 
>>quotes or not. Even if these are RN only parameters other SDP parsers 
>>won't likely be able to properly parse the SDP. You'll 
>probably need to 
>>increment the SDP generator version so that the parser will know to 
>>unescape the \r and \n characters.
>>
>>Aaron
>>
>>
>>On Tue, May 09, 2006 at 09:26:17AM -0700, Milko Boic wrote:
>> >
>> > Thanks Jamie.
>> >
>> > Thus, we should not remove this code.
>> > The options is to make it conditional to apply only in 
>case when SDP 
>> > line starts with a=<attribute_name>:string or more specialized 
>> > a=ASMRuleBook:string
>> >
>> > For simplicity, matching a fixed string "a=ASMRuleBook:string" 
>> > rather than a pattern should work.
>> >
>> > Comment should be put in place as to the reason for exception made 
>> > for a=ASMRuleBook:string lines.
>> >
>> > Thanks,
>> > Milko
>> >
>> >
>> > At 08:28 AM 5/9/2006, Jamie Gordon wrote:
>> > >From the unit test that went with this change
>> > 
>>http://lists.helixcommunity.org/pipermail/protocol-dev/2003-August/
>> > >0001
>> 44.html
>> > >it looks like it was trying to handle and ASMRuleBook 
>from pxgif ff 
>> > >plugin in RealServer 8, which contained new line characters. It's 
>> > >possible other plugins or encoders may have also used new 
>lines in 
>> > >the ASMRuleBook back then too, I'm not sure. It's certainly not 
>> > >valid SDP though.
>> > >
>> > >
>> > >Jamie
>> > >
>> > >Milko Boic wrote:
>> > >>Expanding distribution to server and producer lists for 
>review by 
>> > >>the respective teams.
>> > >>Thanks,
>> > >>Milko
>> > >>At 08:44 AM 5/5/2006, Milko Boic wrote:
>> > >>
>> > >>>I do not see a reason for the quote check.and thus no 
>reason for 
>> > >>>escape check either.
>> > >>>
>> > >>>I am guessing this code was created to cater to a practice used 
>> > >>>by some already released content creation tools.
>> > >>>Which tools and if they are still in use I do not know.
>> > >>>
>> > >>>Perhaps server or producer teams have an idea.
>> > >>>
>> > >>>Milko
>> > >>>
>> > >>>At 02:28 PM 5/4/2006, Darrin.Mann at nokia.com wrote:
>> > >>>
>> > >>>>We are seeing an error when streaming the attached clip.  The 
>> > >>>>engine is failing when parsing the SDP.  I have 
>attached the SDP 
>> > >>>>from the RTSP message.
>> > >>>>
>> > >>>>The following line is causing the error:
>> > >>>>
>> > >>>>i=" /e RVEncodeTerminationEvent944403578 <No copyright>
>> > >>>>
>> > >>>>Since the line does not have an matching ", the rest 
>of the SDP 
>> > >>>>is
>> being
>> > >>>>read into the
>> > >>>>i= string by SDPMediaDescParser::GetLine().  This is 
>causing us 
>> > >>>>to fail parsing in
>> > >>>>RTSPClientProtocol::ParseSDP() since no streams are found.
>> > >>>>
>> > >>>>Should there be a check for matching quotes?  According to the 
>> > >>>>spec, there
>> > >>>>is no requirement for matching quotes.   The CR/LF 
>combination should
>> > >>>>end
>> > >>>>the information line.
>> > >>>>
>> > >>>>Darrin
>> > >>>>
>> > >>>>
>> > >>>>
>> > >>>>_______________________________________________
>> > >>>>Protocol-dev mailing list
>> > >>>>Protocol-dev at helixcommunity.org
>> > >>>>http://lists.helixcommunity.org/mailman/listinfo/protocol-dev
>> > >>>
>> > >>>
>> > >>>
>> > >>>
>> > >>>_______________________________________________
>> > >>>Protocol-dev mailing list
>> > >>>Protocol-dev at helixcommunity.org
>> > >>>http://lists.helixcommunity.org/mailman/listinfo/protocol-dev
>> > >>
>> > >>
>> > >>_______________________________________________
>> > >>Protocol-dev mailing list
>> > >>Protocol-dev at helixcommunity.org
>> > >>http://lists.helixcommunity.org/mailman/listinfo/protocol-dev
>> >
>
>
>