[Helix-client-dev] CR-Client: fix for a build error on Linux AMD64 native platform
Massimo Perga massimo.perga at gmail.comModified by: massimo.perga at gmail.com.com <mailto:massimo.perga at gmail.com> Date: 9/30/2007 Project: Helix And RealPlayer Synopsis: This fix for a build error on Linux AMD64 native platform. Overview: This change request fixes a build error on Linux AMD64 native platform: the modified function prototypes change the 'long' type - which has a 64-bit length on Linux AMD64 native platform - to UINT32 type. Such those functions are called with UINT32 parameters while they've 'long' parameter types. Files Added: None Files Changed: player/hxclientkit/src/hxrecordengine/Attic/HXClientRecordHeaderProps.c player/hxclientkit/src/hxrecordengine/Attic/HXClientRecordHeaderProps.h Image Size and Heap Use impact (Client-Only): None Copyright assignment: In consideration for RealNetworks' hosting and maintenance of my modification, I agree to assign to RealNetworks full copyright ownership of the code included in the attached patch, and agree that RealNetworks has no duty of accounting to me for it. I warrant that this code is entirely original to and owned by me, that I can legally grant the copyright assignment, and that my contribution does not violate any other person's rights, and laws or breach any contract. I understand that RealNetworks may license this code under RPSL, RCSL, and/or any other license at RealNetworks' discretion, and use the code in any way. -------------- next part -------------- ? debug ? app/gtk/Makefile ? app/gtk/README.realplay ? app/gtk/Umakefil.upp ? app/gtk/dbg ? app/gtk/locale/de/README.realplay ? app/gtk/locale/es/README.realplay ? app/gtk/locale/fr/README.realplay ? app/gtk/locale/it/README.realplay ? app/gtk/locale/ja/README.realplay ? app/gtk/locale/ko/README.realplay ? app/gtk/locale/pt_BR/README.realplay ? app/gtk/locale/zh_CN/README.realplay ? app/gtk/locale/zh_TW/README.realplay ? app/plugin/Makefile ? app/plugin/Umakefil.upp ? app/plugin/dbg ? app/plugin/nphelix.exp ? common/gtk/Makefile ? common/gtk/Umakefil.upp ? common/gtk/dbg ? common/gtk/gtkhxdll.mak ? common/gtk/gtkhxdll.upp ? common/gtk/gtkhxlib.mak ? common/gtk/gtkhxlib.upp ? common/gtk/libgtkhxplay.exp ? hxclientkit/Makefile ? hxclientkit/Umakefil.upp ? hxclientkit/UmakefilKit.mak ? hxclientkit/UmakefilKit.upp ? hxclientkit/UmakefilKitDll.mak ? hxclientkit/UmakefilKitDll.upp ? hxclientkit/dbg ? hxclientkit/libhxclient.exp ? hxclientkit/src/hxrecordengine/.HXClientRecordHeaderProps.c.swp ? hxclientkit/src/hxrecordengine/Makefile ? hxclientkit/src/hxrecordengine/Umakefil.upp ? hxclientkit/src/hxrecordengine/dbg ? hxclientkit/src/hxrecordengine/hxrecordengine.exp ? installer/app/Makefile ? installer/app/Umakefil.upp ? installer/app/dbg ? installer/archive/Makefile ? installer/archive/Umakefil.upp ? installer/archive/archive_info.h ? installer/archive/dbg ? installer/archive/install.bz2 ? installer/archive/make_archive.mak ? installer/archive/make_archive.upp ? installer/archive/make_symbols.mak ? installer/archive/make_symbols.upp ? installer/archive/make_tempdir.mak ? installer/archive/make_tempdir.upp ? installer/archive/symbols ? installer/archive/temp ? installer/deb/Makefile ? installer/deb/Umakefil.upp ? installer/deb/dbg ? installer/postinst/Makefile ? installer/postinst/Umakefil.upp ? installer/postinst/dbg ? installer/rpm/Makefile ? installer/rpm/Umakefil.upp ? installer/rpm/dbg ? installer/rpm/redhat ? installer/stage1/Makefile ? installer/stage1/Umakefil.upp ? installer/stage1/dbg Index: hxclientkit/src/hxrecordengine/HXClientRecordHeaderProps.c =================================================================== RCS file: /cvsroot/player/hxclientkit/src/hxrecordengine/Attic/HXClientRecordHeaderProps.c,v retrieving revision 1.1.2.1 diff -u -w -r1.1.2.1 HXClientRecordHeaderProps.c --- hxclientkit/src/hxrecordengine/HXClientRecordHeaderProps.c 10 Mar 2007 02:28:30 -0000 1.1.2.1 +++ hxclientkit/src/hxrecordengine/HXClientRecordHeaderProps.c 30 Sep 2007 07:52:05 -0000 @@ -42,10 +42,12 @@ * http://www.helixcommunity.org/content/tck * * Contributor(s): + * Massimo Perga <massimo.perga at gmail.com> * * * ***** END LICENSE BLOCK ***** */ +#include "hxtypes.h" #include "HXClientRecordHeaderProps.h" #include "enter_hx_headers.h" @@ -57,7 +59,6 @@ #define MAX_PROP_SIZE 32 #define RANDOM_SEED 1984 - const char g_pHdrProperties[][MAX_PROP_SIZE] = { {'B','I','s','s','t','L','a','i','h','c','i','e','i','n','o','s','k','e','S','d','\0'}, @@ -106,7 +107,7 @@ } void -SetHdrValue( unsigned long* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber, unsigned long nValue ) +SetHdrValue( UINT32* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber, unsigned long nValue ) { unsigned short nPosition = 0; unsigned short nIndex = 0; @@ -166,8 +167,8 @@ pData[ pKeys[ nPosition ] - g_nRandomizer ] = nValue + g_nRandomizer; } -unsigned long -GetHdrValue( unsigned long* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber ) +UINT32 +GetHdrValue( UINT32* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber ) { unsigned short nPosition = 0; Index: hxclientkit/src/hxrecordengine/HXClientRecordHeaderProps.h =================================================================== RCS file: /cvsroot/player/hxclientkit/src/hxrecordengine/Attic/HXClientRecordHeaderProps.h,v retrieving revision 1.1.2.1 diff -u -w -r1.1.2.1 HXClientRecordHeaderProps.h --- hxclientkit/src/hxrecordengine/HXClientRecordHeaderProps.h 10 Mar 2007 02:28:30 -0000 1.1.2.1 +++ hxclientkit/src/hxrecordengine/HXClientRecordHeaderProps.h 30 Sep 2007 07:52:05 -0000 @@ -42,6 +42,7 @@ * http://www.helixcommunity.org/content/tck * * Contributor(s): + * Massimo Perga <massimo.perga at gmail.com> * * * ***** END LICENSE BLOCK ***** */ @@ -65,8 +66,8 @@ #define FILE_HDR_PROP_NUM 4 #define STREAM_HDR_PROP_NUM 3 -void SetHdrValue( unsigned long* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber, unsigned long nValue ); -unsigned long GetHdrValue( unsigned long* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber ); +void SetHdrValue( UINT32* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber, unsigned long nValue ); +UINT32 GetHdrValue( UINT32* pData, unsigned short* pKeys, unsigned short nType, unsigned short nStreamNumber ); int GetPropertyType( const char* szProperty ); #ifdef __cplusplus