[Helix-client-dev] CR: Add Video Support for helix dbus-serverGreg Wright gwright at real.com
Zhao, Halley wrote: > Another CR is, we'd like to separate this D-Bus server from helix-bansh= ee project, create a new folder under /cvsroot/player/kit/helix-dbus-serv= er. fork it from helix-banshee project and add new patches. I think this is a good idea overall since DBus is simply another adaptation layer over Helix that programs can use to get at the functionality of Helix without using the native C++/COM API. Before this is done, I think others should comment on it however. Some initial thoughts: What will happen with the old banshee code, will it be changed to use this new location? I think it should be because we do not want to maintain 2 code bases. I notice that the banshee DBus code does not conform to the Helix coding standards in places. Work would have to be done to bring it up to speed during initial import or soon after. We would want this on at least HEAD and 310Atlas. --greg. > > > > ________________________________ > > From: Zhao, Halley > Sent: 2007=C4=EA9=D4=C215=C8=D5 13:23 > To: Player-dev; 'helix-banshee-dev at helixcommunity.org' > Cc: 'helix-client-dev at helixcommunity.org'; Zhao, Halley; Shen, Cathy > Subject: CR: Add Video Support for helix dbus-server > > > > Bug Number: > > 7185 > > Bug URL: > > https://bugs.helixcommunity.org/show_bug.cgi?id=3D7185 > > > > Synopsis: > > add video support for helix-dbus-server > > Overview: > > add video support for helix-dbus-server > > 1. current helix-dbus-server provides audio service only. > > 2. add video service for this helix-dbus-server > > a) when the helix-dbus-server initialize, it hasn't any GDKWin= dow; so we don't create a player at that time. > > b) when media player try to playback media stream through heli= x-dbus-serve, it should transmit its GDKWinow's XID to helix-dbus-server,= then helix-dbus-server will create a player, whose drawing window attach= to media player's GDKWindow. it is done in hxplayer_init(). > > c) if media player doesn't give its GDKWindow's XID to helix-d= bus-erver, helix-dbus-server will create a player without video service. > > d) Add actions to deal with X message in hxplayer_pump() > > e) add API for resize drawing window. when media player change= s its layout, it can send message to helix-dbus-serve to adjust video out= put correspondingly. > > f) add Quit APP for helix-dbu-server. it will destroy the play= er of helix-dbus-server (not helix-dbus-server itself), which is needed w= hen you launch a media player for multi-times, and needed when media play= er switch among various media dbus services. > > Files Added: > > No file added > > Files Modified: > > helix-dbus-server-main.cpp: (helix-banshee/helix-dbus-server/src/he= lix-dbus-server-main.cpp) > > add some gtk initials > > helix-dbus-server.cpp: (helix-banshee/helix-dbus-server/src/helix-d= bus-server.cpp) > > dbus message handles > > hxplayer.cpp: (helix-banshee/helix-dbus-server/src/hxplayer.cpp) > > create player with media player's XID > > resize the player's output window > > Image Size and Heap Use impact (Client -Only): > > little > > Platforms and Profiles Affected: > > platform: linux-2.2-libc6-gcc32-i586 > > profile: helix-client-all-defines > > > > Distribution Libraries Affected: > > <helix-dbus-server.bin> > > Distribution library impact and planned action: > > <None> > > Platforms and Profiles Build Verified: > > Set BIF branch -> helix_banshee_current > > Set Target(s) -> helix_dbus_server > > Set Profile -> helix-client-all-defines > > System ID -> linux-2.2-libc6-gcc32-i586 > > Branch: > > HEAD, helix_banshee_current > > Copyright assignment: <MUST be one of the following statements > > > 2. I have signed and delivered a Joint Copyright Assignment > > to RealNetworks, and received acknowledgment that the > > agreement was received. > > Files Attached: > > helix-dbus-server.diff > > > > ZHAO, Halley (Aihua) > > Email: halley.zhao at intel.com <mailto:aihua.zhao at intel.com> > > Tel: +86(21)61166476 > > iNet: 8821-6476 > > SSG/OTC/UMD > > > > > > -----------------------------------------------------------------------= - > > This body part will be downloaded on demand.