=A1=A1=A1=A1Thanks, commit to hxclient_3_1_0_atlas.
=A1=A1=A1=A1
=A1=A1=A1=A1Another question, should I also commit to HEAD branch?
=A1=A1=A1=A1
=A1=A1=A1=A1
=A1=A1=A1=A1>-----Original Message-----
=A1=A1=A1=A1>From: Eric Hyche [mailto:ehyche at real.com]
=A1=A1=A1=A1>Sent: 2007=C4=EA9=D4=C213=C8=D5 21:31
=A1=A1=A1=A1>To: Zhao, Halley; 'datatype-dev'
=A1=A1=A1=A1>Cc: helix-client-dev at helixcommunity.org
=A1=A1=A1=A1>Subject: RE: [datatype-dev] [Helix-client-dev] CR: Fixed =
the build
=A1=A1=A1=A1>depedency(bif) and stream type mismatch for mjpeg plugin
=A1=A1=A1=A1>
=A1=A1=A1=A1>
=A1=A1=A1=A1>These changes look good.
=A1=A1=A1=A1>
=A1=A1=A1=A1>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

=A1=A1=A1=A1>Eric Hyche (ehyche at real.com)
=A1=A1=A1=A1>Technical Lead
=A1=A1=A1=A1>RealNetworks, Inc.
=A1=A1=A1=A1>
=A1=A1=A1=A1>> -----Original Message-----
=A1=A1=A1=A1>> From: datatype-dev-bounces at helixcommunity.org
=A1=A1=A1=A1>> [mailto:datatype-dev-bounces at helixcommunity.org] On =
Behalf Of
=A1=A1=A1=A1>> Zhao, Halley
=A1=A1=A1=A1>> Sent: Thursday, September 13, 2007 3:21 AM
=A1=A1=A1=A1>> To: datatype-dev
=A1=A1=A1=A1>> Cc: helix-client-dev at helixcommunity.org
=A1=A1=A1=A1>> Subject: [datatype-dev] [Helix-client-dev] CR: Fixed the
=A1=A1=A1=A1>> build depedency(bif) and stream type mismatch for mjpeg =
plugin
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Bug Number:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     7164
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Bug URL:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     =
https://bugs.helixcommunity.org/show_bug.cgi?id=3D7164
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Synopsis:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     fix a bug in mjpeg render on linux.
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Overview:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     Add Linux platform support and module dependlist in
=A1=A1=A1=A1>> hxclient_3_1_0_atlas.bif
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     On linux, the image top and bottom is upside-down; =
fix
=A1=A1=A1=A1>> the bug in mjpgdec.cpp for linux
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     by assign the correct buf address before calling jpeg =
lib
=A1=A1=A1=A1>> API on Linux.
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     +#ifdef _WINDOWS
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>      pRowBuf =3D pDecodedBuf + (m_cinfo.output_height -
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>                                    =
m_cinfo.output_scanline - 1) *
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>                                    row_stride;
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     +#else
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     +          pRowBuf =3D pDecodedBuf +
=A1=A1=A1=A1>> m_cinfo.output_scanline * row_stride;
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Files Added:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>        No file added
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Files Modified:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     mjpgdec.cpp: (datatype/mjpeg/renderer/mjpgdec.cpp)
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>         assign the correct buf address before calling =
jpeg
=A1=A1=A1=A1>> lib API on Linux
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Image Size and Heap Use impact (Client -Only):
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     little
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Platforms and Profiles Affected:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     platform:   linux-2.2-libc6-gcc32-i586
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     profile:    helix-client-all-defines
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Distribution Libraries Affected:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     mjpgrender.so
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Distribution library impact and planned action:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     None
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Platforms and Profiles Build Verified:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     Set BIF branch  -> hxclient_3_1_0_atlas_restricted
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     Set Target(s)   -> datatype_mjpeg_renderer
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     Set Profile     -> helix-client-all-defines
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     System ID       -> linux-2.2-libc6-gcc32-i586
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Branch:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     HEAD, hxclient_3_1_0_atlas
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Copyright assignment: <MUST be one of the following =
statements >
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>    3.      My company (company name here) submits this =
code
=A1=A1=A1=A1>> under the terms
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>            of a commercial contribution agreement with =
RealNetworks,
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>            and I am authorized to contribute this code =
under
=A1=A1=A1=A1>> said agreement.
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>   Files Attached:
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>     datatype-mjpeg.diff
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> ZHAO, Halley (Aihua)
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Email: halley.zhao at intel.com =
<mailto:aihua.zhao at intel.com>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> Tel: +86(21)61166476
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> iNet: 8821-6476
=A1=A1=A1=A1>>
=A1=A1=A1=A1>> SSG/OTC/UMD
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>
=A1=A1=A1=A1>>