These changes look good.

=============================================
Eric Hyche (ehyche at real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounces at helixcommunity.org 
> [mailto:datatype-dev-bounces at helixcommunity.org] On Behalf Of 
> Zhao, Halley
> Sent: Thursday, September 13, 2007 3:21 AM
> To: datatype-dev
> Cc: helix-client-dev at helixcommunity.org
> Subject: [datatype-dev] [Helix-client-dev] CR: Fixed the 
> build depedency(bif) and stream type mismatch for mjpeg plugin
> 
> Bug Number:
> 
>     7164
> 
> Bug URL: 
> 
>     https://bugs.helixcommunity.org/show_bug.cgi?id=7164
> 
> Synopsis: 
> 
>     fix a bug in mjpeg render on linux.
> 
> Overview: 
> 
>     Add Linux platform support and module dependlist in 
> hxclient_3_1_0_atlas.bif
> 
>     On linux, the image top and bottom is upside-down; fix 
> the bug in mjpgdec.cpp for linux 
> 
>     by assign the correct buf address before calling jpeg lib 
> API on Linux.
> 
>     +#ifdef _WINDOWS
> 
>      pRowBuf = pDecodedBuf + (m_cinfo.output_height -
> 
>                                    m_cinfo.output_scanline - 1) *
> 
>                                    row_stride;
> 
>     +#else
> 
>     +          pRowBuf = pDecodedBuf + 
> m_cinfo.output_scanline * row_stride;
> 
>         
> 
> Files Added:
> 
>        No file added
> 
> Files Modified:
> 
>     mjpgdec.cpp: (datatype/mjpeg/renderer/mjpgdec.cpp)
> 
>         assign the correct buf address before calling jpeg 
> lib API on Linux
> 
> Image Size and Heap Use impact (Client -Only):
> 
>     little
> 
> Platforms and Profiles Affected:
> 
>     platform:   linux-2.2-libc6-gcc32-i586
> 
>     profile:    helix-client-all-defines
> 
> Distribution Libraries Affected:
> 
>     mjpgrender.so
> 
> Distribution library impact and planned action:
> 
>     None
> 
> Platforms and Profiles Build Verified:
> 
>     Set BIF branch  -> hxclient_3_1_0_atlas_restricted
> 
>     Set Target(s)   -> datatype_mjpeg_renderer
> 
>     Set Profile     -> helix-client-all-defines
> 
>     System ID       -> linux-2.2-libc6-gcc32-i586
> 
> Branch: 
> 
>     HEAD, hxclient_3_1_0_atlas
> 
> Copyright assignment: <MUST be one of the following statements >
> 
>   
> 
>    3.      My company (company name here) submits this code 
> under the terms
> 
>            of a commercial contribution agreement with RealNetworks,
> 
>            and I am authorized to contribute this code under 
> said agreement. 
> 
>   Files Attached:
> 
>     datatype-mjpeg.diff
> 
>  
> 
> ZHAO, Halley (Aihua)
> 
> Email: halley.zhao at intel.com <mailto:aihua.zhao at intel.com> 
> 
> Tel: +86(21)61166476
> 
> iNet: 8821-6476
> 
> SSG/OTC/UMD
> 
>  
> 
>