Jinu Thomas wrote:
> Modifications has been made as per the review comments and the updated diff file is attached.

Looks good.
--greg.

> 
> 
> 
> Greg Wright <gwright at real.com> 
> 03/27/2007 10:18 PM
>  
> 
> 
> Jinu Thomas wrote:
>> As you have mentioned I have copied that particular target from the realformat-sdk.bif and copied it into hxclient_2_1_0_cayennes.bif. But I was unable to check -out that particular target. It is giving some error .]
>> The target is:
>>    <!-- INCLUDE -->
>>       <module id="include" name="include" group="core">
>>          <cvs path="realformat-sdk/include"/>
>>           <attribute id="no_build"/>
>>       </module>
>>
>> The error I'm getting while checking-out: 
>>
>> Moving .\datatype-restricted/rm/video/codec/rv89combo/platform\cvstmpdir_2148\tmp to datatype-restricted/rm/video/codec/rv89combo/platform/emuzed
>> checking out [helix]include tag="hxclient_2_1_0_cayennes" from path="realformat-sdk/include"
>> running 'cvs -d :ext:jinuthomas at cvs.helixcommunity.org:/cvsroot/realformat-sdk checkout -r "hxclient_2_1_0_cayennes" -d tmp include' in 'c:\\source\\helix' + '.\\cvstmpdir_1304' (as = '.\\cvstmpdir_1304\\tmp')
>> cvs [checkout aborted]: no such tag hxclient_2_1_0_cayennes
>> [#-00000421][2007-03-27 14:27:06][1304][INFO ] : CVS command failed with error code 1, trying again in a few seconds.
>> cvs [checkout aborted]: no such tag hxclient_2_1_0_cayennes
>> [#-00000424][2007-03-27 14:27:13][1304][INFO ] : CVS command failed with error code 1, trying again in a few seconds.
>> cvs [checkout aborted]: no such tag hxclient_2_1_0_cayennes
>> [#-00000427][2007-03-27 14:27:26][1304][INFO ] : CVS command failed with error code 1, trying again in a few seconds.
>> cvs [checkout aborted]: no such tag hxclient_2_1_0_cayennes
>> [#-00000430][2007-03-27 14:27:44][1304][INFO ] : CVS command failed with error code 1, trying again in a few seconds.
>> cvs [checkout aborted]: no such tag hxclient_2_1_0_cayennes
>> [#-00000433][2007-03-27 14:28:06][1304][INFO ] : CVS command failed with error code 1, trying again in a few seconds.
>> cvs [checkout aborted]: no such tag hxclient_2_1_0_cayennes
>>
>>
>> I feel the only possible way to do the same is to inherit the target from the realfromat-sdk. With this modification code check-out and building works fine. Actually whoever wants to build the target datatype-restricted_rm_video_codec_rv89combo_emuzed  should have the realformat-sdk code since it is using some files from realformat-sdk code . The bif file hxclient_2_1_0_cayennes.bif from which it is inherited also belongs to some other code space( Client). So how shall I proceed? Please Advise.
> 
> 
> I think the problem is that the RealFormat SDK has not been branched to
> 210CayS. So, you need to add a branch tag for that one target. Here is
> one example of how:
> 
>      <module id="producersdk_common_container" name="producersdk/common/container" group="tools">
>        <cvs root="helix"/>
>        <cvs branch="producer_10"/>
> 
>        <includeplatforms>
>          unix mac win32
>        </includeplatforms>
> 
>        ...
>        ...
> 
> 
> You could just change the branch to 150Cay, HEAD or whatever. We could also branch
> the RealFormat SDK to 210CayS. It just depends on what you are after. Any fixes
> to the RF SDK will probably be made on HEAD and 150Cay, with 150Cay being much
> more stable. So, you would not have to worry about merging fixes to 210CayS if
> you picked up the SDK from 150Cay.
> 
> --greg.
> 
> 
>>  
>>
>> --Jinu
>>
>>
>>
>>
>>
>>
>>
>> Greg Wright <gwright at real.com> 
>> 03/27/2007 05:56 AM
>>  
>> To
>> Jinu Thomas <jinu at emuzed.com>
>> cc
>> datatype-dev at helixcommunity.org, helix-client-dev at helixcommunity.org
>> Subject
>> Re: [datatype-dev] CR-RESEND: MDF Wrapper for the RV89 Combo  Decoder
>>  
>>
>>  
>>
>>
>> +<inherit id="[realformat-sdk]realformat-sdk"/>
>>   <inherit id="[client]hxclient_2_1_0_cayennes"/>
>>
>>
>> This seems a bit strange, we normally only inherit from one
>> BIF file, I am not sure if this might cause problems for
>> you (it may not). If you only need 1 target from that, it
>> could just be cut-n-pasted in to the 210CayS. I am not sure
>> if including the realformat-sdk would also cause anything
>> strange to happen with code getting checked out on multiple
>> branches or something similar. What about folks that don't
>> have access to the realformat-sdk code, any problems there?
>>
>>
>> @@ -1824,7 +1826,7 @@
>>             common_runtime
>>             common_system <!-- only for multi-threading -->
>>             common_container <!-- only for multi-threading on unix -->
>> -          datatype_dist_rm_video_codec_common
>> +          <!-- datatype_dist_rm_video_codec_common -->
>>         </dependlist>
>>
>> any reason to not just delete that commented line?
>>
>> rest looks good.
>>
>> --greg.
>>
>>
>>
>>
>> Jinu Thomas wrote:
>>>    
>>> "In consideration for RealNetworks' hosting and maintenance 
>>>
>>> of my modification, I agree to assign to RealNetworks full
>>>
>>> copyright ownership of the code included in the attached
>>>
>>> patch, and agree that RealNetworks has no duty of accounting
>>>
>>> to me for it. I warrant that this code is entirely original
>>>
>>> to and owned by me, that I can legally grant the copyright
>>>
>>> assignment, and that my contribution does not violate any other
>>>
>>> person's rights, and laws or breach any contract. I understand
>>>
>>> that RealNetworks may license this code under RPSL, RCSL, 
>>>
>>> and/or any other license at RealNetworks' discretion, and use
>>>
>>> the code in any way."
>>>
>>>
>>> Modified by: 
>>>
>>> jinu at emuzed.com
>>>
>>>
>>>
>>> Date: 
>>>
>>> March-26-2007 
>>>
>>>
>>> Project: 
>>>
>>> RV89 MDF Wrapper for Symbian 
>>>
>>>
>>>
>>> Synopsis: 
>>>
>>> This is to build the modules independently for ARMV5, ARMV5E and ARMV6 and to fix the multiple definition compilation error. 
>>>
>>> Overview: 
>>>
>>> The cdecarm file modification is to define macros for building optimized  real video code independently for different platforms(ARMV5, ARMV5E and ARMV6). Both the BIF files(hxclient_2_1_0_cayennes_restricted.bif  and realformat-sdk.bif ) modifications are to build the Targets src/common as well as datatype-restricted_rm_video_codec_rv89combo_emuzed  independently. Sysinfo.py file modification and .cf files additions are for the buid support on ARMV5E and ARMV6 platforms.
>>>
>>>
>>> Files Modified: 
>>>
>>> build\bif-cvs\helix\client-restricted\build\BIF\hxclient_2_1_0_cayennes_restricted.bif 
>>>
>>> build\bif-cvs\helix\realformat-sdk\build\BIF\realformat-sdk.bif 
>>>
>>> helix\datatype-restricted\rm\video\codec\rv89combo\platform\emuzed\cdecarm 
>>>
>>> build\lib\sysinfo.py
>>>
>>>
>>> Files Added: 
>>>
>>> \build\umakecf\symbian-91-armv5e.cf
>>>
>>> \build\umakecf\symbian-armv5e.cf
>>>
>>> \build\umakecf\symbian-91-armv6.cf
>>>
>>> \build\umakecf\symbian-armv6.cf 
>>>
>>>
>>>
>>>
>>> Image Size and Heap Use impact: 
>>>
>>> Minimal 
>>>
>>>
>>> Platforms and Profiles Build Verified: 
>>>
>>> BIF branch -> realformat-sdk as well as hxclient_2_1_0_cayennes_restricted 
>>>
>>> Target(s) ->src/common as well as datatype-restricted_rm_video_codec_rv89combo_emuzed 
>>>
>>> Profile -> helix-client-s60-32-mmf-mdf-arm 
>>>
>>> SYSTEM_ID= symbian-91-armv5 
>>>
>>> SYSTEM_ID= symbian-91-armv5e 
>>>
>>> SYSTEM_ID= symbian-91-armv6 
>>>
>>>
>>> Platforms and Profiles Functionality verified: 
>>>
>>> armv5,armv5e,armv6 
>>>
>>>
>>> Branch: HEAD 
>>>
>>> Files Attached: 
>>>
>>>  Diffs.zip( Diffs of modified files)
>>>
>>> Adds.zip( Added files)
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
> 
> 
>