Daniel Yek wrote:
> 
> At 02:12 PM 1/4/2007, Massimo Perga wrote:
>> Hello All,
>>   I'm trying to look for a solution to the issue which is causing the 
>> failure of nightly builds for AMD64. In some previous thread on this 
>> ML I mentioned the patch (realplayer-va_abuse.patch) I've attached.
> 
> Hi Greg,
> 
> I think this David Woodhouse's patch is good, unless there are relevant 
> platforms that didn't implement <stdarg.h>. In that case, we can #ifdef 
> to use <varargs.h>. Do we want to require a #ifdef section for backward 
> compatibility for <varargs.h>? I don't know how relevant is <varargs.h> 
> nowaday. I think either way, the patch is desirable for most, if not 
> all, platforms.
> 
> https://bugs.helixcommunity.org/show_bug.cgi?id=5641

Do you have a windows box to try it on. All I need is for someone to
make sure it doesn't break the build (or crash right off the bat) and
I am fine with it. I just seem to remember that that patch had
problems.

If it compiles fine on windows please check it in.

Or, come by and remind me later this after noon and I can try it. I
have just been really busy and traveling.

--greg.


> 
> That is just my 2 cents.
> 
>