I apologize, it refers to bug number 5695.

2007/1/2, Massimo Perga <massimo.perga at gmail.com>:
>
> Modified by: massimo.perga at gmail.com
> Date: 01/02/07
> Project: Helix Client
> Bug Number: 5696
>
> Bug URL: N/A
>
> Synopsis: fix to allow MP3 file format playback
>
>
> Overview: the patch proposed fixes an issue due to the assumption that "unsigned long" data type is mapped to 32-bit.
> On AMD-64 it's 64-bit long.
>
>
>
> Files Added:
> None
>
> Files Modified:
> datatype/mp3/payload/pktparse.cpp
>
>
> Image Size and Heap Use impact (Client -Only):
>
> None
>
> Platforms and Profiles Affected:
> Linux for AMD64
>
>
> Distribution Libraries Affected:
> None
>
> Distribution library impact and planned action:
> None
>
> Platforms and Profiles Build Verified:
>
> platform: linux-2.6-glibc23-amd64 (Debian 4.1.1-20)
> profile:  helix-client-all-defines-nodist
>
>
> Platforms and Profiles Functionality verified:
> platform: linux-2.6-glibc23-amd64 (Debian 4.1.1-20)
> profile:  helix-client-all-defines-nodist
>
>
> Branch: hxclient_1_5_0_cayenne
>
> Copyright assignment:
>
>
>            In consideration for RealNetworks' hosting and maintenance
>            of my modification, I agree to assign to RealNetworks full
>            copyright ownership of the code included in the attached
>
>
>            patch, and agree that RealNetworks has no duty of accounting
>            to me for it. I warrant that this code is entirely original
>            to and owned by me, that I can legally grant the copyright
>
>
>            assignment, and that my contribution does not violate any other
>            person's rights, and laws or breach any contract. I understand
>            that RealNetworks may license this code under RPSL, RCSL,
>
>
>            and/or any other license at RealNetworks' discretion, and use
>            the code in any way.
>
> QA Instructions:
> It fixes the playback of a MP3 file/HTTP/RTSP on Linux/AMD64-native platform.
>
>
>
> Index: datatype/mp3/payload/pktparse.cpp
> ===================================================================
> RCS file: /cvsroot/datatype/mp3/payload/pktparse.cpp,v
> retrieving revision 1.11.2.1
> diff -u -w -r1.11.2.1 pktparse.cpp
> --- datatype/mp3/payload/pktparse.cpp    27 Apr 2005 14:35:51 -0000
> 1.11.2.1
> +++ datatype/mp3/payload/pktparse.cpp    2 Jan 2007 21:57:59 -0000
> @@ -30,6 +30,7 @@
>   *    http://www.helixcommunity.org/content/tck
>   *
>   * Contributor(s):
> + *    Massimo Perga ( massimo.perga at gmail.com)
>   *
>   * ***** END LICENSE BLOCK ***** */
>
> @@ -149,17 +150,17 @@
>          return 0;
>      }
>
> -    UINT32 dwPCM = pPCMBuffer->GetSize();
> +    unsigned long dwPCM = pPCMBuffer->GetSize();
>
>      // Decode the frame
> -    UINT32 ulDec = bPacketLoss ? (UINT32)-1 : ulSize;
> -    m_pDecoder->DecodeFrame_v(pDec,(unsigned long*)&ulDec,
> +    unsigned long ulDec = bPacketLoss ? -1 : (unsigned long)ulSize;
> +    m_pDecoder->DecodeFrame_v(pDec,&ulDec,
>                                 pPCMBuffer->GetBuffer(),
> -                               (unsigned long*)&dwPCM);
> +                               &dwPCM);
>
>      if(bPacketLoss)
>      {
> -        ulDec = ulSize;
> +        ulDec = (unsigned long)ulSize;
>      }
>
>      if(ulDec)
>
>
>
>
>


-- 
Massimo Perga
______________________________________
Computer Engineer

Via Valentino Carrera 61
10146 Torino
Italy

Tel: +393479806753
______________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/helix-client-dev/attachments/20070102/1767aeaa/attachment.html