From Ashish.As.Gupta at nokia.com Thu Apr 3 07:32:28 2008
From: Ashish.As.Gupta at nokia.com (Ashish.As.Gupta@nokia.com)
Date: Thu Apr 3 06:33:31 2008
Subject: [Filesystem-dev] CR: Can't play RA clip due to missing
initialization for m_pPendingReadBufAsyn
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B366E90097@daebe103.NOE.Nokia.com>
Message-ID: <60A427E0B02CC34B98D22BDCAA2536120564D001@daebe101.NOE.Nokia.com>
Can't play RA clip due to missing initialization for
m_pPendingReadBufAsync
Nokia submits this code under the terms of a commercial contribution
agreement with RealNetworks, and I am authorized to contribute this code
under said agreement."
Modified by: ashish.as.gupta@nokia.com
Reviewed by:
Date: 02-Apr-2008
Project: SymbianMmf_wm
TSW-Id: SXUU-7D5NGH
Synopsis:
m_pPendingReadBufAsync was not initialized with NULL.
CHXMiniFileObject::Seek checked for m_pPendingReadBufAsync not being
NULL and called ReadDone(HXR_CANCELLED, NULL). This resulted in error.
Fix is to initialize the variable in the constructor.
Files Modified:
filesystem/local/mini/minifileobj.cpp
Image Size and Heap Use impact: none
Module Release testing (STIF): Yes.
Test case(s) Added: none
Memory leak check performed: Yes, no new leaks introduced.
Platforms and Profiles Build Verified:
armv5 / helix-client-s60-50-mmf-mdf-arm
winscw / helix-client-s60-50-mmf-mdf-arm
Platforms and Profiles Functionality verified:
armv5 / helix-client-s60-50-mmf-mdf-arm
winscw / helix-client-s60-50-mmf-mdf-arm
Branch:
HEAD, hxclient_2_1_0_cayennes
Index: minifileobj.cpp
===================================================================
RCS file: /cvsroot/filesystem/local/mini/minifileobj.cpp,v
retrieving revision 1.23.2.9
diff -u -w -r1.23.2.9 minifileobj.cpp
--- minifileobj.cpp 14 Mar 2008 18:25:12 -0000 1.23.2.9
+++ minifileobj.cpp 2 Apr 2008 21:32:55 -0000
@@ -112,6 +112,7 @@
#if defined(HELIX_FEATURE_MMF_DATASOURCE)
,m_pDataSource (NULL)
,m_bAsyncReadSupported (FALSE)
+ ,m_pPendingReadBufAsync (NULL)
#endif
{
DPRINTF(D_MINI_FO, ("CHXMiniFO::CHXMiniFileObject()\n"));
From ehyche at real.com Fri Apr 4 05:50:05 2008
From: ehyche at real.com (Eric Hyche)
Date: Fri Apr 4 04:49:01 2008
Subject: [Filesystem-dev] CR: Can't play RA clip due to
missinginitialization for m_pPendingReadBufAsyn
In-Reply-To: <60A427E0B02CC34B98D22BDCAA2536120564D001@daebe101.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B366E90097@daebe103.NOE.Nokia.com>
<60A427E0B02CC34B98D22BDCAA2536120564D001@daebe101.NOE.Nokia.com>
Message-ID: <009701c89652$68c191a0$db68a8c0@EHYCHED620>
Looks good.
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf
> Of Ashish.As.Gupta@nokia.com
> Sent: Thursday, April 03, 2008 10:32 AM
> To: filesystem-dev@helixcommunity.org
> Subject: [Filesystem-dev] CR: Can't play RA clip due to
> missinginitialization for m_pPendingReadBufAsyn
>
> Can't play RA clip due to missing initialization for
> m_pPendingReadBufAsync
>
> Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to
> contribute this code
> under said agreement."
>
> Modified by: ashish.as.gupta@nokia.com
>
> Reviewed by:
>
> Date: 02-Apr-2008
>
> Project: SymbianMmf_wm
>
> TSW-Id: SXUU-7D5NGH
>
> Synopsis:
>
> m_pPendingReadBufAsync was not initialized with NULL.
> CHXMiniFileObject::Seek checked for m_pPendingReadBufAsync not being
> NULL and called ReadDone(HXR_CANCELLED, NULL). This resulted in error.
> Fix is to initialize the variable in the constructor.
>
> Files Modified:
>
> filesystem/local/mini/minifileobj.cpp
>
> Image Size and Heap Use impact: none
>
> Module Release testing (STIF): Yes.
>
> Test case(s) Added: none
>
> Memory leak check performed: Yes, no new leaks introduced.
>
> Platforms and Profiles Build Verified:
> armv5 / helix-client-s60-50-mmf-mdf-arm
> winscw / helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified:
> armv5 / helix-client-s60-50-mmf-mdf-arm
> winscw / helix-client-s60-50-mmf-mdf-arm
>
> Branch:
> HEAD, hxclient_2_1_0_cayennes
>
>
>
> Index: minifileobj.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/local/mini/minifileobj.cpp,v
> retrieving revision 1.23.2.9
> diff -u -w -r1.23.2.9 minifileobj.cpp
> --- minifileobj.cpp 14 Mar 2008 18:25:12 -0000 1.23.2.9
> +++ minifileobj.cpp 2 Apr 2008 21:32:55 -0000
> @@ -112,6 +112,7 @@
> #if defined(HELIX_FEATURE_MMF_DATASOURCE)
> ,m_pDataSource (NULL)
> ,m_bAsyncReadSupported (FALSE)
> + ,m_pPendingReadBufAsync (NULL)
> #endif
> {
> DPRINTF(D_MINI_FO, ("CHXMiniFO::CHXMiniFileObject()\n"));
>
> _______________________________________________
> Filesystem-dev mailing list
> Filesystem-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
>
From Ashish.As.Gupta at nokia.com Fri Apr 4 06:58:06 2008
From: Ashish.As.Gupta at nokia.com (Ashish.As.Gupta@nokia.com)
Date: Fri Apr 4 05:58:00 2008
Subject: [Filesystem-dev] CN: Can't play RA clip due to
missinginitialization for m_pPendingReadBufAsyn
In-Reply-To: <009701c89652$68c191a0$db68a8c0@EHYCHED620>
Message-ID: <60A427E0B02CC34B98D22BDCAA2536120567EB98@daebe101.NOE.Nokia.com>
Checked in to 210Cays and HEAD.
Thanks
Ashish
-----Original Message-----
From: ext Eric Hyche [mailto:ehyche@real.com]
Sent: Friday, April 04, 2008 7:50 AM
To: Gupta Ashish.As (Nokia-D-MSW/Dallas);
filesystem-dev@helixcommunity.org
Subject: RE: [Filesystem-dev] CR: Can't play RA clip due to
missinginitialization for m_pPendingReadBufAsyn
Looks good.
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> Ashish.As.Gupta@nokia.com
> Sent: Thursday, April 03, 2008 10:32 AM
> To: filesystem-dev@helixcommunity.org
> Subject: [Filesystem-dev] CR: Can't play RA clip due to
> missinginitialization for m_pPendingReadBufAsyn
>
> Can't play RA clip due to missing initialization for
> m_pPendingReadBufAsync
>
> Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to contribute this
> code under said agreement."
>
> Modified by: ashish.as.gupta@nokia.com
>
> Reviewed by:
>
> Date: 02-Apr-2008
>
> Project: SymbianMmf_wm
>
> TSW-Id: SXUU-7D5NGH
>
> Synopsis:
>
> m_pPendingReadBufAsync was not initialized with NULL.
> CHXMiniFileObject::Seek checked for m_pPendingReadBufAsync not being
> NULL and called ReadDone(HXR_CANCELLED, NULL). This resulted in error.
> Fix is to initialize the variable in the constructor.
>
> Files Modified:
>
> filesystem/local/mini/minifileobj.cpp
>
> Image Size and Heap Use impact: none
>
> Module Release testing (STIF): Yes.
>
> Test case(s) Added: none
>
> Memory leak check performed: Yes, no new leaks introduced.
>
> Platforms and Profiles Build Verified:
> armv5 / helix-client-s60-50-mmf-mdf-arm
> winscw / helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified:
> armv5 / helix-client-s60-50-mmf-mdf-arm
> winscw / helix-client-s60-50-mmf-mdf-arm
>
> Branch:
> HEAD, hxclient_2_1_0_cayennes
>
>
>
> Index: minifileobj.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/local/mini/minifileobj.cpp,v
> retrieving revision 1.23.2.9
> diff -u -w -r1.23.2.9 minifileobj.cpp
> --- minifileobj.cpp 14 Mar 2008 18:25:12 -0000 1.23.2.9
> +++ minifileobj.cpp 2 Apr 2008 21:32:55 -0000
> @@ -112,6 +112,7 @@
> #if defined(HELIX_FEATURE_MMF_DATASOURCE)
> ,m_pDataSource (NULL)
> ,m_bAsyncReadSupported (FALSE)
> + ,m_pPendingReadBufAsync (NULL)
> #endif
> {
> DPRINTF(D_MINI_FO, ("CHXMiniFO::CHXMiniFileObject()\n"));
>
> _______________________________________________
> Filesystem-dev mailing list
> Filesystem-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
>
From Praveen.Thimmashetty at nokia.com Mon Apr 14 16:25:37 2008
From: Praveen.Thimmashetty at nokia.com (Praveen.Thimmashetty@nokia.com)
Date: Mon Apr 14 15:22:24 2008
Subject: [Filesystem-dev] CR: Helix crashes when attempting to stream a ram
file with http protocol
Message-ID: <2A15C07EF7DF6243A092FB438FD4B366FCE852@daebe103.NOE.Nokia.com>
> "Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to contribute this
> code under said agreement."
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/14/2008
>
> Project: SymbianMmf
>
> ErrorId: OVIL-7DPQXK
>
> Synopsis: Helix crashes when attempting to stream a ram file with http
> protocol
>
> HTTP File system will support only shoutcast streams. There is no seek
> support. Changes are made to return proper error code.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> filesystem/http/httpfsys.cpp
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.7
> diff -w -u -b -r1.88.2.7 httpfsys.cpp
> @@ -8226,6 +8226,12 @@
> m_bShoutcast = TRUE;
> m_ulMinStartupLengthNeeded =
> HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> }
> + else
> + {
> +#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + m_LastError = HXR_NOT_SUPPORTED;
> +#endif
> + }
> }
>
> if ((ulLength > 4) && (ulLength >=
> m_ulMinStartupLengthNeeded))
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/filesystem-dev/attachments/20080414/1bfdd6dd/attachment-0001.html
From ehyche at real.com Tue Apr 15 05:38:20 2008
From: ehyche at real.com (Eric Hyche)
Date: Tue Apr 15 04:34:31 2008
Subject: [Filesystem-dev] CR: Helix crashes when attempting to stream a
ramfile with http protocol
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B366FCE852@daebe103.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B366FCE852@daebe103.NOE.Nokia.com>
Message-ID: <002801c89ef5$974d2290$db68a8c0@EHYCHED620>
Looks good.
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf
> Of Praveen.Thimmashetty@nokia.com
> Sent: Monday, April 14, 2008 7:26 PM
> To: filesystem-dev@helixcommunity.org
> Subject: [Filesystem-dev] CR: Helix crashes when attempting
> to stream a ramfile with http protocol
>
>
> "Nokia submits this code under the terms of a commercial
> contribution agreement with RealNetworks, and I am authorized
> to contribute this code under said agreement."
>
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/14/2008
>
> Project: SymbianMmf
>
> ErrorId: OVIL-7DPQXK
>
> Synopsis: Helix crashes when attempting to stream a ram file
> with http protocol
>
> HTTP File system will support only shoutcast streams. There
> is no seek support. Changes are made to return proper error code.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> filesystem/http/httpfsys.cpp
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.7
> diff -w -u -b -r1.88.2.7 httpfsys.cpp
> @@ -8226,6 +8226,12 @@
> m_bShoutcast = TRUE;
> m_ulMinStartupLengthNeeded =
> HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> }
> + else
> + {
> +#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + m_LastError = HXR_NOT_SUPPORTED;
> +#endif
> + }
> }
>
> if ((ulLength > 4) && (ulLength >=
> m_ulMinStartupLengthNeeded))
>
>
From Praveen.Thimmashetty at nokia.com Tue Apr 15 08:39:49 2008
From: Praveen.Thimmashetty at nokia.com (Praveen.Thimmashetty@nokia.com)
Date: Tue Apr 15 07:37:00 2008
Subject: CN: [Filesystem-dev] CR: Helix crashes when attempting to stream
aramfile with http protocol
In-Reply-To: <002801c89ef5$974d2290$db68a8c0@EHYCHED620>
References: <2A15C07EF7DF6243A092FB438FD4B366FCE852@daebe103.NOE.Nokia.com>
<002801c89ef5$974d2290$db68a8c0@EHYCHED620>
Message-ID: <2A15C07EF7DF6243A092FB438FD4B366FCE993@daebe103.NOE.Nokia.com>
Committed to head and 210CayS
Thanks
Praveen
-----Original Message-----
From: filesystem-dev-bounces@helixcommunity.org
[mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of ext Eric
Hyche
Sent: Tuesday, April 15, 2008 7:38 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-dev@helixcommunity.org
Subject: RE: [Filesystem-dev] CR: Helix crashes when attempting to
stream aramfile with http protocol
Looks good.
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> Praveen.Thimmashetty@nokia.com
> Sent: Monday, April 14, 2008 7:26 PM
> To: filesystem-dev@helixcommunity.org
> Subject: [Filesystem-dev] CR: Helix crashes when attempting to stream
> a ramfile with http protocol
>
>
> "Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to contribute this
> code under said agreement."
>
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/14/2008
>
> Project: SymbianMmf
>
> ErrorId: OVIL-7DPQXK
>
> Synopsis: Helix crashes when attempting to stream a ram file with http
> protocol
>
> HTTP File system will support only shoutcast streams. There is no seek
> support. Changes are made to return proper error code.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> filesystem/http/httpfsys.cpp
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.7
> diff -w -u -b -r1.88.2.7 httpfsys.cpp @@ -8226,6 +8226,12 @@
> m_bShoutcast = TRUE;
> m_ulMinStartupLengthNeeded =
> HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> }
> + else
> + {
> +#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + m_LastError = HXR_NOT_SUPPORTED;
> +#endif
> + }
> }
>
> if ((ulLength > 4) && (ulLength >=
> m_ulMinStartupLengthNeeded))
>
>
_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
From rmathew at real.com Tue Apr 15 17:05:30 2008
From: rmathew at real.com (Rishi Mathew)
Date: Tue Apr 15 16:01:56 2008
Subject: CN: [Filesystem-dev] CR: Helix crashes when attempting to
stream aramfile with http protocol
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B366FCE993@daebe103.NOE.Nokia. com>
References: <2A15C07EF7DF6243A092FB438FD4B366FCE852@daebe103.NOE.Nokia.com>
<002801c89ef5$974d2290$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B366FCE993@daebe103.NOE.Nokia.com>
Message-ID: <6.2.1.2.2.20080415170438.08361110@mailone.real.com>
Please also commit to 310_atlas moving forward for all cross-platform code.
Cheers,
Rishi.
At 08:39 AM 4/15/2008, Praveen.Thimmashetty@nokia.com wrote:
>Committed to head and 210CayS
>
>Thanks
>Praveen
>
>-----Original Message-----
>From: filesystem-dev-bounces@helixcommunity.org
>[mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of ext Eric
>Hyche
>Sent: Tuesday, April 15, 2008 7:38 AM
>To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
>filesystem-dev@helixcommunity.org
>Subject: RE: [Filesystem-dev] CR: Helix crashes when attempting to
>stream aramfile with http protocol
>
>
>Looks good.
>
>=============================================
>Eric Hyche (ehyche@real.com)
>Technical Lead
>RealNetworks, Inc.
>
> > -----Original Message-----
> > From: filesystem-dev-bounces@helixcommunity.org
> > [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> > Praveen.Thimmashetty@nokia.com
> > Sent: Monday, April 14, 2008 7:26 PM
> > To: filesystem-dev@helixcommunity.org
> > Subject: [Filesystem-dev] CR: Helix crashes when attempting to stream
> > a ramfile with http protocol
> >
> >
> > "Nokia submits this code under the terms of a commercial contribution
> > agreement with RealNetworks, and I am authorized to contribute this
> > code under said agreement."
> >
> >
> > Modified by: praveen.thimmashetty@nokia.com
> >
> > Reviewed by:
> >
> > Date: 04/14/2008
> >
> > Project: SymbianMmf
> >
> > ErrorId: OVIL-7DPQXK
> >
> > Synopsis: Helix crashes when attempting to stream a ram file with http
>
> > protocol
> >
> > HTTP File system will support only shoutcast streams. There is no seek
>
> > support. Changes are made to return proper error code.
> >
> > Root Cause of the problem: implementation
> >
> >
> > Files Modified:
> > filesystem/http/httpfsys.cpp
> >
> > Files Added: None
> >
> >
> > Image Size and Heap Use impact: None
> >
> > Module Release testing (STIF) : Done.
> >
> > Test case(s) Added : N/A
> >
> > Memory leak check performed : yes. No leak.
> >
> > Platforms and Profiles Build Verified:
> > helix-client-s60-50-mmf-mdf-arm
> >
> > Platforms and Profiles Functionality verified: armv5, winscw
> >
> > Branch: Head & 210CayS
> >
> >
> > Index: httpfsys.cpp
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> > retrieving revision 1.88.2.7
> > diff -w -u -b -r1.88.2.7 httpfsys.cpp @@ -8226,6 +8226,12 @@
> > m_bShoutcast = TRUE;
> > m_ulMinStartupLengthNeeded =
> > HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> > }
> > + else
> > + {
> > +#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> > + m_LastError = HXR_NOT_SUPPORTED;
> > +#endif
> > + }
> > }
> >
> > if ((ulLength > 4) && (ulLength >=
> > m_ulMinStartupLengthNeeded))
> >
> >
>
>
>_______________________________________________
>Filesystem-dev mailing list
>Filesystem-dev@helixcommunity.org
>http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
>
>_______________________________________________
>Filesystem-dev mailing list
>Filesystem-dev@helixcommunity.org
>http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
Rishi Mathew
Helix Community
RealNetworks, Inc.
rmathew@real.com
http://www.helixcommunity.org
http://www.realnetworks.com/products/support/devsupport.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/filesystem-dev/attachments/20080415/059c2fa7/attachment.html
From Praveen.Thimmashetty at nokia.com Wed Apr 16 08:59:30 2008
From: Praveen.Thimmashetty at nokia.com (Praveen.Thimmashetty@nokia.com)
Date: Wed Apr 16 08:01:34 2008
Subject: CN: [Filesystem-dev] CR: Helix crashes when attempting to stream
aramfile with http protocol
In-Reply-To: <6.2.1.2.2.20080415170438.08361110@mailone.real.com>
References: <2A15C07EF7DF6243A092FB438FD4B366FCE852@daebe103.NOE.Nokia.com>
<002801c89ef5$974d2290$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B366FCE993@daebe103.NOE.Nokia.com>
<6.2.1.2.2.20080415170438.08361110@mailone.real.com>
Message-ID: <2A15C07EF7DF6243A092FB438FD4B366FCECC6@daebe103.NOE.Nokia.com>
committed to 310_atlas
Thanks
Praveen
________________________________
From: ext Rishi Mathew [mailto:rmathew@real.com]
Sent: Tuesday, April 15, 2008 7:06 PM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas); ehyche@real.com;
filesystem-dev@helixcommunity.org
Subject: Re: CN: [Filesystem-dev] CR: Helix crashes when attempting to
stream aramfile with http protocol
Please also commit to 310_atlas moving forward for all cross-platform
code.
Cheers,
Rishi.
At 08:39 AM 4/15/2008, Praveen.Thimmashetty@nokia.com wrote:
Committed to head and 210CayS
Thanks
Praveen
-----Original Message-----
From: filesystem-dev-bounces@helixcommunity.org
[ mailto:filesystem-dev-bounces@helixcommunity.org
] On Behalf Of ext
Eric
Hyche
Sent: Tuesday, April 15, 2008 7:38 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-dev@helixcommunity.org
Subject: RE: [Filesystem-dev] CR: Helix crashes when attempting
to
stream aramfile with http protocol
Looks good.
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [ mailto:filesystem-dev-bounces@helixcommunity.org
] On Behalf Of
> Praveen.Thimmashetty@nokia.com
> Sent: Monday, April 14, 2008 7:26 PM
> To: filesystem-dev@helixcommunity.org
> Subject: [Filesystem-dev] CR: Helix crashes when attempting to
stream
> a ramfile with http protocol
>
>
> "Nokia submits this code under the terms of a commercial
contribution
> agreement with RealNetworks, and I am authorized to contribute
this
> code under said agreement."
>
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/14/2008
>
> Project: SymbianMmf
>
> ErrorId: OVIL-7DPQXK
>
> Synopsis: Helix crashes when attempting to stream a ram file
with http
> protocol
>
> HTTP File system will support only shoutcast streams. There is
no seek
> support. Changes are made to return proper error code.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> filesystem/http/httpfsys.cpp
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: httpfsys.cpp
>
===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.7
> diff -w -u -b -r1.88.2.7 httpfsys.cpp @@ -8226,6 +8226,12 @@
> m_bShoutcast = TRUE;
> m_ulMinStartupLengthNeeded =
> HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> }
> + else
> + {
> +#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + m_LastError = HXR_NOT_SUPPORTED;
> +#endif
> + }
> }
>
> if ((ulLength > 4) && (ulLength >=
> m_ulMinStartupLengthNeeded))
>
>
_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
Rishi Mathew
Helix Community
Real Networks, Inc.
rmathew@real.com
http://www.helixcommunity.org
http://www.realnetworks.com/products/support/devsupport.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/filesystem-dev/attachments/20080416/ccb0b8a6/attachment-0001.html
From ping at real.com Thu Apr 17 10:07:23 2008
From: ping at real.com (Henry Ping)
Date: Thu Apr 17 09:03:27 2008
Subject: CN: [Filesystem-dev] CR: Helix crashes when attempting to
streamaramfile with http protocol
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B366FCECC6@daebe103.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B366FCE852@daebe103.NOE.Nokia.com><002801c89ef5$974d2290$db68a8c0@EHYCHED620><2A15C07EF7DF6243A092FB438FD4B366FCE993@daebe103.NOE.Nokia.com><6.2.1.2.2.20080415170438.08361110@mailone.real.com>
<2A15C07EF7DF6243A092FB438FD4B366FCECC6@daebe103.NOE.Nokia.com>
Message-ID:
Hi, Praveen
Your checkin below breaks HTTP playback of content(i.e. RM, FLV and RAM)
from non-Shoutcast server when HELIX_FEATURE_HTTP_ENABLE_CACHE is not
defined. It reports "HXR_NOT_SUPPORTED" error.
HELIX_FEATURE_HTTP_ENABLE_CACHE is an advanced feature and is not mandatory
for HTTP playback. We have internal product that doesn't have this defined.
Our QA is blocked by this so I have to reverse your checkins.
HTTP playback of RAM was ok in our product prior to your checkins, so I
believe the crash you described below needs to be fixed somewhere else.
Henry
_____
From: filesystem-dev-bounces@helixcommunity.org
[mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
Praveen.Thimmashetty@nokia.com
Sent: Wednesday, April 16, 2008 9:00 AM
To: rmathew@real.com; ehyche@real.com; filesystem-dev@helixcommunity.org
Subject: RE: CN: [Filesystem-dev] CR: Helix crashes when attempting to
streamaramfile with http protocol
committed to 310_atlas
Thanks
Praveen
_____
From: ext Rishi Mathew [mailto:rmathew@real.com]
Sent: Tuesday, April 15, 2008 7:06 PM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas); ehyche@real.com;
filesystem-dev@helixcommunity.org
Subject: Re: CN: [Filesystem-dev] CR: Helix crashes when attempting to
stream aramfile with http protocol
Please also commit to 310_atlas moving forward for all cross-platform code.
Cheers,
Rishi.
At 08:39 AM 4/15/2008, Praveen.Thimmashetty@nokia.com wrote:
Committed to head and 210CayS
Thanks
Praveen
-----Original Message-----
From: filesystem-dev-bounces@helixcommunity.org
[
mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of ext Eric
Hyche
Sent: Tuesday, April 15, 2008 7:38 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-dev@helixcommunity.org
Subject: RE: [Filesystem-dev] CR: Helix crashes when attempting to
stream aramfile with http protocol
Looks good.
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [ mailto:filesystem-dev-bounces@helixcommunity.org
] On Behalf Of
> Praveen.Thimmashetty@nokia.com
> Sent: Monday, April 14, 2008 7:26 PM
> To: filesystem-dev@helixcommunity.org
> Subject: [Filesystem-dev] CR: Helix crashes when attempting to stream
> a ramfile with http protocol
>
>
> "Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to contribute this
> code under said agreement."
>
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/14/2008
>
> Project: SymbianMmf
>
> ErrorId: OVIL-7DPQXK
>
> Synopsis: Helix crashes when attempting to stream a ram file with http
> protocol
>
> HTTP File system will support only shoutcast streams. There is no seek
> support. Changes are made to return proper error code.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> filesystem/http/httpfsys.cpp
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.7
> diff -w -u -b -r1.88.2.7 httpfsys.cpp @@ -8226,6 +8226,12 @@
> m_bShoutcast = TRUE;
> m_ulMinStartupLengthNeeded =
> HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> }
> + else
> + {
> +#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + m_LastError = HXR_NOT_SUPPORTED;
> +#endif
> + }
> }
>
> if ((ulLength > 4) && (ulLength >=
> m_ulMinStartupLengthNeeded))
>
>
_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
Rishi Mathew
Helix Community
Real Networks, Inc.
rmathew@real.com
http://www.helixcommunity.org
http://www.realnetworks.com/products/support/devsupport.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/filesystem-dev/attachments/20080417/40cbfca2/attachment.html
From Praveen.Thimmashetty at nokia.com Mon Apr 21 11:58:52 2008
From: Praveen.Thimmashetty at nokia.com (Praveen.Thimmashetty@nokia.com)
Date: Mon Apr 21 10:53:46 2008
Subject: [Filesystem-dev] CR: Config option to enable/disable non-shoutcast
http playback
Message-ID: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
> "Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to contribute this
> code under said agreement."
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/21/2008
>
> Project: SymbianMmf
>
> ErrorId: PTHY-7DWLHK
>
> Synopsis: Config option to enable/disable non-shoutcast http playback
>
> Config option to enable/disable non-shoutcast http playback support is
> added. Currently HTTPFileSys on 210Cays Supports shoutcast stream only
> for symbian platform.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
> filesystem/http/httpfsys.cpp
> filesystem/http/httpfsys.h
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: R1_Mobile_4_0_Factory.cfg
> ===================================================================
> RCS file:
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> retrieving revision 1.26.2.23
> diff -w -u -b -r1.26.2.23 R1_Mobile_4_0_Factory.cfg
> @@ -22,6 +22,7 @@
> HTTPProxyHost=
> HTTPProxyPort=80
> HTTPProxySupport=0
> +HTTPShoutcastSupportOnly=1
> LocalMediaFolder=c:\nokia\videos\
> LogSink=console
> LoopMode=0
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.8
> diff -w -u -b -r1.88.2.8 httpfsys.cpp
> @@ -1130,6 +1130,7 @@
> , m_ulIgnoreBytesYetToBeDownloaded(0)
> , m_ulLastHeaderSize(0)
> , m_bDiscardOrphanLFInChunkedData(FALSE)
> + , m_bShoutcastSupportOnly(FALSE)
> /*************************/
> {
> SetSupportsByteRanges(m_bSupportsByteRanges);
> @@ -1283,6 +1284,7 @@
> pRegistry->Release();
> }
> }
> + ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
> m_bShoutcastSupportOnly);
>
> // if the language pref is an empty string, we're not
> // interested
> @@ -8228,9 +8230,10 @@
> }
> else
> {
> -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + if(m_bShoutcastSupportOnly)
> + {
> m_LastError = HXR_NOT_SUPPORTED;
> -#endif
> + }
> }
> }
>
> Index: httpfsys.h
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> retrieving revision 1.34.2.2
> diff -w -u -b -r1.34.2.2 httpfsys.h
> @@ -955,6 +955,7 @@
>
> HXBOOL m_bHaltSocketReadTemporarily;
> ULONG32 m_ulMaxBufSize ;
> + HXBOOL m_bShoutcastSupportOnly;
> };
>
> class HTTPTCPResponse : public CUnknownIMP,
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/filesystem-dev/attachments/20080421/4e5830b1/attachment-0001.html
From ehyche at real.com Mon Apr 21 12:14:37 2008
From: ehyche at real.com (Eric Hyche)
Date: Mon Apr 21 11:09:16 2008
Subject: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
Message-ID: <00dd01c8a3e3$f2332180$db68a8c0@EHYCHED620>
Praveen,
The diff you provided for httpfsys was apparently from
210Cays. Can you provide a diff from the HEAD as well,
since this change is also targeted for HEAD?
Thanks,
Eric
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf
> Of Praveen.Thimmashetty@nokia.com
> Sent: Monday, April 21, 2008 2:59 PM
> To: filesystem-dev@helixcommunity.org; ping@real.com
> Subject: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
>
> "Nokia submits this code under the terms of a commercial
> contribution agreement with RealNetworks, and I am authorized
> to contribute this code under said agreement."
>
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/21/2008
>
> Project: SymbianMmf
>
> ErrorId: PTHY-7DWLHK
>
> Synopsis: Config option to enable/disable non-shoutcast http playback
>
> Config option to enable/disable non-shoutcast http playback
> support is added. Currently HTTPFileSys on 210Cays Supports
> shoutcast stream only for symbian platform.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
> filesystem/http/httpfsys.cpp
> filesystem/http/httpfsys.h
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: R1_Mobile_4_0_Factory.cfg
> ===================================================================
> RCS file:
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> retrieving revision 1.26.2.23
> diff -w -u -b -r1.26.2.23 R1_Mobile_4_0_Factory.cfg
> @@ -22,6 +22,7 @@
> HTTPProxyHost=
> HTTPProxyPort=80
> HTTPProxySupport=0
> +HTTPShoutcastSupportOnly=1
> LocalMediaFolder=c:\nokia\videos\
> LogSink=console
> LoopMode=0
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.8
> diff -w -u -b -r1.88.2.8 httpfsys.cpp
> @@ -1130,6 +1130,7 @@
> , m_ulIgnoreBytesYetToBeDownloaded(0)
> , m_ulLastHeaderSize(0)
> , m_bDiscardOrphanLFInChunkedData(FALSE)
> + , m_bShoutcastSupportOnly(FALSE)
> /*************************/
> {
> SetSupportsByteRanges(m_bSupportsByteRanges);
> @@ -1283,6 +1284,7 @@
> pRegistry->Release();
> }
> }
> + ReadPrefBOOL(m_pPreferences,
> "HTTPShoutcastSupportOnly", m_bShoutcastSupportOnly);
>
> // if the language pref is an empty string, we're not
> // interested
> @@ -8228,9 +8230,10 @@
> }
> else
> {
> -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + if(m_bShoutcastSupportOnly)
> + {
> m_LastError = HXR_NOT_SUPPORTED;
> -#endif
> + }
> }
> }
>
> Index: httpfsys.h
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> retrieving revision 1.34.2.2
> diff -w -u -b -r1.34.2.2 httpfsys.h
> @@ -955,6 +955,7 @@
>
> HXBOOL m_bHaltSocketReadTemporarily;
> ULONG32 m_ulMaxBufSize ;
> + HXBOOL m_bShoutcastSupportOnly;
> };
>
> class HTTPTCPResponse : public CUnknownIMP,
>
>
>
From Praveen.Thimmashetty at nokia.com Mon Apr 21 12:35:55 2008
From: Praveen.Thimmashetty at nokia.com (Praveen.Thimmashetty@nokia.com)
Date: Mon Apr 21 11:30:40 2008
Subject: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
In-Reply-To: <00dd01c8a3e3$f2332180$db68a8c0@EHYCHED620>
References: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
<00dd01c8a3e3$f2332180$db68a8c0@EHYCHED620>
Message-ID: <2A15C07EF7DF6243A092FB438FD4B3660105D313@daebe103.NOE.Nokia.com>
Hi Eric,
Please find the diff for branch HEAD.
Do I have to commit this change to 310Atlas?
Thanks
Praveen
Index: R1_Mobile_4_0_Factory.cfg
===================================================================
RCS file:
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
retrieving revision 1.44
diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg
@@ -22,6 +22,7 @@
HTTPProxyHost=
HTTPProxyPort=80
HTTPProxySupport=0
+HTTPShoutcastSupportOnly=1
LocalMediaFolder=c:\nokia\videos\
LogSink=console
LoopMode=0
Index: httpfsys.cpp
===================================================================
RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
retrieving revision 1.120
diff -w -u -b -r1.120 httpfsys.cpp
@@ -1132,6 +1132,7 @@
, m_ulIgnoreBytesYetToBeDownloaded(0)
, m_ulLastHeaderSize(0)
, m_bDiscardOrphanLFInChunkedData(FALSE)
+ , m_bShoutcastSupportOnly(FALSE)
/*************************/
{
SetSupportsByteRanges(m_bSupportsByteRanges);
@@ -1281,6 +1282,7 @@
pRegistry->Release();
}
}
+ ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
m_bShoutcastSupportOnly);
// if the language pref is an empty string, we're not
// interested
@@ -8224,9 +8226,10 @@
}
else
{
-#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
+ if(m_bShoutcastSupportOnly)
+ {
m_LastError = HXR_NOT_SUPPORTED;
-#endif
+ }
}
}
Index: httpfsys.h
===================================================================
RCS file: /cvsroot/filesystem/http/httpfsys.h,v
retrieving revision 1.43
diff -w -u -b -r1.43 httpfsys.h
@@ -957,6 +957,7 @@
HXBOOL m_bHaltSocketReadTemporarily;
ULONG32 m_ulMaxBufSize ;
+ HXBOOL m_bShoutcastSupportOnly;
};
class HTTPTCPResponse : public CUnknownIMP,
-----Original Message-----
From: ext Eric Hyche [mailto:ehyche@real.com]
Sent: Monday, April 21, 2008 2:15 PM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-dev@helixcommunity.org; ping@real.com
Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
Praveen,
The diff you provided for httpfsys was apparently from 210Cays. Can you
provide a diff from the HEAD as well, since this change is also targeted
for HEAD?
Thanks,
Eric
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org
> [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> Praveen.Thimmashetty@nokia.com
> Sent: Monday, April 21, 2008 2:59 PM
> To: filesystem-dev@helixcommunity.org; ping@real.com
> Subject: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
>
> "Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to contribute this
> code under said agreement."
>
>
> Modified by: praveen.thimmashetty@nokia.com
>
> Reviewed by:
>
> Date: 04/21/2008
>
> Project: SymbianMmf
>
> ErrorId: PTHY-7DWLHK
>
> Synopsis: Config option to enable/disable non-shoutcast http playback
>
> Config option to enable/disable non-shoutcast http playback support is
> added. Currently HTTPFileSys on 210Cays Supports shoutcast stream only
> for symbian platform.
>
> Root Cause of the problem: implementation
>
>
> Files Modified:
> clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
> filesystem/http/httpfsys.cpp
> filesystem/http/httpfsys.h
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Done.
>
> Test case(s) Added : N/A
>
> Memory leak check performed : yes. No leak.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: Head & 210CayS
>
>
> Index: R1_Mobile_4_0_Factory.cfg
> ===================================================================
> RCS file:
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> retrieving revision 1.26.2.23
> diff -w -u -b -r1.26.2.23 R1_Mobile_4_0_Factory.cfg @@ -22,6 +22,7 @@
> HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> +HTTPShoutcastSupportOnly=1
> LocalMediaFolder=c:\nokia\videos\
> LogSink=console
> LoopMode=0
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.88.2.8
> diff -w -u -b -r1.88.2.8 httpfsys.cpp @@ -1130,6 +1130,7 @@
> , m_ulIgnoreBytesYetToBeDownloaded(0)
> , m_ulLastHeaderSize(0)
> , m_bDiscardOrphanLFInChunkedData(FALSE)
> + , m_bShoutcastSupportOnly(FALSE)
> /*************************/
> {
> SetSupportsByteRanges(m_bSupportsByteRanges);
> @@ -1283,6 +1284,7 @@
> pRegistry->Release();
> }
> }
> + ReadPrefBOOL(m_pPreferences,
> "HTTPShoutcastSupportOnly", m_bShoutcastSupportOnly);
>
> // if the language pref is an empty string, we're not
> // interested
> @@ -8228,9 +8230,10 @@
> }
> else
> {
> -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + if(m_bShoutcastSupportOnly)
> + {
> m_LastError = HXR_NOT_SUPPORTED;
> -#endif
> + }
> }
> }
>
> Index: httpfsys.h
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> retrieving revision 1.34.2.2
> diff -w -u -b -r1.34.2.2 httpfsys.h
> @@ -955,6 +955,7 @@
>
> HXBOOL m_bHaltSocketReadTemporarily;
> ULONG32 m_ulMaxBufSize ;
> + HXBOOL m_bShoutcastSupportOnly;
> };
>
> class HTTPTCPResponse : public CUnknownIMP,
>
>
>
From ehyche at real.com Mon Apr 21 12:47:00 2008
From: ehyche at real.com (Eric Hyche)
Date: Mon Apr 21 11:41:39 2008
Subject: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B3660105D313@daebe103.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
<00dd01c8a3e3$f2332180$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B3660105D313@daebe103.NOE.Nokia.com>
Message-ID: <00e801c8a3e8$78b0c510$db68a8c0@EHYCHED620>
I'm not finding any existing line in httpfsys.cpp on
the HEAD which looks like this:
-#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
so I can't really tell where in the code this is
changing.
Eric
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: Praveen.Thimmashetty@nokia.com
> [mailto:Praveen.Thimmashetty@nokia.com]
> Sent: Monday, April 21, 2008 3:36 PM
> To: ehyche@real.com; filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to
> enable/disable non-shoutcasthttp playback
>
> Hi Eric,
>
> Please find the diff for branch HEAD.
> Do I have to commit this change to 310Atlas?
>
> Thanks
> Praveen
>
> Index: R1_Mobile_4_0_Factory.cfg
> ===================================================================
> RCS file:
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> retrieving revision 1.44
> diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg
> @@ -22,6 +22,7 @@
> HTTPProxyHost=
> HTTPProxyPort=80
> HTTPProxySupport=0
> +HTTPShoutcastSupportOnly=1
> LocalMediaFolder=c:\nokia\videos\
> LogSink=console
> LoopMode=0
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.120
> diff -w -u -b -r1.120 httpfsys.cpp
> @@ -1132,6 +1132,7 @@
> , m_ulIgnoreBytesYetToBeDownloaded(0)
> , m_ulLastHeaderSize(0)
> , m_bDiscardOrphanLFInChunkedData(FALSE)
> + , m_bShoutcastSupportOnly(FALSE)
> /*************************/
> {
> SetSupportsByteRanges(m_bSupportsByteRanges);
> @@ -1281,6 +1282,7 @@
> pRegistry->Release();
> }
> }
> + ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
> m_bShoutcastSupportOnly);
>
> // if the language pref is an empty string, we're not
> // interested
> @@ -8224,9 +8226,10 @@
> }
> else
> {
> -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + if(m_bShoutcastSupportOnly)
> + {
> m_LastError = HXR_NOT_SUPPORTED;
> -#endif
> + }
> }
> }
>
> Index: httpfsys.h
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> retrieving revision 1.43
> diff -w -u -b -r1.43 httpfsys.h
> @@ -957,6 +957,7 @@
>
> HXBOOL m_bHaltSocketReadTemporarily;
> ULONG32 m_ulMaxBufSize ;
> + HXBOOL m_bShoutcastSupportOnly;
> };
>
> class HTTPTCPResponse : public CUnknownIMP,
>
>
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehyche@real.com]
> Sent: Monday, April 21, 2008 2:15 PM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
>
> Praveen,
>
> The diff you provided for httpfsys was apparently from
> 210Cays. Can you
> provide a diff from the HEAD as well, since this change is
> also targeted
> for HEAD?
>
> Thanks,
>
> Eric
>
> =============================================
> Eric Hyche (ehyche@real.com)
> Technical Lead
> RealNetworks, Inc.
>
> > -----Original Message-----
> > From: filesystem-dev-bounces@helixcommunity.org
> > [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> > Praveen.Thimmashetty@nokia.com
> > Sent: Monday, April 21, 2008 2:59 PM
> > To: filesystem-dev@helixcommunity.org; ping@real.com
> > Subject: [Filesystem-dev] CR: Config option to enable/disable
> > non-shoutcasthttp playback
> >
> >
> > "Nokia submits this code under the terms of a commercial
> contribution
> > agreement with RealNetworks, and I am authorized to contribute this
> > code under said agreement."
> >
> >
> > Modified by: praveen.thimmashetty@nokia.com
> >
> > Reviewed by:
> >
> > Date: 04/21/2008
> >
> > Project: SymbianMmf
> >
> > ErrorId: PTHY-7DWLHK
> >
> > Synopsis: Config option to enable/disable non-shoutcast
> http playback
> >
> > Config option to enable/disable non-shoutcast http playback
> support is
>
> > added. Currently HTTPFileSys on 210Cays Supports shoutcast
> stream only
>
> > for symbian platform.
> >
> > Root Cause of the problem: implementation
> >
> >
> > Files Modified:
> > clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
> > filesystem/http/httpfsys.cpp
> > filesystem/http/httpfsys.h
> >
> > Files Added: None
> >
> >
> > Image Size and Heap Use impact: None
> >
> > Module Release testing (STIF) : Done.
> >
> > Test case(s) Added : N/A
> >
> > Memory leak check performed : yes. No leak.
> >
> > Platforms and Profiles Build Verified:
> > helix-client-s60-50-mmf-mdf-arm
> >
> > Platforms and Profiles Functionality verified: armv5, winscw
> >
> > Branch: Head & 210CayS
> >
> >
> > Index: R1_Mobile_4_0_Factory.cfg
> > ===================================================================
> > RCS file:
> > /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> > retrieving revision 1.26.2.23
> > diff -w -u -b -r1.26.2.23 R1_Mobile_4_0_Factory.cfg @@
> -22,6 +22,7 @@
>
> > HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> > +HTTPShoutcastSupportOnly=1
> > LocalMediaFolder=c:\nokia\videos\
> > LogSink=console
> > LoopMode=0
> >
> > Index: httpfsys.cpp
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> > retrieving revision 1.88.2.8
> > diff -w -u -b -r1.88.2.8 httpfsys.cpp @@ -1130,6 +1130,7 @@
> > , m_ulIgnoreBytesYetToBeDownloaded(0)
> > , m_ulLastHeaderSize(0)
> > , m_bDiscardOrphanLFInChunkedData(FALSE)
> > + , m_bShoutcastSupportOnly(FALSE)
> > /*************************/
> > {
> > SetSupportsByteRanges(m_bSupportsByteRanges);
> > @@ -1283,6 +1284,7 @@
> > pRegistry->Release();
> > }
> > }
> > + ReadPrefBOOL(m_pPreferences,
> > "HTTPShoutcastSupportOnly", m_bShoutcastSupportOnly);
> >
> > // if the language pref is an empty string, we're not
> > // interested
> > @@ -8228,9 +8230,10 @@
> > }
> > else
> > {
> > -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> > + if(m_bShoutcastSupportOnly)
> > + {
> > m_LastError = HXR_NOT_SUPPORTED;
> > -#endif
> > + }
> > }
> > }
> >
> > Index: httpfsys.h
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> > retrieving revision 1.34.2.2
> > diff -w -u -b -r1.34.2.2 httpfsys.h
> > @@ -955,6 +955,7 @@
> >
> > HXBOOL m_bHaltSocketReadTemporarily;
> > ULONG32 m_ulMaxBufSize ;
> > + HXBOOL m_bShoutcastSupportOnly;
> > };
> >
> > class HTTPTCPResponse : public CUnknownIMP,
> >
> >
> >
>
From Praveen.Thimmashetty at nokia.com Mon Apr 21 13:29:30 2008
From: Praveen.Thimmashetty at nokia.com (Praveen.Thimmashetty@nokia.com)
Date: Mon Apr 21 12:25:20 2008
Subject: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
In-Reply-To: <00e801c8a3e8$78b0c510$db68a8c0@EHYCHED620>
References: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
<00dd01c8a3e3$f2332180$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B3660105D313@daebe103.NOE.Nokia.com>
<00e801c8a3e8$78b0c510$db68a8c0@EHYCHED620>
Message-ID: <2A15C07EF7DF6243A092FB438FD4B3660105D352@daebe103.NOE.Nokia.com>
Hi Eric,
Looks like my previous changes to this Httpfsys.cpp has been backed out
by ping.
Somehow diff didn't catch that.
Please find the updated diff below.
Thanks
Praveen
Index: R1_Mobile_4_0_Factory.cfg
===================================================================
RCS file:
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
retrieving revision 1.44
diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg @@ -22,6 +22,7 @@
HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
+HTTPShoutcastSupportOnly=1
LocalMediaFolder=c:\nokia\videos\
LogSink=console
LoopMode=0
Index: httpfsys.cpp
===================================================================
RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
retrieving revision 1.121
diff -w -u -b -r1.121 httpfsys.cpp
@@ -1132,6 +1132,7 @@
, m_ulIgnoreBytesYetToBeDownloaded(0)
, m_ulLastHeaderSize(0)
, m_bDiscardOrphanLFInChunkedData(FALSE)
+ , m_bShoutcastSupportOnly(FALSE)
/*************************/
{
SetSupportsByteRanges(m_bSupportsByteRanges);
@@ -1281,6 +1282,7 @@
pRegistry->Release();
}
}
+ ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
m_bShoutcastSupportOnly);
// if the language pref is an empty string, we're not
// interested
@@ -8222,6 +8224,13 @@
m_bShoutcast = TRUE;
m_ulMinStartupLengthNeeded =
HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
}
+ else
+ {
+ if(m_bShoutcastSupportOnly)
+ {
+ m_LastError = HXR_NOT_SUPPORTED;
+ }
+ }
}
if ((ulLength > 4) && (ulLength >= m_ulMinStartupLengthNeeded))
Index: httpfsys.h
===================================================================
RCS file: /cvsroot/filesystem/http/httpfsys.h,v
retrieving revision 1.43
diff -w -u -b -r1.43 httpfsys.h
@@ -957,6 +957,7 @@
HXBOOL m_bHaltSocketReadTemporarily;
ULONG32 m_ulMaxBufSize ;
+ HXBOOL m_bShoutcastSupportOnly;
};
class HTTPTCPResponse : public CUnknownIMP,
-----Original Message-----
From: ext Eric Hyche [mailto:ehyche@real.com]
Sent: Monday, April 21, 2008 2:47 PM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-dev@helixcommunity.org; ping@real.com
Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
I'm not finding any existing line in httpfsys.cpp on the HEAD which
looks like this:
-#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
so I can't really tell where in the code this is changing.
Eric
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: Praveen.Thimmashetty@nokia.com
> [mailto:Praveen.Thimmashetty@nokia.com]
> Sent: Monday, April 21, 2008 3:36 PM
> To: ehyche@real.com; filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
> Hi Eric,
>
> Please find the diff for branch HEAD.
> Do I have to commit this change to 310Atlas?
>
> Thanks
> Praveen
>
> Index: R1_Mobile_4_0_Factory.cfg
> ===================================================================
> RCS file:
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> retrieving revision 1.44
> diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg @@ -22,6 +22,7 @@
> HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> +HTTPShoutcastSupportOnly=1
> LocalMediaFolder=c:\nokia\videos\
> LogSink=console
> LoopMode=0
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.120
> diff -w -u -b -r1.120 httpfsys.cpp
> @@ -1132,6 +1132,7 @@
> , m_ulIgnoreBytesYetToBeDownloaded(0)
> , m_ulLastHeaderSize(0)
> , m_bDiscardOrphanLFInChunkedData(FALSE)
> + , m_bShoutcastSupportOnly(FALSE)
> /*************************/
> {
> SetSupportsByteRanges(m_bSupportsByteRanges);
> @@ -1281,6 +1282,7 @@
> pRegistry->Release();
> }
> }
> + ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
> m_bShoutcastSupportOnly);
>
> // if the language pref is an empty string, we're not
> // interested
> @@ -8224,9 +8226,10 @@
> }
> else
> {
> -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> + if(m_bShoutcastSupportOnly)
> + {
> m_LastError = HXR_NOT_SUPPORTED; -#endif
> + }
> }
> }
>
> Index: httpfsys.h
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> retrieving revision 1.43
> diff -w -u -b -r1.43 httpfsys.h
> @@ -957,6 +957,7 @@
>
> HXBOOL m_bHaltSocketReadTemporarily;
> ULONG32 m_ulMaxBufSize ;
> + HXBOOL m_bShoutcastSupportOnly;
> };
>
> class HTTPTCPResponse : public CUnknownIMP,
>
>
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehyche@real.com]
> Sent: Monday, April 21, 2008 2:15 PM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
>
> Praveen,
>
> The diff you provided for httpfsys was apparently from 210Cays. Can
> you provide a diff from the HEAD as well, since this change is also
> targeted for HEAD?
>
> Thanks,
>
> Eric
>
> =============================================
> Eric Hyche (ehyche@real.com)
> Technical Lead
> RealNetworks, Inc.
>
> > -----Original Message-----
> > From: filesystem-dev-bounces@helixcommunity.org
> > [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> > Praveen.Thimmashetty@nokia.com
> > Sent: Monday, April 21, 2008 2:59 PM
> > To: filesystem-dev@helixcommunity.org; ping@real.com
> > Subject: [Filesystem-dev] CR: Config option to enable/disable
> > non-shoutcasthttp playback
> >
> >
> > "Nokia submits this code under the terms of a commercial
> contribution
> > agreement with RealNetworks, and I am authorized to contribute this
> > code under said agreement."
> >
> >
> > Modified by: praveen.thimmashetty@nokia.com
> >
> > Reviewed by:
> >
> > Date: 04/21/2008
> >
> > Project: SymbianMmf
> >
> > ErrorId: PTHY-7DWLHK
> >
> > Synopsis: Config option to enable/disable non-shoutcast
> http playback
> >
> > Config option to enable/disable non-shoutcast http playback
> support is
>
> > added. Currently HTTPFileSys on 210Cays Supports shoutcast
> stream only
>
> > for symbian platform.
> >
> > Root Cause of the problem: implementation
> >
> >
> > Files Modified:
> > clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
> > filesystem/http/httpfsys.cpp
> > filesystem/http/httpfsys.h
> >
> > Files Added: None
> >
> >
> > Image Size and Heap Use impact: None
> >
> > Module Release testing (STIF) : Done.
> >
> > Test case(s) Added : N/A
> >
> > Memory leak check performed : yes. No leak.
> >
> > Platforms and Profiles Build Verified:
> > helix-client-s60-50-mmf-mdf-arm
> >
> > Platforms and Profiles Functionality verified: armv5, winscw
> >
> > Branch: Head & 210CayS
> >
> >
> > Index: R1_Mobile_4_0_Factory.cfg
> > ===================================================================
> > RCS file:
> > /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> > retrieving revision 1.26.2.23
> > diff -w -u -b -r1.26.2.23 R1_Mobile_4_0_Factory.cfg @@
> -22,6 +22,7 @@
>
> > HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> > +HTTPShoutcastSupportOnly=1
> > LocalMediaFolder=c:\nokia\videos\
> > LogSink=console
> > LoopMode=0
> >
> > Index: httpfsys.cpp
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> > retrieving revision 1.88.2.8
> > diff -w -u -b -r1.88.2.8 httpfsys.cpp @@ -1130,6 +1130,7 @@
> > , m_ulIgnoreBytesYetToBeDownloaded(0)
> > , m_ulLastHeaderSize(0)
> > , m_bDiscardOrphanLFInChunkedData(FALSE)
> > + , m_bShoutcastSupportOnly(FALSE)
> > /*************************/
> > {
> > SetSupportsByteRanges(m_bSupportsByteRanges);
> > @@ -1283,6 +1284,7 @@
> > pRegistry->Release();
> > }
> > }
> > + ReadPrefBOOL(m_pPreferences,
> > "HTTPShoutcastSupportOnly", m_bShoutcastSupportOnly);
> >
> > // if the language pref is an empty string, we're not
> > // interested
> > @@ -8228,9 +8230,10 @@
> > }
> > else
> > {
> > -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> > + if(m_bShoutcastSupportOnly)
> > + {
> > m_LastError = HXR_NOT_SUPPORTED;
> > -#endif
> > + }
> > }
> > }
> >
> > Index: httpfsys.h
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> > retrieving revision 1.34.2.2
> > diff -w -u -b -r1.34.2.2 httpfsys.h
> > @@ -955,6 +955,7 @@
> >
> > HXBOOL m_bHaltSocketReadTemporarily;
> > ULONG32 m_ulMaxBufSize ;
> > + HXBOOL m_bShoutcastSupportOnly;
> > };
> >
> > class HTTPTCPResponse : public CUnknownIMP,
> >
> >
> >
>
From ehyche at real.com Mon Apr 21 14:05:51 2008
From: ehyche at real.com (Eric Hyche)
Date: Mon Apr 21 13:00:31 2008
Subject: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B3660105D352@daebe103.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
<00dd01c8a3e3$f2332180$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B3660105D313@daebe103.NOE.Nokia.com>
<00e801c8a3e8$78b0c510$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B3660105D352@daebe103.NOE.Nokia.com>
Message-ID: <012001c8a3f3$7bf19730$db68a8c0@EHYCHED620>
Looks good. Please add a comment right above here:
> + if(m_bShoutcastSupportOnly)
> + {
> + m_LastError = HXR_NOT_SUPPORTED;
> + }
that explains what this is for (that some implementations
only want to use httpfsys for Shoutcast support, and
want to fail out on all other cases).
Eric
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: Praveen.Thimmashetty@nokia.com
> [mailto:Praveen.Thimmashetty@nokia.com]
> Sent: Monday, April 21, 2008 4:29 PM
> To: ehyche@real.com; filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to
> enable/disable non-shoutcasthttp playback
>
> Hi Eric,
>
> Looks like my previous changes to this Httpfsys.cpp has been
> backed out
> by ping.
> Somehow diff didn't catch that.
>
> Please find the updated diff below.
>
> Thanks
> Praveen
>
> Index: R1_Mobile_4_0_Factory.cfg
> ===================================================================
> RCS file:
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> retrieving revision 1.44
> diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg @@ -22,6 +22,7 @@
> HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> +HTTPShoutcastSupportOnly=1
> LocalMediaFolder=c:\nokia\videos\
> LogSink=console
> LoopMode=0
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.121
> diff -w -u -b -r1.121 httpfsys.cpp
> @@ -1132,6 +1132,7 @@
> , m_ulIgnoreBytesYetToBeDownloaded(0)
> , m_ulLastHeaderSize(0)
> , m_bDiscardOrphanLFInChunkedData(FALSE)
> + , m_bShoutcastSupportOnly(FALSE)
> /*************************/
> {
> SetSupportsByteRanges(m_bSupportsByteRanges);
> @@ -1281,6 +1282,7 @@
> pRegistry->Release();
> }
> }
> + ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
> m_bShoutcastSupportOnly);
>
> // if the language pref is an empty string, we're not
> // interested
> @@ -8222,6 +8224,13 @@
> m_bShoutcast = TRUE;
> m_ulMinStartupLengthNeeded =
> HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> }
> + else
> + {
> + if(m_bShoutcastSupportOnly)
> + {
> + m_LastError = HXR_NOT_SUPPORTED;
> + }
> + }
> }
>
> if ((ulLength > 4) && (ulLength >=
> m_ulMinStartupLengthNeeded))
> Index: httpfsys.h
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> retrieving revision 1.43
> diff -w -u -b -r1.43 httpfsys.h
> @@ -957,6 +957,7 @@
>
> HXBOOL m_bHaltSocketReadTemporarily;
> ULONG32 m_ulMaxBufSize ;
> + HXBOOL m_bShoutcastSupportOnly;
> };
>
> class HTTPTCPResponse : public CUnknownIMP,
>
>
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehyche@real.com]
> Sent: Monday, April 21, 2008 2:47 PM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
>
> I'm not finding any existing line in httpfsys.cpp on the HEAD which
> looks like this:
>
> -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
>
> so I can't really tell where in the code this is changing.
>
> Eric
>
> =============================================
> Eric Hyche (ehyche@real.com)
> Technical Lead
> RealNetworks, Inc.
>
> > -----Original Message-----
> > From: Praveen.Thimmashetty@nokia.com
> > [mailto:Praveen.Thimmashetty@nokia.com]
> > Sent: Monday, April 21, 2008 3:36 PM
> > To: ehyche@real.com; filesystem-dev@helixcommunity.org;
> ping@real.com
> > Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> > non-shoutcasthttp playback
> >
> > Hi Eric,
> >
> > Please find the diff for branch HEAD.
> > Do I have to commit this change to 310Atlas?
> >
> > Thanks
> > Praveen
> >
> > Index: R1_Mobile_4_0_Factory.cfg
> > ===================================================================
> > RCS file:
> > /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> > retrieving revision 1.44
> > diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg @@ -22,6 +22,7 @@
> > HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> > +HTTPShoutcastSupportOnly=1
> > LocalMediaFolder=c:\nokia\videos\
> > LogSink=console
> > LoopMode=0
> >
> > Index: httpfsys.cpp
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> > retrieving revision 1.120
> > diff -w -u -b -r1.120 httpfsys.cpp
> > @@ -1132,6 +1132,7 @@
> > , m_ulIgnoreBytesYetToBeDownloaded(0)
> > , m_ulLastHeaderSize(0)
> > , m_bDiscardOrphanLFInChunkedData(FALSE)
> > + , m_bShoutcastSupportOnly(FALSE)
> > /*************************/
> > {
> > SetSupportsByteRanges(m_bSupportsByteRanges);
> > @@ -1281,6 +1282,7 @@
> > pRegistry->Release();
> > }
> > }
> > + ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
> > m_bShoutcastSupportOnly);
> >
> > // if the language pref is an empty string, we're not
> > // interested
> > @@ -8224,9 +8226,10 @@
> > }
> > else
> > {
> > -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> > + if(m_bShoutcastSupportOnly)
> > + {
> > m_LastError = HXR_NOT_SUPPORTED; -#endif
> > + }
> > }
> > }
> >
> > Index: httpfsys.h
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> > retrieving revision 1.43
> > diff -w -u -b -r1.43 httpfsys.h
> > @@ -957,6 +957,7 @@
> >
> > HXBOOL m_bHaltSocketReadTemporarily;
> > ULONG32 m_ulMaxBufSize ;
> > + HXBOOL m_bShoutcastSupportOnly;
> > };
> >
> > class HTTPTCPResponse : public CUnknownIMP,
> >
> >
> > -----Original Message-----
> > From: ext Eric Hyche [mailto:ehyche@real.com]
> > Sent: Monday, April 21, 2008 2:15 PM
> > To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> > filesystem-dev@helixcommunity.org; ping@real.com
> > Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> > non-shoutcasthttp playback
> >
> >
> > Praveen,
> >
> > The diff you provided for httpfsys was apparently from 210Cays. Can
> > you provide a diff from the HEAD as well, since this change is also
> > targeted for HEAD?
> >
> > Thanks,
> >
> > Eric
> >
> > =============================================
> > Eric Hyche (ehyche@real.com)
> > Technical Lead
> > RealNetworks, Inc.
> >
> > > -----Original Message-----
> > > From: filesystem-dev-bounces@helixcommunity.org
> > > [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> > > Praveen.Thimmashetty@nokia.com
> > > Sent: Monday, April 21, 2008 2:59 PM
> > > To: filesystem-dev@helixcommunity.org; ping@real.com
> > > Subject: [Filesystem-dev] CR: Config option to enable/disable
> > > non-shoutcasthttp playback
> > >
> > >
> > > "Nokia submits this code under the terms of a commercial
> > contribution
> > > agreement with RealNetworks, and I am authorized to
> contribute this
> > > code under said agreement."
> > >
> > >
> > > Modified by: praveen.thimmashetty@nokia.com
> > >
> > > Reviewed by:
> > >
> > > Date: 04/21/2008
> > >
> > > Project: SymbianMmf
> > >
> > > ErrorId: PTHY-7DWLHK
> > >
> > > Synopsis: Config option to enable/disable non-shoutcast
> > http playback
> > >
> > > Config option to enable/disable non-shoutcast http playback
> > support is
> >
> > > added. Currently HTTPFileSys on 210Cays Supports shoutcast
> > stream only
> >
> > > for symbian platform.
> > >
> > > Root Cause of the problem: implementation
> > >
> > >
> > > Files Modified:
> > > clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
> > > filesystem/http/httpfsys.cpp
> > > filesystem/http/httpfsys.h
> > >
> > > Files Added: None
> > >
> > >
> > > Image Size and Heap Use impact: None
> > >
> > > Module Release testing (STIF) : Done.
> > >
> > > Test case(s) Added : N/A
> > >
> > > Memory leak check performed : yes. No leak.
> > >
> > > Platforms and Profiles Build Verified:
> > > helix-client-s60-50-mmf-mdf-arm
> > >
> > > Platforms and Profiles Functionality verified: armv5, winscw
> > >
> > > Branch: Head & 210CayS
> > >
> > >
> > > Index: R1_Mobile_4_0_Factory.cfg
> > >
> ===================================================================
> > > RCS file:
> > >
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> > > retrieving revision 1.26.2.23
> > > diff -w -u -b -r1.26.2.23 R1_Mobile_4_0_Factory.cfg @@
> > -22,6 +22,7 @@
> >
> > > HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> > > +HTTPShoutcastSupportOnly=1
> > > LocalMediaFolder=c:\nokia\videos\
> > > LogSink=console
> > > LoopMode=0
> > >
> > > Index: httpfsys.cpp
> > >
> ===================================================================
> > > RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> > > retrieving revision 1.88.2.8
> > > diff -w -u -b -r1.88.2.8 httpfsys.cpp @@ -1130,6 +1130,7 @@
> > > , m_ulIgnoreBytesYetToBeDownloaded(0)
> > > , m_ulLastHeaderSize(0)
> > > , m_bDiscardOrphanLFInChunkedData(FALSE)
> > > + , m_bShoutcastSupportOnly(FALSE)
> > > /*************************/
> > > {
> > > SetSupportsByteRanges(m_bSupportsByteRanges);
> > > @@ -1283,6 +1284,7 @@
> > > pRegistry->Release();
> > > }
> > > }
> > > + ReadPrefBOOL(m_pPreferences,
> > > "HTTPShoutcastSupportOnly", m_bShoutcastSupportOnly);
> > >
> > > // if the language pref is an empty string, we're not
> > > // interested
> > > @@ -8228,9 +8230,10 @@
> > > }
> > > else
> > > {
> > > -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> > > + if(m_bShoutcastSupportOnly)
> > > + {
> > > m_LastError = HXR_NOT_SUPPORTED;
> > > -#endif
> > > + }
> > > }
> > > }
> > >
> > > Index: httpfsys.h
> > >
> ===================================================================
> > > RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> > > retrieving revision 1.34.2.2
> > > diff -w -u -b -r1.34.2.2 httpfsys.h
> > > @@ -955,6 +955,7 @@
> > >
> > > HXBOOL m_bHaltSocketReadTemporarily;
> > > ULONG32 m_ulMaxBufSize ;
> > > + HXBOOL m_bShoutcastSupportOnly;
> > > };
> > >
> > > class HTTPTCPResponse : public CUnknownIMP,
> > >
> > >
> > >
> >
>
From Praveen.Thimmashetty at nokia.com Mon Apr 21 14:52:12 2008
From: Praveen.Thimmashetty at nokia.com (Praveen.Thimmashetty@nokia.com)
Date: Mon Apr 21 13:47:11 2008
Subject: CN: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
In-Reply-To: <012001c8a3f3$7bf19730$db68a8c0@EHYCHED620>
References: <2A15C07EF7DF6243A092FB438FD4B3660105D2EA@daebe103.NOE.Nokia.com>
<00dd01c8a3e3$f2332180$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B3660105D313@daebe103.NOE.Nokia.com>
<00e801c8a3e8$78b0c510$db68a8c0@EHYCHED620>
<2A15C07EF7DF6243A092FB438FD4B3660105D352@daebe103.NOE.Nokia.com>
<012001c8a3f3$7bf19730$db68a8c0@EHYCHED620>
Message-ID: <2A15C07EF7DF6243A092FB438FD4B3660105D39C@daebe103.NOE.Nokia.com>
Thanks Eric.
I have added the comment and checked into HEAD and 210Cays.
Regards
Praveen
-----Original Message-----
From: ext Eric Hyche [mailto:ehyche@real.com]
Sent: Monday, April 21, 2008 4:06 PM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-dev@helixcommunity.org; ping@real.com
Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
non-shoutcasthttp playback
Looks good. Please add a comment right above here:
> + if(m_bShoutcastSupportOnly)
> + {
> + m_LastError = HXR_NOT_SUPPORTED;
> + }
that explains what this is for (that some implementations only want to
use httpfsys for Shoutcast support, and want to fail out on all other
cases).
Eric
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: Praveen.Thimmashetty@nokia.com
> [mailto:Praveen.Thimmashetty@nokia.com]
> Sent: Monday, April 21, 2008 4:29 PM
> To: ehyche@real.com; filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
> Hi Eric,
>
> Looks like my previous changes to this Httpfsys.cpp has been backed
> out by ping.
> Somehow diff didn't catch that.
>
> Please find the updated diff below.
>
> Thanks
> Praveen
>
> Index: R1_Mobile_4_0_Factory.cfg
> ===================================================================
> RCS file:
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> retrieving revision 1.44
> diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg @@ -22,6 +22,7 @@
> HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> +HTTPShoutcastSupportOnly=1
> LocalMediaFolder=c:\nokia\videos\
> LogSink=console
> LoopMode=0
>
> Index: httpfsys.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> retrieving revision 1.121
> diff -w -u -b -r1.121 httpfsys.cpp
> @@ -1132,6 +1132,7 @@
> , m_ulIgnoreBytesYetToBeDownloaded(0)
> , m_ulLastHeaderSize(0)
> , m_bDiscardOrphanLFInChunkedData(FALSE)
> + , m_bShoutcastSupportOnly(FALSE)
> /*************************/
> {
> SetSupportsByteRanges(m_bSupportsByteRanges);
> @@ -1281,6 +1282,7 @@
> pRegistry->Release();
> }
> }
> + ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
> m_bShoutcastSupportOnly);
>
> // if the language pref is an empty string, we're not
> // interested
> @@ -8222,6 +8224,13 @@
> m_bShoutcast = TRUE;
> m_ulMinStartupLengthNeeded =
> HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED;
> }
> + else
> + {
> + if(m_bShoutcastSupportOnly)
> + {
> + m_LastError = HXR_NOT_SUPPORTED;
> + }
> + }
> }
>
> if ((ulLength > 4) && (ulLength >=
> m_ulMinStartupLengthNeeded))
> Index: httpfsys.h
> ===================================================================
> RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> retrieving revision 1.43
> diff -w -u -b -r1.43 httpfsys.h
> @@ -957,6 +957,7 @@
>
> HXBOOL m_bHaltSocketReadTemporarily;
> ULONG32 m_ulMaxBufSize ;
> + HXBOOL m_bShoutcastSupportOnly;
> };
>
> class HTTPTCPResponse : public CUnknownIMP,
>
>
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehyche@real.com]
> Sent: Monday, April 21, 2008 2:47 PM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> filesystem-dev@helixcommunity.org; ping@real.com
> Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> non-shoutcasthttp playback
>
>
> I'm not finding any existing line in httpfsys.cpp on the HEAD which
> looks like this:
>
> -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
>
> so I can't really tell where in the code this is changing.
>
> Eric
>
> =============================================
> Eric Hyche (ehyche@real.com)
> Technical Lead
> RealNetworks, Inc.
>
> > -----Original Message-----
> > From: Praveen.Thimmashetty@nokia.com
> > [mailto:Praveen.Thimmashetty@nokia.com]
> > Sent: Monday, April 21, 2008 3:36 PM
> > To: ehyche@real.com; filesystem-dev@helixcommunity.org;
> ping@real.com
> > Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> > non-shoutcasthttp playback
> >
> > Hi Eric,
> >
> > Please find the diff for branch HEAD.
> > Do I have to commit this change to 310Atlas?
> >
> > Thanks
> > Praveen
> >
> > Index: R1_Mobile_4_0_Factory.cfg
> > ===================================================================
> > RCS file:
> > /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> > retrieving revision 1.44
> > diff -w -u -b -r1.44 R1_Mobile_4_0_Factory.cfg @@ -22,6 +22,7 @@
> > HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> > +HTTPShoutcastSupportOnly=1
> > LocalMediaFolder=c:\nokia\videos\
> > LogSink=console
> > LoopMode=0
> >
> > Index: httpfsys.cpp
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> > retrieving revision 1.120
> > diff -w -u -b -r1.120 httpfsys.cpp
> > @@ -1132,6 +1132,7 @@
> > , m_ulIgnoreBytesYetToBeDownloaded(0)
> > , m_ulLastHeaderSize(0)
> > , m_bDiscardOrphanLFInChunkedData(FALSE)
> > + , m_bShoutcastSupportOnly(FALSE)
> > /*************************/
> > {
> > SetSupportsByteRanges(m_bSupportsByteRanges);
> > @@ -1281,6 +1282,7 @@
> > pRegistry->Release();
> > }
> > }
> > + ReadPrefBOOL(m_pPreferences, "HTTPShoutcastSupportOnly",
> > m_bShoutcastSupportOnly);
> >
> > // if the language pref is an empty string, we're not
> > // interested
> > @@ -8224,9 +8226,10 @@
> > }
> > else
> > {
> > -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> > + if(m_bShoutcastSupportOnly)
> > + {
> > m_LastError = HXR_NOT_SUPPORTED; -#endif
> > + }
> > }
> > }
> >
> > Index: httpfsys.h
> > ===================================================================
> > RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> > retrieving revision 1.43
> > diff -w -u -b -r1.43 httpfsys.h
> > @@ -957,6 +957,7 @@
> >
> > HXBOOL m_bHaltSocketReadTemporarily;
> > ULONG32 m_ulMaxBufSize ;
> > + HXBOOL m_bShoutcastSupportOnly;
> > };
> >
> > class HTTPTCPResponse : public CUnknownIMP,
> >
> >
> > -----Original Message-----
> > From: ext Eric Hyche [mailto:ehyche@real.com]
> > Sent: Monday, April 21, 2008 2:15 PM
> > To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> > filesystem-dev@helixcommunity.org; ping@real.com
> > Subject: RE: [Filesystem-dev] CR: Config option to enable/disable
> > non-shoutcasthttp playback
> >
> >
> > Praveen,
> >
> > The diff you provided for httpfsys was apparently from 210Cays. Can
> > you provide a diff from the HEAD as well, since this change is also
> > targeted for HEAD?
> >
> > Thanks,
> >
> > Eric
> >
> > =============================================
> > Eric Hyche (ehyche@real.com)
> > Technical Lead
> > RealNetworks, Inc.
> >
> > > -----Original Message-----
> > > From: filesystem-dev-bounces@helixcommunity.org
> > > [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf Of
> > > Praveen.Thimmashetty@nokia.com
> > > Sent: Monday, April 21, 2008 2:59 PM
> > > To: filesystem-dev@helixcommunity.org; ping@real.com
> > > Subject: [Filesystem-dev] CR: Config option to enable/disable
> > > non-shoutcasthttp playback
> > >
> > >
> > > "Nokia submits this code under the terms of a commercial
> > contribution
> > > agreement with RealNetworks, and I am authorized to
> contribute this
> > > code under said agreement."
> > >
> > >
> > > Modified by: praveen.thimmashetty@nokia.com
> > >
> > > Reviewed by:
> > >
> > > Date: 04/21/2008
> > >
> > > Project: SymbianMmf
> > >
> > > ErrorId: PTHY-7DWLHK
> > >
> > > Synopsis: Config option to enable/disable non-shoutcast
> > http playback
> > >
> > > Config option to enable/disable non-shoutcast http playback
> > support is
> >
> > > added. Currently HTTPFileSys on 210Cays Supports shoutcast
> > stream only
> >
> > > for symbian platform.
> > >
> > > Root Cause of the problem: implementation
> > >
> > >
> > > Files Modified:
> > > clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
> > > filesystem/http/httpfsys.cpp
> > > filesystem/http/httpfsys.h
> > >
> > > Files Added: None
> > >
> > >
> > > Image Size and Heap Use impact: None
> > >
> > > Module Release testing (STIF) : Done.
> > >
> > > Test case(s) Added : N/A
> > >
> > > Memory leak check performed : yes. No leak.
> > >
> > > Platforms and Profiles Build Verified:
> > > helix-client-s60-50-mmf-mdf-arm
> > >
> > > Platforms and Profiles Functionality verified: armv5, winscw
> > >
> > > Branch: Head & 210CayS
> > >
> > >
> > > Index: R1_Mobile_4_0_Factory.cfg
> > >
> ===================================================================
> > > RCS file:
> > >
> /cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg,v
> > > retrieving revision 1.26.2.23
> > > diff -w -u -b -r1.26.2.23 R1_Mobile_4_0_Factory.cfg @@
> > -22,6 +22,7 @@
> >
> > > HTTPProxyHost= HTTPProxyPort=80 HTTPProxySupport=0
> > > +HTTPShoutcastSupportOnly=1
> > > LocalMediaFolder=c:\nokia\videos\ LogSink=console LoopMode=0
> > >
> > > Index: httpfsys.cpp
> > >
> ===================================================================
> > > RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
> > > retrieving revision 1.88.2.8
> > > diff -w -u -b -r1.88.2.8 httpfsys.cpp @@ -1130,6 +1130,7 @@
> > > , m_ulIgnoreBytesYetToBeDownloaded(0)
> > > , m_ulLastHeaderSize(0)
> > > , m_bDiscardOrphanLFInChunkedData(FALSE)
> > > + , m_bShoutcastSupportOnly(FALSE)
> > > /*************************/
> > > {
> > > SetSupportsByteRanges(m_bSupportsByteRanges);
> > > @@ -1283,6 +1284,7 @@
> > > pRegistry->Release();
> > > }
> > > }
> > > + ReadPrefBOOL(m_pPreferences,
> > > "HTTPShoutcastSupportOnly", m_bShoutcastSupportOnly);
> > >
> > > // if the language pref is an empty string, we're not
> > > // interested
> > > @@ -8228,9 +8230,10 @@
> > > }
> > > else
> > > {
> > > -#if !defined(HELIX_FEATURE_HTTP_ENABLE_CACHE)
> > > + if(m_bShoutcastSupportOnly)
> > > + {
> > > m_LastError = HXR_NOT_SUPPORTED;
> > > -#endif
> > > + }
> > > }
> > > }
> > >
> > > Index: httpfsys.h
> > >
> ===================================================================
> > > RCS file: /cvsroot/filesystem/http/httpfsys.h,v
> > > retrieving revision 1.34.2.2
> > > diff -w -u -b -r1.34.2.2 httpfsys.h @@ -955,6 +955,7 @@
> > >
> > > HXBOOL m_bHaltSocketReadTemporarily;
> > > ULONG32 m_ulMaxBufSize ;
> > > + HXBOOL m_bShoutcastSupportOnly;
> > > };
> > >
> > > class HTTPTCPResponse : public CUnknownIMP,
> > >
> > >
> > >
> >
>
Copyright © 1995-2007 RealNetworks, Inc. All rights reserved.
RealNetworks and Helix are trademarks of RealNetworks.
All other trademarks or registered trademarks are the property of their respective holders.