From gwright at real.com  Tue Sep  4 13:01:04 2007
From: gwright at real.com (Greg Wright)
Date: Tue Sep  4 13:49:36 2007
Subject: [Filesystem-dev] Re: [Clientapps-dev] CR: Fix to distinguish user
 forced stop and
 normal	playback complete(clip played till the end) for Enhanced	media client
 case in helix audio controller
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B36654024B@daebe103.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B36654021E@daebe103.NOE.Nokia.com>	<60A427E0B02CC34B98D22BDCAA25361204A297AC@daebe101.NOE.Nokia.com>
	<2A15C07EF7DF6243A092FB438FD4B36654024B@daebe103.NOE.Nokia.com>
Message-ID: <46DDB980.9050502@real.com>

Looks good.
--greg.

Praveen.Thimmashetty@nokia.com wrote:
>> "Nokia submits this code under the terms of a commercial contribution
>> agreement with RealNetworks, and I am authorized to contribute this
>> code under said agreement."
>>
>> Modified by:  Praveen.Thimmashetty@nokia.com
>>
>> Reviewed by: 
>>
>> Date: 31-August-2007
>>
>> Project: SymbianMmf
>>
>>       ErrorId: TBD
>>             
>> Synopsis:  CR: Fix to distinguish user forced stop and normal playback
>> complete (clip played till the end) for Enhanced media client case in
>> helix audio controller.
>>
>> There is a need to distinguish user forced stop and normal playback
>> complete (clip played till the end) for Enhanced media client case in
>> helix audio controller.
>> Enhanced media client wants to perform certain set of functions based
>> on these distinction.
>>
>> When stop is called by EMC, since helix audio controller treat it as
>> pause to engine, we get a paused event from engine. 
>> We need to have necessary check during on pause event from engine at
>> helix controller level, to return appropriate event to EMC.
>> If pause was called due to user forced stop, then we have to return
>> Stopped event back to EMC. 
>>
>> Whenever seek call on Multimedia Data Source fails, method has to
>> leave with error code that received from Multimedia Data Source.  
>>
>> Updated ReadDone method, to fix multiple release of the same buffer on
>> error case in minifileobj.cpp.
>>
>> Root Cause of the problem: Implementation
>>  
>> Files Modified:
>> clientapps/symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
>> clientapps/symbianMmf/common/hxmmfbasectrl.cpp
>> clientapps/symbianMmf/common/hxmmfbasectrl.h
>> common/fileio/platform/symbian/HxMMDataSource.cpp
>> filesystem/local/mini/minifileobj.cpp
>>
>> Image Size and Heap Use impact: no major impact
>>
>> Module Release testing (STIF) :  Passed.
>>
>> Test case(s) Added  :  No. 
>>
>> Memory leak check performed : Yes.  No new leaks introduced. 
>>
>> Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-arm
>>
>> Platforms and Profiles Functionality verified: armv5,winscw
>>
>>       Branch: Head & 210CayS
>>  <> 
>>
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Clientapps-dev mailing list
> Clientapps-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/clientapps-dev

From ehyche at real.com  Mon Sep 10 06:51:54 2007
From: ehyche at real.com (Eric Hyche)
Date: Mon Sep 10 06:42:19 2007
Subject: [Filesystem-dev] RE: [Common-dev] CR: Fix to distinguish user
	forced stop and normalplayback complete(clip played till the
	end) for Enhancedmedia client case in helix audio controller
In-Reply-To: <2A15C07EF7DF6243A092FB438FD4B36654024B@daebe103.NOE.Nokia.com>
References: <2A15C07EF7DF6243A092FB438FD4B36654021E@daebe103.NOE.Nokia.com><60A427E0B02CC34B98D22BDCAA25361204A297AC@daebe101.NOE.Nokia.com>
	<2A15C07EF7DF6243A092FB438FD4B36654024B@daebe103.NOE.Nokia.com>
Message-ID: <009401c7f3b1$c01ac7d0$db68a8c0@EHYCHED620>

Looks good.

=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: common-dev-bounces@helixcommunity.org 
> [mailto:common-dev-bounces@helixcommunity.org] On Behalf Of 
> Praveen.Thimmashetty@nokia.com
> Sent: Friday, August 31, 2007 7:02 PM
> To: clientapps-dev@helixcommunity.org; 
> common-dev@helixcommunity.org; filesystem-dev@helixcommunity.org
> Subject: [Common-dev] CR: Fix to distinguish user forced stop 
> and normalplayback complete(clip played till the end) for 
> Enhancedmedia client case in helix audio controller
> 
> 
> "Nokia submits this code under the terms of a commercial 
> contribution agreement with RealNetworks, and I am authorized 
> to contribute this code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashetty@nokia.com 
> 
> 	Reviewed by: 
> 
> 	Date: 31-August-2007 
> 
> 	Project: SymbianMmf 
> 
>       ErrorId: TBD 
> 
> 	            
> 	Synopsis:  CR: Fix to distinguish user forced stop and 
> normal playback complete (clip played till the end) for 
> Enhanced media client case in helix audio controller.
> 
> 	There is a need to distinguish user forced stop and 
> normal playback complete (clip played till the end) for 
> Enhanced media client case in helix audio controller.
> 
> 	Enhanced media client wants to perform certain set of 
> functions based on these distinction. 
> 
> 	When stop is called by EMC, since helix audio 
> controller treat it as pause to engine, we get a paused event 
> from engine. 
> 
> 	We need to have necessary check during on pause event 
> from engine at helix controller level, to return appropriate 
> event to EMC.
> 
> 	If pause was called due to user forced stop, then we 
> have to return Stopped event back to EMC. 
> 
> 	Whenever seek call on Multimedia Data Source fails, 
> method has to leave with error code that received from 
> Multimedia Data Source.  
> 
> 	Updated ReadDone method, to fix multiple release of the 
> same buffer on error case in minifileobj.cpp. 
> 
> 	Root Cause of the problem: Implementation 
> 	  
> 	Files Modified: 
> 	clientapps/symbianMmf/audiocontroller/hxmmfaudioctrl.cpp 
> 	clientapps/symbianMmf/common/hxmmfbasectrl.cpp 
> 	clientapps/symbianMmf/common/hxmmfbasectrl.h 
> 	common/fileio/platform/symbian/HxMMDataSource.cpp 
> 	filesystem/local/mini/minifileobj.cpp 
> 
> 	Image Size and Heap Use impact: no major impact 
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-32-mmf-mdf-arm 
> 
> 	Platforms and Profiles Functionality verified: armv5,winscw 
> 
>       Branch: Head & 210CayS 
> <> 
> 
> 