Looks good.

Qiang

On 2/9/2011 9:15 PM, Chandra Bhushan Kumar wrote:
> "Nokia submits this code under the terms of a commercial contribution 
> agreement with Real Networks, and I am authorized to contribute this 
> code under said agreement."
> Modified by: ext-chandra.2.kumar at nokia.com 
> <mailto:ext-chandra.2.kumar at nokia.com>
> Reviewed by: Shetty Girish [girish.shetty at nokia.com]
> RC Id: ou1cimx1#665266
> Date: 02/10/2011
> Project: SymbianMmf_wm
> Synopsis: A clip (tiger.mp4) an incorrect file. On playing from videos 
> application pop-up note displays: "General error: System failure".
> Overview: As file has incomplete header and track information it is 
> failing during track initialization. Upon track initialization if no 
> active stream found it returns HXR_FAIL. This status is being passed 
> to MakeFileHeader and report this failure status to HXPlayer module. 
> It's propagated and mapped to error as -2(General Error) in 
> HXMMFBaseCtrl and sent to upper layer.
> Fix: Instead of returning HXR_FAIL if no active streams found, 
> HXR_CORRUPT_FILE is returned. This is mapped as -20 and the 
> information note displays "Unable to play media clip".
> Files modified & changes:
> /cvsroot/datatype/mp4/fileformat/qttrkmgr.cpp
> Image Size and Heap Use impact: No major impact
> Module Release testing (STIF) : Passed
> Test case(s) Added : No
> Memory leak check performed : Yes
> Platforms and profiles build verified:  helix-client-symbian-4
> Platforms and Profiles Functionality verified: armv5
> Branch: 420 brizo, Head
> Diff:
> Index: qttrkmgr.cpp
> ===================================================================
> RCS file: /cvsroot/datatype/mp4/fileformat/qttrkmgr.cpp,v
> retrieving revision 1.24
> diff -u -w -r1.24 qttrkmgr.cpp
> --- qttrkmgr.cpp 27 Apr 2009 17:05:25 -0000 1.24
> +++ qttrkmgr.cpp 5 Feb 2011 14:18:17 -0000
> @@ -1003,7 +1003,7 @@
>
>      UINT16 uActiveStreamCount = GetNumActiveStreams();
>
> -    retVal = (uActiveStreamCount == 0) ? HXR_FAIL : HXR_OK;
> +    retVal = (uActiveStreamCount == 0) ? HXR_CORRUPT_FILE : HXR_OK;
>
>      if (SUCCEEDED(retVal) &&
>   (uActiveStreamCount != m_uNumStreams))

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/datatype-dev/attachments/20110210/6271bc1e/attachment.html