If you want to check pBuffer it should be an HX_ASSERT and will need to be done earlier since the CreateInstance(...) call would blow up. No one should be calling this method with pBuffer set to NULL. The check is to verify the returned buffer.

STDMETHODIMP CHXMiniFileObject::AllocateReadBuffer(UINT32 byteCount, IHXBuffer** pBuffer)

Cheers,
Barry.

From: ext Qiang Luo [mailto:qluo at real.com]
Sent: 04 December 2011 21:43
To: Alcock Barry (EXT-Accenture/London)
Cc: nokia-private-dev-bounces at helixcommunity.org; datatype-dev at helixcommunity.org
Subject: Re: [datatype-dev] CR: ou1cimx1#910399: [mcl] AVI file format has memory leak in certain seek scenarios

-    if(pBuffer != NULL)
+    if(*pBuffer != NULL)
You may consider changing  above to if(pBuffer != NULL && *pBuffer != NULL) just to be safe.

I didn't see any diff about filesystem/local/mini/minifileobj.cpp.
You should also try to produce the diff against public helix cvs repository instead using nokia internal servers.

Qiang

On 11/30/2011 9:01 AM, ext-barry.2.alcock at nokia.com<mailto:ext-barry.2.alcock at nokia.com> wrote:
Requesting community review for this change:


"Nokia submits this code under the terms of a commercial contribution agreement with Real Networks, and I am authorized to contribute this code under said agreement."

Modified by: ext-barry.alcock at nokia.com<mailto:ext-barry.alcock at nokia.com>

Reviewed by:   ext-stephen.lilly at nokia.com<mailto:ext-stephen.lilly at nokia.com>

RC Id: ou1cimx1#910399

Date: 30/11/2011

Project: SymbianMmf_wm

Synopsis:
 Case 910399: [mcl] AVI file format has memory leak in certain seek scenarios

Overview:
References leaked during file format validation testing,

Fix:
Release references in destructors.



 File modified & changes:

datatype/avi/fileformat/avistrm.cpp

filesystem/local/mini/minifileobj.cpp



Image Size and Heap Use impact: No Major impact

Module Release testing (STIF) : Passed

Test case(s) Added : No

Memory leak check performed : No Leaks

Platforms and Profiles Functionality verified: armv5

Branch: 420 Brizo

Diff: Attached



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/datatype-dev/attachments/20111205/4d06f684/attachment-0001.html