[datatype-dev] CR: Bug 14283: The AVI file has no thumbnial and can't be played
Joe Li Joeli at realnetworks.comSorry, diff updated. thanks Joe -----Original Message----- From: Joe Li Sent: Thursday, December 22, 2011 12:15 PM To: Qiang Luo Cc: filesystem-dev at helixcommunity.org; datatype-dev at helixcommunity.org Subject: RE: [datatype-dev] CR: Bug 14283: The AVI file has no thumbnial and can't be played Thanks Qiang Update the diff as your advice. Check the "/../" as the directory level. thanks Joe -----Original Message----- From: Qiang Luo Sent: Thursday, December 22, 2011 2:29 AM To: Joe Li Cc: Qiang Luo; filesystem-dev at helixcommunity.org; datatype-dev at helixcommunity.org Subject: Re: [datatype-dev] CR: Bug 14283: The AVI file has no thumbnial and can't be played Looping filesystem-dev mailing list for filesystem issue. Joe, The purpose of the code block that you are removing is to guard against invalid path like "/dir1/dir2/../../../file.ext". To prevent false positive for files with names such as "name1....name2.ext", you should fix the code to check for "../" instead of for ".." in order to count for a directory level. Please also fix the potential pPath buffer overrun issue in that code block. Qiang -------------- next part -------------- A non-text attachment was scrubbed... Name: smplfsys.cpp.diff Type: application/octet-stream Size: 821 bytes Desc: smplfsys.cpp.diff Url : http://lists.helixcommunity.org/pipermail/datatype-dev/attachments/20111221/284b31c6/smplfsys.cpp-0001.obj