Why don't we need this here? The purpose of this function
is to skip past the other boxes that could be present and
only pass the avcC box in the opaque data. If that is removed,
content with other boxes in the avc1 sample description (other
than avcC) will fail.

Eric

=======================================
Eric Hyche (ehyche at real.com)
Principal Engineer
RealNetworks, Inc.


>-----Original Message-----
>From: datatype-dev-bounces at helixcommunity.org [mailto:datatype-dev-bounces at helixcommunity.org] On
>Behalf Of Sushant Grag
>Sent: Tuesday, September 22, 2009 6:00 AM
>To: Datatype-Dev
>Subject: [datatype-dev] CR/CN: Fix for bug 9462: Player crashes with Segmentation fault while playing
>some of h264 content
>
>Synopsis:
>Fix for bug 9462: Player crashes with Segmentation fault while playing some of h264 content
>
>Overview:
>Fix for bug 9462: Player crashes with Segmentation fault while playing some of h264 content.
>
>Remove SkipToAvcC call from case QT_vide in INitNonHinted function. Mistakenly added while fixing bug
>9414.
>We don't need this here, this call leads to crash with some of H264 content.
>
>Files Added:
>None
>
>Files Modified:
>
>Image Size and Heap Use impact (Client -Only):
>None.
>
>Platforms and Profiles Affected:
>None
>
>Distribution Libraries Affected:
>None
>
>Distribution library impact and planned action:
>None
>
>Platforms and Profiles Build Verified:
>BIF branch   ->realplay_gtk_atlas_restricted
>Target(s)      ->player_all
>Profile          ->helix-client-moblin
>SYSTEM_ID ->linux-2.2-libc6-gcc32-i586
>
>Branch
>Atlas310, Atlas347, Atlas349 & HEAD
>
>Index: qtatmmgs.cpp
>===================================================================
>RCS file: /cvsroot/datatype/mp4/fileformat/qtatmmgs.cpp,v
>retrieving revision 1.33.2.16.2.4
>diff -u -r1.33.2.16.2.4 qtatmmgs.cpp
>--- qtatmmgs.cpp 8 Sep 2009 04:00:41 -0000 1.33.2.16.2.4
>+++ qtatmmgs.cpp 22 Sep 2009 07:16:30 -0000
>@@ -2230,7 +2230,6 @@
>                   pSampleDescEntry)->pHeight));
>               m_pOpaqueData = ((CQT_stsd_Atom::VideoAVCArrayEntry*)
>               pSampleDescEntry)->pDecoderSpecificInfo;
>-              SkipToAvcC(m_pOpaqueData, ulSampleDescEntrySize);
>           }
>       }
>       break;