Hi, Gurpreet:

Two questions:

1.  If seeking, do you need to clean up the decoder's input/output buffer since decoding is not synchronous call any more?

2. 
// PV MP3 OMX Codec
#define COMPONENT_NAME_MP3 "OMX.PV.mp3dec" 

Does this mean this wrapper can only work with this specific mp3 decoder?

Thanks,

Junhong

 

-----Original Message-----
From: datatype-dev-bounces at helixcommunity.org [mailto:datatype-dev-bounces at helixcommunity.org] On Behalf Of ext Eric Hyche
Sent: Wednesday, March 04, 2009 7:07 AM
To: 'Gurpreet'; datatype-dev at helixcommunity.org
Subject: RE: [datatype-dev] [Resending: CR: Updated Omxwrapper for mp3 packet parser to use omx mp3 decoders on OMAP MDK]

Gurpreet,

My comments:

            default:
                usleep(100);

Why is this usleep() needed? Also, if this will ever be compiled on something other than Linux-based Android, then you might want to consider using the cross-platform microsleep().

+        if (m_pDecoder) 
+        {
+            m_pDecoder->SetTrustPackets(m_bTrustPackets);
+#ifdef HELIX_CONFIG_OMXCODEC
+		    m_pDecoder->SetContext(m_pClassFactory);	
+#endif
+        }

Seems like we could add the SetContext method to the non-OMX packet parser and not have to have this #ifdef here, even in the non-OMX packet parser didn't use it.

Also, VS7 complained about inconsistent line endings on all the new files in the .tar.gz you submitted. Please fix these line endings before checking in.

Rest looks good.

Eric

=======================================
Eric Hyche (ehyche at real.com)
Principal Engineer
RealNetworks, Inc.


>-----Original Message-----
>From: datatype-dev-bounces at helixcommunity.org 
>[mailto:datatype-dev-bounces at helixcommunity.org] On Behalf Of Gurpreet
>Sent: Tuesday, March 03, 2009 5:31 AM
>To: datatype-dev at helixcommunity.org
>Subject: [datatype-dev] [Resending: CR: Updated Omxwrapper for mp3 
>packet parser to use omx mp3 decoders on OMAP MDK]
>
>Resending for review.
>
>Best Regards,
>Gurpreet
>---------------------------- Original Message 
>----------------------------
>Subject: CR: Updated Omxwrapper for mp3 packet parser to use omx mp3 decoders on OMAP MDK
>From:    "Gurpreet" <gahluwalia at real.com>
>Date:    Tue, February 24, 2009 9:05 am
>To:      datatype-dev at helixcommunity.org
>-----------------------------------------------------------------------
>---
>
>Synopsis:
>Omxwrapper for mp3 packet parser to use omx mp3 decoders
>
>Overview:
>Omxwrapper for mp3 packet parser is based on mpa dec object.
>The decode calls are synchronized in mpadec existing code. But for omx, 
>decoder may take 1 or more buffers before giving a decoded buffer.
>
>Few Points:
>As decoded buffers are available in seperate queue.
>Time stamps are saved at present as uint32 rather then double in a list.
>
>Initialization parameters are not available in Init call, Its available 
>only after few buffers have been passed to decoder.
>Default values are used intially.
>
>Files Added:
>/datatype/mp3/codec/omxwrap/pub/mpadecobjomxwrp.h
>/datatype/mp3/codec/omxwrap/mpadecobj.cpp
>/datatype/mp3/codec/omxwrap/Umakefil
>
>Files Modified:
>datatype/mp3/codec/Umakefil
>datatype/mp3/codec/pub/mpadecobj.h
>datatype/mp3/payload/Umakefil
>datatype/mp3/payload/pktparse.cpp
>datatype/mp3/renderer/Umakefil
>datatype/mp3/renderer/plugin.cpp
>
>
>Image Size and Heap Use impact (Client -Only):
>None.
>
>Platforms and Profiles Affected:
>None
>
>Distribution Libraries Affected:
>None
>
>
>Platforms and Profiles Build Verified:
>BIF branch  hxclient_3_1_0_atlas
>Target      splay_mp3
>Profile     helix-client-android
>SYSTEM_ID   linux-2.2-libc6-gcc32-i586 & android-1.0-arm.eabi-generic
>
>Branch:
>hxclient_3_1_0_atlas
>
>Files Attached:
>mp3.txt
>omxwrap.tar.gz
>
>Thanks & Regards,
>Gurpreet


_______________________________________________
Datatype-dev mailing list
Datatype-dev at helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev