This looks good.

=======================================
Eric Hyche (ehyche at real.com)
Principal Engineer
RealNetworks, Inc.


>-----Original Message-----
>From: Alok Jain [mailto:alokj at real.com]
>Sent: Friday, September 12, 2008 6:36 AM
>To: ehyche at real.com; datatype-dev at helixcommunity.org
>Subject: Re: [datatype-dev] CR: Changes in MP4 Renderer to support FLV format
>
>Thanks Eric,
>       I modified the all file as you were mentioned.
>
>Thanks
>Alok
>
>
>----- Original Message -----
>From: "Eric Hyche" <ehyche at real.com>
>To: "'Alok Jain'" <alokj at real.com>; <datatype-dev at helixcommunity.org>
>Sent: Thursday, September 11, 2008 9:26 PM
>Subject: RE: [datatype-dev] CR: Changes in MP4 Renderer to support FLV format
>
>
>> Alok,
>>
>> Here are my comments:
>>
>> 1) License headers are incorrect on the two new files. The
>>   correct license header can be found here:
>>
>> http://asg-plone.dev.prognet.com/helix/moin.cgi/SourceFileHeaders#head
>> -793d4290d3c24c0fa63825229350b0e861b6b0fe
>>
>>   and for future reference, the page I use to find the
>>   license headers is here:
>>
>>   http://asg-plone.dev.prognet.com/helix/moin.cgi/SourceFileHeaders
>>
>> 2) flvpyld.h - looks good
>>
>> 3) flvpyld.cpp
>>   a) In destructor, use HX_RELEASE(m_pAllocator), since it does the same
>>      as the code that's currently there.
>>   b) In SetAllocator(), we should do a HX_RELEASE(m_pAllocator) before
>>      we assign a new value to m_pAllocator.
>>   c) In GetPacketTime, we should check for non-NULL pPacket
>>   d) In CreateHXCodecPacket, I don't actually see anywhere where
>>      the actual data in the pBuffer (the IHXPacket's IHXBuffer) ever
>> gets copied
>>      into pHXCodecData->data. The memory is allocated, but nothing
>>      ever gets copied into it.
>>
>> 4) In datatype/mp4/payload/Umakefil,
>>   a) We should not manually set
>> project.AddDefines("HELIX_FEATURE_VIDEO_CODEC_VP6").
>>      This should be set in the profile. So you may need to include
>>      a diff for adding this to the appropriate .pfi file in
>>      ribosome/build/umakepf.
>>
>> 5) datatype/mp4/video/renderer/libumakefil
>>   a) same comment as 4(a) above
>>
>> Rest looks good.
>>
>> Eric
>>
>> =======================================
>> Eric Hyche (ehyche at real.com)
>> Principal Engineer
>> RealNetworks, Inc.
>>
>>
>>>-----Original Message-----
>>>From: datatype-dev-bounces at helixcommunity.org
>>>[mailto:datatype-dev-bounces at helixcommunity.org] On Behalf Of Alok
>>>Jain
>>>Sent: Wednesday, September 10, 2008 9:03 AM
>>>To: datatype-dev at helixcommunity.org
>>>Subject: [datatype-dev] CR: Changes in MP4 Renderer to support FLV
>>>format
>>>
>>>
>>>Synopsis:
>>>
>>>MP4 video renderer modifications to support flv format.
>>>
>>>Overview:
>>>Changes done to support flv format. mp4 video renderer will look at
>>>the CodecID = HX_FLV_CODEC_ID  in the stream header and attempt to
>>>load the vp67 codec.
>>>
>>>
>>>Files Modified:
>>>/cvsroot/datatype/mp4/payload/Umakefil
>>>
>>>/cvsroot/datatype/mp4/video/renderer/libumakefil
>>>
>>>/cvsroot/datatype/mp4/video/renderer/mp4vdfmt.cpp
>>>
>>>/cvsroot/datatype/mp4/video/renderer/mp4video.cpp
>>>
>>>Files Added:
>>>/cvsroot/datatype/mp4/payload/flvpyld.cpp
>>>
>>>/cvsroot/datatype/mp4/payload/pub/ flvpyld.h
>>>
>>>
>>>
>>>Image Size and Heap Use impact (Client -Only):
>>>None.
>>>
>>>Platforms and Profiles Affected:
>>>None
>>>
>>>Distribution Libraries Affected:
>>>None.
>>>
>>>Distribution library impact and planned action:
>>>None.
>>>
>>>Platforms and Profiles Build Verified:
>>>    Profile: helix-client-all-defines
>>>
>>>    BIF branch: helix.bif
>>>    Target: splay
>>>
>>>Branch: HEAD
>>>
>>>
>>>Thanks & Regards
>>>
>>>Alok Jain
>>