Hayoung,

>I got it. Perhaps, did you check all updates?
>

I'm not sure what you mean. I looked at your
updated diff, and it looked fine. Is that what you mean?

>If so, I'll check in PNG file writer into HEAD and others into HEAD and 310Atlas.
>

Yes, please do.

Thanks,

Eric

=======================================
Eric Hyche (ehyche at real.com)
Principal Engineer
RealNetworks, Inc.


>-----Original Message-----
>From: 최하영(Hayoung Choi) [mailto:hayoung.choi at ap.real.com]
>Sent: Wednesday, September 10, 2008 7:48 PM
>To: ehyche at real.com; datatype-dev at lists.helixcommunity.org
>Cc: milko at real.com; hyoon at real.com
>Subject: RE: [datatype-dev] CR: Thumbnail Generation Improvement (for PNG)
>
>Eric,
>
>I got it. Perhaps, did you check all updates?
>
>If so, I'll check in PNG file writer into HEAD and others into HEAD and 310Atlas.
>
>Thanks,
>Hayoung
>
>________________________________
>
>From: Eric Hyche [mailto:ehyche at real.com]
>Sent: 2008-09-10 (수) 오후 10:07
>To: 최하영(Hayoung Choi); datatype-dev at lists.helixcommunity.org
>Cc: milko at real.com; hyoon at real.com
>Subject: RE: [datatype-dev] CR: Thumbnail Generation Improvement (for PNG)
>
>
>
>Hayoung,
>
>My answers to your questions inline below...
>
>=======================================
>Eric Hyche (ehyche at real.com)
>Principal Engineer
>RealNetworks, Inc.
>
>
>>
>>We should use MAXNUMIMAGEOUTPUTFILES_OPTION_NAME in both
>>places instead of using the string "MaximumImageOutputFiles"
>>in the SetPropertyULONG32.
>>==> [Hayoung] It seems that the other options also have been used the "string" in the
>>SetPropertyULONG32, not XXXX_OPTION_NAME value. So I used the string value to be consistent with
>them.
>>How do you think?
>>
>
>If it's the same literal string as the define, then
>we should use the define everywhere.
>
>>- Since we know we are going to be making changes to the PNG file writer
>>  after this initial checkin, then there's no need to initially branch
>>  the PNG file writer to 310Atlas. We can do that once we have finished
>>  adding everything we want. Adding it to just the HEAD is sufficient for now.
>>
>>==> [Hayoung] Do you mean that check in only PNG file writer codes first and check in the other
>>updates such as main.cpp.diff and ffdriver.cpp.diff later?
>>
>
>Sorry - I wasn't clear.
>
>For the new PNG writer: just check into HEAD only for now, because
>we know we are still going to be making further changes to it.
>Once we are done with all the changes we want to make, then
>we can branch it to 310Atlas.
>
>For changes to existing files: check in changes to HEAD and 310Atlas.
>
>Thanks,
>
>Eric
>
>
>
>
>