[datatype-dev] CR/CN-Client: wmvrender.so GetPluginInfo() was returning MPEG-4 Video Renderer
Daniel Yek dyek at real.comThis is now in 150Cay and HEAD. -------- Original Message -------- Date: Thu, 6 Sep 2007 08:42:22 -0400 From: Eric Hyche <ehyche at real.com> To: 'Daniel Yek' <dyek at real.com> Daniel, This change looks good for checkin. Eric ============================================= Eric Hyche (ehyche at real.com) Technical Lead RealNetworks, Inc. > -------- Original Message -------- > Date: Wed, 05 Sep 2007 16:27:00 -0700 > From: Daniel Yek <dyek at real.com> > > > Modified by: dyek at real.com > Date: 9/5/2007 > Project: RealPlayer > > Synopsis: wmvrender.so GetPluginInfo() was returning MPEG-4 > Video Renderer > > Overview: > wmvrender.so GetPluginInfo() was returning: > RealNetworks MPEG-4 Video Renderer Plugin > > This changes it to: > Helix Windows Media Video Renderer Plugin > > > Details Not Important For CR: > This is how players query and display plugins info. in the > About dialog box: > player/app/gtk/about.cpp > populate_copyrights_text_view() > { > nNumPlugins = pPlugin2Handler->GetNumOfPlugins2(); > > for(nIndex = 0; nIndex < nNumPlugins; nIndex++) > { > pPlugin2Handler->GetPluginInfo(nIndex, pPluginProps); > > retVal = pPluginProps->GetPropertyCString("Description", > pDescription); > > retVal = pPluginProps->GetPropertyCString("Copyright", > pCopyright); > > if(copyright && description) > { > g_string_append_printf(str, "%s:\n", description); > g_string_append_printf(str, "%s\n\n", copyright); > } > } > } > > > Files Modified: > datatype/wm/video/renderer/wmvrender.cpp > > > Image Size and Heap Use impact (Client -Only): > None. > > Platforms and Profiles Affected: > All > > Platforms and Profiles Build Verified: > Profile: helix_client_all_define > Platform: Fedora Core 6 > > Platforms and Profiles Functionality verified: > Profile: helix_client_all_define > Platform: Fedora Core 6 > > Branch: 150Cay, HEAD > > Copyright assignment: I am a RealNetworks employee. > > > Index: wmvrender.cpp =================================================================== RCS file: /cvsroot/datatype/wm/video/renderer/wmvrender.cpp,v retrieving revision 1.1.1.1.2.1 diff -u -w -r1.1.1.1.2.1 wmvrender.cpp --- wmvrender.cpp 25 Apr 2007 14:58:36 -0000 1.1.1.1.2.1 +++ wmvrender.cpp 5 Sep 2007 23:17:43 -0000 @@ -62,7 +62,7 @@ #endif #define HX_WMV_RENDERER_NAME "Windows Media Video" -const char* const CWMVideoRenderer::m_pszDescription = "RealNetworks MPEG-4 Video Renderer Plugin"; +const char* const CWMVideoRenderer::m_pszDescription = "Helix Windows Media Video Renderer Plugin"; const char* const CWMVideoRenderer::m_ppszStreamMimeTypes[] = {"video/x-hx-wmv", NULL};