[datatype-dev] [Client-dev] CR: Bandwidth Values from UI don't work for Engine

[datatype-dev] [Client-dev] CR: Bandwidth Values from UI don't work for Engine

Junhong.Liu at nokia.com Junhong.Liu at nokia.com
Tue Nov 28 08:46:10 PST 2006


"Nokia submits this code under the terms of a commercial contribution
agreement with Real Networks, and I am authorized to contribute this
code under said agreement."
 
Modified by: 
	Junhong.Liu at nokia.com
 
Reviewed by: 
 
Date: 11-28-2006. 

Error ID: EAVZ-6VQSB2

Project: Helix plugin for Symbian
 
Synopsis: Bandwidth Values from UI don't work for Engine
 
UI bandwidth setting has been changed to use MaxBandwidth from
SustainBandwidth. This CR is to remove the legacy code to match the UI's
change. 
 

Files Modified: 

client/netwksvc/platform/symbian/hxsymbianapman.cpp
 
Files Added: None. 
 
Image Size and Heap Use impact: None. 
 
Platforms and Profiles Build Verified: helix-client-s60-mmf-mdf-arm
 
Platforms and Profiles Functionality verified: armv5
 
Branch: HXCLIENT_2_1_0_CAYENNES, HEAD


? diff.txt
Index: hxsymbianapman.cpp
===================================================================
RCS file: /cvsroot/client/netwksvc/platform/symbian/hxsymbianapman.cpp,v
retrieving revision 1.7.2.7
diff -w -u -b -r1.7.2.7 hxsymbianapman.cpp
--- hxsymbianapman.cpp	17 Aug 2006 19:21:46 -0000	1.7.2.7
+++ hxsymbianapman.cpp	28 Nov 2006 16:06:53 -0000
@@ -784,24 +784,6 @@
     UINT32 maxBandwidth = 0;
     ReadPrefUINT32(m_pContext, maxBandwidthStr, maxBandwidth);
 
-#if 1
-    // Currently engine gets SustainBaandwidth=some value and
MaxBandwidth=0
-    // Engine was not handling SustainBandwidth and it doesn't need to.
-    // This temporary check has been added for the compatibility.
-    // This will be removed once client start sending the correct
value.
-
-    // Get the sustain bandwidth for the current bearer.
-    CHXString sustainBandwidthStr = pStrBearer;
-    sustainBandwidthStr += "SustainBandwidth";
-    UINT32 sustainBandwidth = 0;
-    ReadPrefUINT32(m_pContext, sustainBandwidthStr, sustainBandwidth);
-
-    if(maxBandwidth < sustainBandwidth)
-    {
-        maxBandwidth = sustainBandwidth;
-    }
-#endif
-
     // Set the maxBandwidth to current Bandwidth prefs.
     if(maxBandwidth != 0)
     {

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.helixcommunity.org/pipermail/datatype-dev/attachments/20061128/232209b0/attachment.html


More information about the Datatype-dev mailing list
 

Site Map   |   Terms of Use   |   Privacy Policy   |   Contact Us

Copyright © 1995-2007 RealNetworks, Inc. All rights reserved. RealNetworks and Helix are trademarks of RealNetworks.
All other trademarks or registered trademarks are the property of their respective holders.