Hi Eric,

Yes, you're right. I'm not sure why I felt inclined to include both.

Removed <stdlib.h> include; checked into HEAD and
hxclient_2_1_0_cayennes

Thanks for your prompt review.

BR,
 Carol.

-----Original Message-----
From: ext Eric Hyche [mailto:ehyche at real.com] 
Sent: Wednesday, November 08, 2006 8:01 AM
To: Chen Carol.I (Nokia-TP-MSW/Dallas); datatype-dev at helixcommunity.org
Subject: RE: [datatype-dev] CR-RESEND: Feature - Codec Selection
Configurability


Carol,

+#include "hlxclib/stdlib.h"  //itoa
+#include <stdlib.h>  //atol, strtoul

<stdlib.h> should be included by "hlxclib/stdlib.h". Is it not?

Rest looks good.

Eric

=============================================
Eric Hyche (ehyche at real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounces at helixcommunity.org
> [mailto:datatype-dev-bounces at helixcommunity.org] On Behalf Of 
> Carol.i.Chen at nokia.com
> Sent: Tuesday, November 07, 2006 10:52 PM
> To: datatype-dev at helixcommunity.org
> Subject: [datatype-dev] CR-RESEND: Feature - Codec Selection 
> Configurability
> 
> Hi,
> 
> One small change - line 544 of
> datatype_mdf_video_renderer1.diff should read: 
> +                    if( error == KErrNone )
> 
> instead of: 
> +                    if( error != KErrNone )
> 
> Could someone please kindly take a look at this CR at your earliest 
> convenience. There is basically no change in functionality if you 
> don't specify any rules in config file.
> 
> Thanks and best regards,
>  Carol. 
> 
> 
> ______________________________________________ 
> From:   Chen Carol.I (Nokia-TP-MSW/Dallas)  
> Sent:   Tuesday, November 07, 2006 3:05 PM 
> To:     datatype-dev at helixcommunity.org 
> Subject:        CR: Feature - Codec Selection Configurability 
> 
> "Nokia submits this code under the terms of a commercial contribution 
> agreement with RealNetworks, and I am authorized to contribute this 
> code under said agreement."
> 
> Modified by: 
>     carol.i.chen at nokia.com
> 
> Reviewed by: 
> 
> Date: 
>     11-07-2006
> 
> REQ ID: 
>     101-29167
> 
> Project: 
>     Helix plugin for Symbian
> 
> 
> Synopsis: 
> 
> **New Feature **
> 
> There can be multiple video decoder and post processor implementations

> for one single video standard in the platforms. Codec Selection 
> Configurability support will enable Helix to select specific 
> implementations based on a configuration mechanism.
> 
> On some platforms, there may be both hardware accelerated decoders as 
> well as software decoders. While it is convenient to use the 
> accelerated decoders for all video clips, that is not the most 
> resource efficient. This is due to the fact that hardware decoders can

> use considerably more power than the software counterparts. Therefore,

> Helix must introduce a mechanism to select a software decoder when 
> there is no need for a hardware decoder, such as for smaller picture 
> sizes or simpler profiles. This lets the product keep hardware 
> accelerators powered off unless required, saving battery in common use

> cases like network streaming and MMS playback.
> 
> Please refer to attached document for more details on how to specify 
> the rules for Codec Selection.
> 
> Note: if no codec rules are specified in the configuration file, the 
> behaviour remains unchanged.
> 
> (Also in Plugin Manager, change is made to search all valid 
> combinations of decoder-postprocessor to build the plugin archive. 
> This is needed for codec config to work. Currently the search stops 
> when it finds one valid combination.)
> 
> 
> Files Modified: 
>     datatype/mdf/video/format       (add methods to obtain 
> video profile and resolution)
>                                          
> /common/pub/mdfpayloadformat.h 
>                                          /common/mdfpayloadformat.cpp
>                                          
> /h263/pub/mdfh263payloadformat.h
>                                          
> /h263/mdfh263payloadformat.cpp
>                                          
> /h264/pub/mdfh264payloadformat.h
>                                          
> /h264/mdfh264payloadformat.cpp 
>                                          /h264/Umakefil
>                                          
> /mp4/pub/mdfmp4payloadformat.h 
>                                          /mp4/mdfmp4payloadformat.cpp 
>                                          /mp4/Umakefil
>                                          
> /rm/pub/mdfrvxpayloadformat.h 
>                                          /rm/mdfrvxpayloadformat.cpp 
>     datatype/mdf/video/renderer       (parse codec rules + 
> logic to config codec using rules) 
>                                             /pub/mdfpluginmanager.h 
>                                             /pub/mdfvideoadapter.h 
>                                             /mdfpluginmanager.cpp 
>                                             /mdfvideoadapter.cpp 
>                                             /mdfvidrend.cpp 
>     client/build/BIF/hxclient_2_1_0_cayennes.bif 
>     common/build/BIF/helix.bif
> 
> Image Size and Heap Use impact: 
>     slight increase in heap and image size
> 
> Platforms and Profiles Build Verified: 
>     armv5 / helix-client-s60-32-mmf-mdf-dsp, 
> helix-client-s60-32-mmf-mdf-arm
>     winscw / helix-client-s60-32-mmf-mdf-arm
> 
> Platforms and Profiles Functionality verified: 
>     armv5 / helix-client-s60-32-mmf-mdf-arm
> 
> Branch: 
>     HEAD and hxclient_2_1_0_cayennes
> 
> <<Codec Selection Rules.ppt>>
> <<datatype_mdf_video_renderer1.diff>>
> <<datatype_mdf_video_format.diff>> <<bif-cvs.diff>>
> 
>