Here are my comments:

1) CXPSRtpFlSrc.cpp - should probably
   NULL out m_pXPSPacketSink after deleting it
   in destructor
2) CXPSRtpFlSrc.cpp - should check for NULL after allocating here:

        char*   strXPSFileName  = new char[FILE_NAME_LEN];
	    char*   strBuffer       = new char[MAX_BUFF_LEN];
        char*   strRTPDataDir   = new char[FILE_NAME_LEN];

3 In CXPSRTPPktFlReader::Init, I would check for NULL
  after allocating here:

    char* strIdxFileName = new char[FILE_NAME_LEN];
    char* strDatFileName = new char[FILE_NAME_LEN];

Rest looks good.

Eric

=============================================
Eric Hyche (ehyche at real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounces at helixcommunity.org 
> [mailto:datatype-dev-bounces at helixcommunity.org] On Behalf Of 
> rajesh.rathinasamy at nokia.com
> Sent: Saturday, November 04, 2006 5:14 PM
> To: datatype-dev at helixcommunity.org
> Subject: [datatype-dev] CR: Symbian XPS test library
> 
> "Nokia submits this code under the terms of a commercial 
> contribution agreement with RealNetworks, and I am authorized 
> to contribute this code under said agreement."
> 
> 	Modified by:  rajesh.rathinasamy at nokia.com 
> 
> 	Reviewed by: 
> 
> 	Date: 02-Nov-2006. 
> 
> 	Project: SymbianMmf 
> 
> 	ErrorId: ** New Featue ** 
> 
> 	Synopsis:  CR: Symbian XPS test library 
> 
> 	        The test library is a sample use case for the 
> XPSPacketSink. It reads the RTP packets and header (only 
> required headers are dumped) from a file and supplies to the 
> packet sink. 
> 
> 	I will send out a standalone test app soon which gives 
> a complete usage of CVideoPlayer utility and XPSPacketSink. 
> 
> 	Also attaching a sample hdr file. Payload file contains 
> RTP payload dump. 
> 
> 	Files Modified: 
> 	=========== 
> 	Datatype\xps\test\umakefil 
> 
> 	Files Added: 
> 	========== 
> 	Datatype\xps\test\CXPSRtpFlSrc.h 
> 	Datatype\xps\test\CXPSRtpFlSrc.cpp 
> 	Datatype\xps\test\CXPSRTPPktFlReader.h 
> 	Datatype\xps\test\CXPSRTPPktFlReader.cpp 
> 
> 	Image Size and Heap Use impact: no major impact 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-mmf-mdf-arm 
> 
> 	Platforms and Profiles Functionality verified: armv5, winscw 
> 
>      Branch: Helix, 210CayS 
> 
> Index: Umakefil 
> =================================================================== 
> RCS file: /cvsroot/datatype/xps/test/Umakefil,v 
> retrieving revision 1.1.1.1 
> diff -w -u -b -r1.1.1.1 Umakefil 
> --- Umakefil    4 Oct 2006 15:28:18 -0000       1.1.1.1 
> +++ Umakefil    3 Nov 2006 03:45:29 -0000 
> @@ -63,8 +63,7 @@ 
> 
>  UmakefileVersion(2,1) 
> 
> -#MultiTargetMake("XPSRtpFlSrcLib") 
> -EmptyTarget() 
> +MultiTargetMake("XPSRtpFlSrcLib") 
> 
> 
> <<CXPSRtpFlSrc.h>> <<CXPSRTPPktFlReader.cpp>> 
> <<CXPSRTPPktFlReader.h>> <<CXPSRtpFlSrc.cpp>> 
> <<stream0.hdr>> 
> 
> 
>