Ah, sorry. The file *was* added, the problem is that you added an
include dependency on datatype/include but didn't add the
dependency to the bif, so datatype/include is not checked out as
a dependency for datatype_mp4_fileformat.

Jamie

Arnel.Periquet at nokia.com wrote:
> I performed a clean build, i.e. allow the build system to perform a
> checkout to an empty directory, for Symbian thumb, Symbian emulator, and
> linux. I verified functionality on Symbian thumb and emulator, and I
> verified existence of all required files and changes in Linux.
> 
> -Arnel
>  
> 
> 
>>-----Original Message-----
>>From: ext Jamie Gordon [mailto:jgordon at real.com] 
>>Sent: Tuesday, October 11, 2005 4:17 PM
>>To: Periquet Arnel (Nokia-TP-MSW/Dallas)
>>Cc: datatype-dev at helixcommunity.org
>>Subject: Re: [datatype-dev] [clientapps-dev] CN-Client: 
>>Support for3GPPAssetInfo Meta-Data
>>
>>mp4fformat is now failing to build - it seems there is 
>>supposed to be a new file which was not checked in.
>>
>>qtffplin.cpp(91) : fatal error C1083: Cannot open include file: 
>>'metainfokeys.h': No such file or directory
>>
>>Thanks,
>>Jamie
>>
>>Arnel.Periquet at nokia.com wrote:
>>
>>>Checked into HEAD.
>>>
>>>Thanks,
>>>Arnel
>>>
>>>
>>>
>>>>-----Original Message-----
>>>>From: datatype-dev-bounces at helixcommunity.org
>>>>[mailto:datatype-dev-bounces at helixcommunity.org]
>>>>Sent: Tuesday, October 11, 2005 10:29 AM
>>>>To: ehyche at real.com; datatype-dev at helixcommunity.org; 
>>>>clientapps-dev at helixcommunity.org
>>>>Subject: RE: [datatype-dev] [clientapps-dev] re:CR-Client: 
>>>>Support for3GPPAssetInfo Meta-Data
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>>-----Original Message-----
>>>>>From: ext Eric Hyche [mailto:ehyche at real.com]
>>>>>Sent: Tuesday, October 11, 2005 8:41 AM
>>>>>To: Periquet Arnel (Nokia-TP-MSW/Dallas); 
>>>>>datatype-dev at helixcommunity.org; clientapps-dev at helixcommunity.org
>>>>>Subject: RE: [datatype-dev] [clientapps-dev] re:CR-Client: 
>>>>>Support for 3GPPAssetInfo Meta-Data
>>>>>
>>>>>
>>>>>My comments:
>>>>>
>>>>>1) In the GPS coordinates meta info, you have these
>>>>> comments:
>>>>>
>>>>> +    // valid latitude values are -90 <= x <= +90
>>>>> +    LONG32 GetLatitude_WholePart(void) 
>>>>> ...
>>>>> +    // fractional 16-bits is assumed to be positive 0 <= x 
>>>>><= +65535
>>>>> +    LONG32 GetLatitude_FractionalPart(void)
>>>>>
>>>>> but your format string is:
>>>>>
>>>>> +        // 3GP Asset Info: Location Info: Latitude
>>>>> +        SafeSprintf(strPos, 50, "%lu.%lu", lat_wholePart, 
>>>>>lat_fractionalPart);
>>>>> +        status = SetPropertyOnHeader(status, pHeader,
>>>>> +                    META_INFO_LOCATION_LATITUDE_KEY, 
>>>>>strPos, strlen(strPos));
>>>>>
>>>>> So shouldn't that be:
>>>>>
>>>>> +        SafeSprintf(strPos, 50, "%ld.%lu", lat_wholePart, 
>>>>>lat_fractionalPart);
>>>>>
>>>>> replacing the first "%lu" with a "%ld"?
>>>>>
>>>>
>>>>Good catch.
>>>>
>>>>
>>>>
>>>>>2) Just to avoid #define collision, you might consider
>>>>> renaming the META_INFO_xxxx_KEY defines to
>>>>> 3GPP_META_INFO_xxxx_KEY.
>>>>>
>>>>>Rest looks good.
>>>>>
>>>>
>>>>I'll check-in after I test the above modifications.
>>>>
>>>>Thanks,
>>>>Arnel
>>>>
>>>>
>>>>
>>>>>Eric
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>-----Original Message-----
>>>>>>From: datatype-dev-bounces at helixcommunity.org
>>>>>>[mailto:datatype-dev-bounces at helixcommunity.org] On Behalf Of 
>>>>>>Arnel.Periquet at nokia.com
>>>>>>Sent: Monday, October 10, 2005 5:34 PM
>>>>>>To: datatype-dev at helixcommunity.org;
>>>>>
>>>>>clientapps-dev at helixcommunity.org
>>>>>
>>>>>
>>>>>>Subject: [datatype-dev] [clientapps-dev] re:CR-Client: 
>>>>>>Support for 3GPPAssetInfo Meta-Data
>>>>>>
>>>>>>The following changes have been incorporated and tested:
>>>>>>		
>>>>>>1) Check for out-of-range parameters in additon to using HX_ASSERT
>>>>>>2) Ensure all meta-info is stored as buffers instead of strings
>>>>>>3) Use only a single standard key for each meta-info,
>>>>>
>>>>>overriding more
>>>>>
>>>>>
>>>>>>general atoms where necessary
>>>>>>4) Use all existing standard meta-info labels and keys where they 
>>>>>>exist, adding new labels and keys that are generic and
>>>>>
>>>>>consistent with
>>>>>
>>>>>
>>>>>>the existing ones
>>>>>>5) #define keys in a common header file => 
>>>>>>datatype/include/metainfokeys.h
>>>>>>6) update common/util/pckunpck.cpp to consistently allow 
>>
>>for buffer 
>>
>>>>>>versus string based storage
>>>>>>
>>>>>>		
>>>>>>The full set of files and diffs are attached.
>>>>>>		
>>>>>>Arnel
>>>>>>
>>>>>>
>>>>>>
>>>>>>>-----Original Message-----
>>>>>>>From: clientapps-dev-bounces at helixcommunity.org
>>>>>>>[mailto:clientapps-dev-bounces at helixcommunity.org]
>>>>>>>Sent: Monday, October 03, 2005 10:07 AM
>>>>>>>To: datatype-dev at helixcommunity.org;
>>>>>>
>>>>>>clientapps-dev at helixcommunity.org
>>>>>>
>>>>>>
>>>>>>>Subject: [datatype-dev] [clientapps-dev] CR-Client: Support
>>>>>
>>>>>for 3GPP
>>>>>
>>>>>
>>>>>>>AssetInfo Meta-Data
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>"Nokia is bound by the terms of a commercial contribution
>>>>>>
>>>>>>agreement
>>>>>>
>>>>>>
>>>>>>>>with RealNetworks, and I am authorized to contribute this
>>>>>>
>>>>>>code under
>>>>>>
>>>>>>
>>>>>>>>said agreement."
>>>>>>>>
>>>>>>>>Modified by:  Arnel.Periquet at nokia.com
>>>>>>>>
>>>>>>>>Reviewed by:
>>>>>>>>
>>>>>>>>Date: 09-30-2005.
>>>>>>>>
>>>>>>>>Project: datatype/mp4/fileformat; symbianplayer
>>>>>>>>
>>>>>>>>Synopsis: 
>>>>>>>>
>>>>>>>>This feature captures the Asset Info Meta-Data defined by
>>>>>>
>>>>>>3GP Rel 6
>>>>>>
>>>>>>
>>>>>>>>and makes that data available to a top-level client such as the 
>>>>>>>>Symbian Player. The Symbian Player is also modified to
>>>>>>>
>>>>>>>expose some of
>>>>>>>
>>>>>>>
>>>>>>>>this meta-data in its "Clip Info"
>>>>>>>>pop-up.
>>>>>>>>
>>>>>>>>The following files are modified to capture the meta-data
>>>>>>
>>>>>>and make it
>>>>>>
>>>>>>
>>>>>>>>available:
>>>>>>>>
>>>>>>>>	qtatoms.h - perf, gnre, rtng, clsf, kywd, loci atoms are added
>>>>>>>>	qtatoms.cpp - factory method is modified to return new
>>>>>>>
>>>>>>>instances of
>>>>>>>
>>>>>>>
>>>>>>>>above atoms
>>>>>>>>	qtatmmgs.h - CQT_TrackInfoManager is modified to cache
>>>>>>>
>>>>>>>access to
>>>>>>>
>>>>>>>
>>>>>>>>meta-data
>>>>>>>>	qtatmmgs.cpp - implement caching of meta-data
>>>>>>>>	qtffplin.h - new helper method added to interface
>>>>>>>>	qtffplin.cpp - helper method defined to add meta-data
>>>>>>>
>>>>>>>to FileHeader
>>>>>>>
>>>>>>>
>>>>>>>>property list
>>>>>>>>		      method MakeFileHeader() is modified to
>>>>>>>
>>>>>>>add metadata using
>>>>>>>
>>>>>>>
>>>>>>>>helper
>>>>>>>>
>>>>>>>>The following files are modified to display new meta-data in the 
>>>>>>>>Symbian Player:
>>>>>>>>
>>>>>>>>	rop_string.rss - string resource constants are defined
>>>>>>>
>>>>>>>as labels for
>>>>>>>
>>>>>>>
>>>>>>>>meta-info
>>>>>>>>	realplayer.loc - localization is provided to enable
>>>>>>>
>>>>>>>English display
>>>>>>>
>>>>>>>
>>>>>>>>of labels
>>>>>>>>	chxavplayer.EN - defines English labels
>>>>>>>>	chxavclipinfolist.cpp - BuildClipInfoL() is modified to
>>>>>>>
>>>>>>>add metadata
>>>>>>>
>>>>>>>
>>>>>>>>to "Clip Info"
>>>>>>>>
>>>>>>>>Image Size and Heap Use impact: Minor.
>>>>>>>>
>>>>>>>>Platforms and Profiles Build Verified: helix-client-s60-advanced
>>>>>>>>
>>>>>>>>Platforms and Profiles Functionality verified: thumb, wins
>>>>>>>>
>>>>>>>>Branch: helix_restricted
>>>>>>>>
>>>>>>>>Diffs: attached
>>>>>>>>
>>