[datatype-dev] RE: [Ribosome-dev] change for fix build error for symbain80 regardingMDF feature

[datatype-dev] RE: [Ribosome-dev] change for fix build error for symbain80 regardingMDF feature

Ashish.As.Gupta at nokia.com Ashish.As.Gupta at nokia.com
Fri Oct 7 12:36:17 PDT 2005


Edgar,
As Greg also mentioned that removing the feature from basic and advanced
profile is fine. Regarding Umakefil, MDF feature is really not dependent
on symbian version. It will exists beyond symbian90 and symbian91.
On another note, we are trying to avoid the ifdefs with the symbian
versions. This will minimize the changes to the source as symbian move
forwards with the new versions. In the same direction, we are trying to
replace 90 and 91 ifdefs with the platform security feature.

I believe that we don't need to add the HELIX_FEATURE_SYMBIAN_MDF in
Umakefil, as it can be added to helix-client-s60-mmf-basic.pf.
John,
what do you say?

Thanks
Ashish


>-----Original Message-----
>From: ribosome-dev-bounces at helixcommunity.org 
>[mailto:ribosome-dev-bounces at helixcommunity.org] On Behalf Of 
>ext Edgar Luevano
>Sent: Friday, October 07, 2005 12:01 PM
>To: datatype
>Cc: ribosome-dev at helixcommunity.org
>Subject: [Ribosome-dev] change for fix build error for 
>symbain80 regardingMDF feature
>
>The adding of the HELIX_FEATURE_SYMBIAN_MDF feature makes 
>symbian80 build to break.
>
>What do you think of this fix:
>
>Index: umakepf/helix-client-s60-advanced.pf
>===================================================================
>RCS file: 
>/cvsroot/ribosome/build/umakepf/helix-client-s60-advanced.pf,v
>retrieving revision 1.10
>diff -u -r1.10 helix-client-s60-advanced.pf
>--- umakepf/helix-client-s60-advanced.pf	6 Oct 2005 
>12:24:20 -0000	1.10
>+++ umakepf/helix-client-s60-advanced.pf	7 Oct 2005 
>16:50:16 -0000
>@@ -51,7 +51,7 @@
> #
> #
> project.AddDefines('HELIX_PROFILE_S60_ADVANCED')
>-project.AddDefines('HELIX_FEATURE_SYMBIAN_MDF')
> 
> ## Edit below this Line
> #####################################################################
>Index: umakepf/helix-client-s60-basic.pf 
>===================================================================
>RCS file: /cvsroot/ribosome/build/umakepf/helix-client-s60-basic.pf,v
>retrieving revision 1.8
>diff -u -r1.8 helix-client-s60-basic.pf
>--- umakepf/helix-client-s60-basic.pf	6 Oct 2005 12:14:54 
>-0000	1.8
>+++ umakepf/helix-client-s60-basic.pf	6 Oct 2005 21:58:38 -0000
>@@ -51,7 +51,7 @@
> #
> #
> project.AddDefines('HELIX_PROFILE_S60_BASIC')
>-project.AddDefines('HELIX_FEATURE_SYMBIAN_MDF')
>
>
>
>In datatype:
>Index: group/video/Umakefil
>===================================================================
>RCS file: /cvsroot/datatype/group/video/Umakefil,v
>retrieving revision 1.7
>diff -u -r1.7 Umakefil
>--- group/video/Umakefil	6 Oct 2005 12:05:21 -0000	1.7
>+++ group/video/Umakefil	7 Oct 2005 16:53:56 -0000
>@@ -37,6 +37,10 @@
> 
> UmakefileVersion(2,2)
> 
>+if project.IsDefined("_SYMBIAN_91_"):
>+	project.AddDefines("HELIX_FEATURE_SYMBIAN_MDF")
>+
>+
> project.AddModuleIncludes("common/include",
>                           "video/include",
>                           "client/include",
>
>just one question MDF featire is only for symbain91 or also 
>for Symbian90,
>in that case 
>it should be:
>
>+if project.IsDefined("_SYMBIAN_91_") or 
>project.IsDefined("_SYMBIAN_90_"):
>+	project.AddDefines("HELIX_FEATURE_SYMBIAN_MDF")
>+
>+
> project.AddModuleIncludes("common/include",
>                           "video/include",
>                           "client/include",
>
>Thank you
>
>
>Edgar Luevano 
>Dextratech Technologies
>Monterrey, N.L
>Mexico
>+52 81 82202010
>www.dextratech.com
>
>
>_______________________________________________
>Ribosome-dev mailing list
>Ribosome-dev at helixcommunity.org
>http://lists.helixcommunity.org/mailman/listinfo/ribosome-dev
>



More information about the Datatype-dev mailing list
 

Site Map   |   Terms of Use   |   Privacy Policy   |   Contact Us

Copyright © 1995-2007 RealNetworks, Inc. All rights reserved. RealNetworks and Helix are trademarks of RealNetworks.
All other trademarks or registered trademarks are the property of their respective holders.