ok for listed branches

On Mon, Apr 25, 2005 at 02:45:52PM -0700, Jingjian Zeng wrote:
> 
> Synopsis
> ========
> Fixes Bug 134039: Win: Producer Broadcast crashes when using DNS name instead of IP
> 
> Branches: SERVER_11_0_STABLE, HEAD (SERVER_CURRENT) 
> Suggested Reviewer: 
> 
> 
> Description
> ===========
> 
> This bug only happened on win32 boxes with DHCP on.  It won't happen on boxes with static IPs, and
> that's why some of us had difficulty on reproing.
> 
> The fix is pretty obvious: we need to reset len before passing it RegQueryValueEx again.
> 
> Files Affected
> ==============
> 
> common/netio/iresolv.cpp
> 
> 
> Testing Performed
> =================
> 
> Unit Tests:
> 
> Verify the internal resolver working well.
> 
> 
> Integration Tests:
> 
> N/A
> 
> Leak Tests:
> N/A
> 
> Performance Tests:
> N/A
> 
> Platforms Tested:  win32-i386-vc7
> Build verified:  win32-i386-vc7
> 

> ? common_netio.sln
> ? common_netio.vcproj
> ? dbg32
> ? Makefile
> ? resolver.diff
> ? Umakefil.upp
> Index: iresolv.cpp
> ===================================================================
> RCS file: /cvsroot/common/netio/iresolv.cpp,v
> retrieving revision 1.20.2.2
> diff -u -r1.20.2.2 iresolv.cpp
> --- iresolv.cpp	23 Feb 2005 04:27:42 -0000	1.20.2.2
> +++ iresolv.cpp	25 Apr 2005 21:38:20 -0000
> @@ -1430,6 +1430,7 @@
>                                       val, &len);
>                  if (rc != ERROR_SUCCESS || val[0] == '\0')
>                  {
> +                    len = sizeof(val);
>                      rc = RegQueryValueEx(hkif, "DhcpNameServer", NULL, NULL,
>                                           val, &len);
>                  }

> _______________________________________________
> Helix-server-dev mailing list
> Helix-server-dev at helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/helix-server-dev


-- 
Dean Collins
Server Technical Lead, RealNetworks, Inc. -- http://www.realnetworks.com
Helix Server Project Owner -- http://helix-server.helixcommunity.org