[Common-dev] CR-Client-Resend: Remaining warnings removal
Felipe Lugo flugo at dextratech.com-----Original Message----- From: common-dev-bounces at helixcommunity.org [mailto:common-dev-bounces at helixcommunity.org]On Behalf Of Alberto Meza Sent: Wednesday, April 06, 2005 4:00 PM To: common-dev Subject: [Common-dev] CR: Remaining warnings removal Modified by:ameza at dextratech.com Reviewed by: Date:4/6/2005 Project:Helix Symbian Port Synopsis: Remove "unused variables", "multiline commented", "reorder to match", "comparission between signed and unsigned", "partly bracketed" and "enumeration value" warnings container/pub/hxbuffer.h util/asmrulep.cpp util/chxuuid.cpp util/commreg.cpp util/cookies.cpp util/hxurlrep.cpp util/key.cpp util/portaddr.cpp Branch: 150Cay and HEAD Copyright assignment: I agree to assign to RealNetworks full copyright ownership of the code represented by the attached patch. I warrant that I am legally entitled to grant the copyright assignment and that my contribution does not violate any law or breach any contract. I understand that RealNetworks may license this code under RPSL, RCSL, and/or any other license at RealNetworks' sole discretion. Index: container/pub/hxbuffer.h =================================================================== RCS file: /cvsroot/common/container/pub/hxbuffer.h,v retrieving revision 1.12 diff -u -w -r1.12 hxbuffer.h --- container/pub/hxbuffer.h 14 Mar 2005 19:33:48 -0000 1.12 +++ container/pub/hxbuffer.h 5 Apr 2005 21:26:53 -0000 @@ -72,7 +72,7 @@ // However, since the size of the structure is larger than 15 bytes on // 64-bit systems we are now using this compile-time size calculation to // ensure that the structure is of sufficient size. -const int MaxPnbufShortDataLen = HX_MAX(sizeof(_BigData), 15); +const UINT32 MaxPnbufShortDataLen = HX_MAX(sizeof(_BigData), 15); #endif #define NUM_ALLOCATION_EACH_TIME 25 Index: util/asmrulep.cpp =================================================================== RCS file: /cvsroot/common/util/asmrulep.cpp,v retrieving revision 1.20 diff -u -w -r1.20 asmrulep.cpp --- util/asmrulep.cpp 17 Mar 2005 21:10:59 -0000 1.20 +++ util/asmrulep.cpp 5 Apr 2005 21:47:42 -0000 @@ -1673,6 +1673,14 @@ break; case HX_RE_LESSEQUAL: pOp->m_Data = HX_RE_GREATEREQUAL; + break; + case HX_RE_EQUAL: + break; + case HX_RE_NOTEQUAL: + break; + case HX_RE_AND: + break; + case HX_RE_OR: break; }; } Index: util/chxuuid.cpp =================================================================== RCS file: /cvsroot/common/util/chxuuid.cpp,v retrieving revision 1.12 diff -u -w -r1.12 chxuuid.cpp --- util/chxuuid.cpp 14 Mar 2005 19:36:39 -0000 1.12 +++ util/chxuuid.cpp 5 Apr 2005 21:47:42 -0000 @@ -720,8 +720,8 @@ * **************************************************************************** / -static const uuid_tt uuid_g_nil_uuid = { 0, 0, 0, 0, 0, 0 }; -static const uuid_tt uuid_nil = { 0, 0, 0, 0, 0, 0 }; +static const uuid_tt uuid_g_nil_uuid = { 0, 0, 0, 0, 0, {0,0,0,0,0,0} }; +static const uuid_tt uuid_nil = { 0, 0, 0, 0, 0, {0,0,0,0,0,0} }; /* * Check the reserved bits to make sure the UUID is of the known structure. Index: util/commreg.cpp =================================================================== RCS file: /cvsroot/common/util/commreg.cpp,v retrieving revision 1.15 diff -u -w -r1.15 commreg.cpp --- util/commreg.cpp 16 Mar 2005 22:49:09 -0000 1.15 +++ util/commreg.cpp 5 Apr 2005 21:49:41 -0000 @@ -998,8 +998,6 @@ { DB_node* d = 0; Property* p = 0; - UINT32 h = hash_key; - d = (DB_node *)_ids->get(hash_key); if (!d) { Index: util/cookies.cpp =================================================================== RCS file: /cvsroot/common/util/cookies.cpp,v retrieving revision 1.28 diff -u -w -r1.28 cookies.cpp --- util/cookies.cpp 23 Mar 2005 23:53:47 -0000 1.28 +++ util/cookies.cpp 5 Apr 2005 21:52:12 -0000 @@ -1837,7 +1837,6 @@ { HX_RESULT hr = HXR_OK; CHXSimpleList* pNewRMCookies = NULL; - CHXSimpleList::Iterator i; CookieStruct* pCookie = NULL; HXBOOL bCookieFileModified = FALSE; Index: util/hxurlrep.cpp =================================================================== RCS file: /cvsroot/common/util/hxurlrep.cpp,v retrieving revision 1.7 diff -u -w -r1.7 hxurlrep.cpp --- util/hxurlrep.cpp 16 Dec 2004 00:50:14 -0000 1.7 +++ util/hxurlrep.cpp 5 Apr 2005 23:19:06 -0000 @@ -528,8 +528,8 @@ if (!token.IsEmpty()) { // rfc does not specify a limit; we base limit on our storage limit (INT_MAX) - const int PORT_MAX_DIGIT_COUNT = 10; - const int PORT_MAX_VALUE = INT_MAX; + const unsigned int PORT_MAX_DIGIT_COUNT = 10; + const unsigned int PORT_MAX_VALUE = INT_MAX; if (token.GetLength() <= PORT_MAX_DIGIT_COUNT && IsAllDigits(token)) { UINT32 val = strtoul(token, NULL, 10); Index: util/key.cpp =================================================================== RCS file: /cvsroot/common/util/key.cpp,v retrieving revision 1.12 diff -u -w -r1.12 key.cpp --- util/key.cpp 16 Mar 2005 22:49:09 -0000 1.12 +++ util/key.cpp 5 Apr 2005 16:48:50 -0000 @@ -60,8 +60,7 @@ #define MAX_NUM_LEVELS 255 Key::Key(const char * s, char d) - : m_LastError(HXR_OK) - , _key_str(NULL) + : _key_str(NULL) , _curr_ptr(NULL) , _curr_level(0) , _last_sub_str(NULL) @@ -69,6 +68,7 @@ , _size(0) , _num_levels(0) , _sub_strs(NULL) + , m_LastError(HXR_OK) { if (!s && !*s) return; Index: util/portaddr.cpp =================================================================== RCS file: /cvsroot/common/util/portaddr.cpp,v retrieving revision 1.12 diff -u -w -r1.12 portaddr.cpp --- util/portaddr.cpp 14 Mar 2005 19:36:39 -0000 1.12 +++ util/portaddr.cpp 5 Apr 2005 21:41:54 -0000 @@ -426,7 +426,6 @@ SubnetEntry::SubnetEntry(const char* pszValue) : CommonEntry(pszValue) { - UINT8 size = 0; UINT32 ulIAddress = 0; char* pColumn = NULL;