[Common-dev] CN : Client PR 114604, Fix for bug [MP3 file named with specific Japanese character can not be played]
Anil Jaiswal ajaiswal at real.comChecked in to HEAD and Cayenne150 branches. Thanks. Modified by: ajaiswal at real.com Date : 04/21/2005 Project: HEAD and Cayenne150 Reviewed By: ping at real.com At 08:00 AM 4/21/2005 -0700, Henry Ping wrote: >Looks good to me. > >I assume the fix is for Cayenne150 and HEAD. Please indicate which branch >the fix will be applied to in your future CRs. > >-->Henry > > > -----Original Message----- > > From: common-dev-bounces at helixcommunity.org > > [mailto:common-dev-bounces at helixcommunity.org] On Behalf Of > > Anil Jaiswal > > Sent: Wednesday, April 20, 2005 5:45 PM > > To: common-dev at helixcommunity.org > > Cc: cayenne at real.com > > Subject: [Common-dev] CR Client PR 114604, Fix for bug [MP3 > > file named with specific Japanese character can not be played] > > > > Synopsis: Fix for bug 114604 [MP3 file named with specific > > Japanese character can not be played] > > > > Overview: > > MP3 file names which includes Japanese character '|' which > > lower byte has "0x7c" fails to play on Windows. > > > > Traced the problem to CSimpleFileObject::UpdateFileNameMember() > > which calls HXXFile::GetReasonableLocalFileName(). > > > > GetReasonableLocalFileName converts CHXString fileName to > > correct path by replacing all directory markers with correct > > platform specific directory markers. In this case it was also > > replacing '|' char with ':' which changes the name of file > > and was preventing RealPlayer on Windows to play Japanese > > clips with filename containing character '|'. > > > > Fix: > > For Windows char '|' is NOT to be replaced with any other > > characater, fixes the bug. > > > > Files Modified : > > common/fileio/hxxfile.cpp > > > > Files added : > > None. > > > > Image Size and Heap Use impact: > > None > > > > Platforms and Profiles Affected: > > All > > > > Platforms and Profiles Build Verified: > > Win32 > > > > Platforms and Profiles Functionality verified: > > Win32 > > > > cvs server: Diffing . > > Index: hxxfile.cpp > > =================================================================== > > RCS file: /cvsroot/common/fileio/hxxfile.cpp,v > > retrieving revision 1.11 > > diff -u -w -r1.11 hxxfile.cpp > > --- hxxfile.cpp 14 Mar 2005 19:36:28 -0000 1.11 > > +++ hxxfile.cpp 21 Apr 2005 00:17:54 -0000 > > @@ -191,25 +191,6 @@ > > } > > while(nFoundAt != -1); > > #endif > > - > > - > > - ////////////////////////////////////////////////////// > > - // Replace all drive markers with correct platform > > - // specific drive markers! > > - // > > -#if defined (_WINDOWS) > > - nFoundAt = 0; > > - do > > - { > > - nFoundAt = fileName.Find('|'); > > - if (nFoundAt != -1) > > - { > > - fileName.SetAt(nFoundAt,':'); > > - } > > - } > > - while(nFoundAt != -1); > > -#endif > > - > > } > > > > HXBOOL HXXFile::IsPlusURL(const char* pURL) > > > > > > _______________________________________________ > > Common-dev mailing list > > Common-dev at helixcommunity.org > > http://lists.helixcommunity.org/mailman/listinfo/common-dev