[Common-dev] [CR-common] viewsrc string allocation fix

[Common-dev] [CR-common] viewsrc string allocation fix

Ryan Gammon rgammon at real.com
Tue May 11 18:07:41 PDT 2004


Modified by: rgammon
Reviewed by:
       Date: May 11, 2004
    Project: Helix Player

Synopsis: 

HTTPConnection::OnTagDone calculates string allocations using sizeof(sz). Presumably at some point these strings were declared as char sz[]'s, but now are char* sz's. Size calculations are therefore now off.

Fix:

Use strlen instead of sizeof.

Files Modified: 

    client/viewsource/http_con.cpp

 Image Size and Heap Use impact: none
Platforms and Profiles Affected: all viewsource-enabled builds
Distribution Libraries affected: none

Distribution library impact and planned action: none
         Platforms and Profiles Build Verified: linux
 Platforms and Profiles Functionality verified: all-defines

Branch:
    
    130NepX, HEAD

QA Instructions: none.




-- 
Ryan Gammon
rgammon at real.com
Developer for Helix Player
https://player.helixcommunity.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: viewsrc.patch
Type: text/x-patch
Size: 1341 bytes
Desc: not available
Url : http://lists.helixcommunity.org/pipermail/common-dev/attachments/20040511/27b976e1/viewsrc-0001.bin


More information about the Common-dev mailing list
 

Site Map   |   Terms of Use   |   Privacy Policy   |   Contact Us

Copyright © 1995-2007 RealNetworks, Inc. All rights reserved. RealNetworks and Helix are trademarks of RealNetworks.
All other trademarks or registered trademarks are the property of their respective holders.