sounds good to me.

Aaron

On Mon, May 10, 2004 at 03:41:10PM -0700, Kevin Ross wrote:
> In common/fileio/platform/win/filespecutils.cpp, the following patch was 
> applied, supposedly to remove ShellExecuteEx call on CE, since it isn't 
> supported:
> 
>  #include "hlxclib/windows.h"
>  #include <winbase.h>
> +#ifndef _WINCE
>  #include <shlobj.h>
> +#else
> +#  ifdef NO_SHELLEXECUTE_EX_SUPPORT_
> +#    define LPSHELLEXECUTEINFO LPVOID
> +#    include <shlobj.h>
> +#    undef LPSHELLEXECUTEINFO
> +#  endif
> +#endif
> +
>  #include "hlxclib/sys/stat.h"
> 
> But unfortunately, this causes shlobj.h to not be included at all on Win CE 
> 3.0 builds, causing the build to fail.  Also, I don't see how this patch 
> fixes anything, since ShellExecuteEx isn't even used anywhere in this file!
> 
> I propose we just roll back this change.
> 
> -- Kevin
> 
> 
> _______________________________________________
> Common-dev mailing list
> Common-dev at lists.helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/common-dev